clocksource: ixp4xx: select TIMER_OF when needed
Subsystems (4)
PATCH 1/1 clocksource: ixp4xx: select TIMER_OF when needed
From: Arnd Bergmann <[email protected]>
Compile-testing the ixp4xx timer with CONFIG_OF enabled but CONFIG_TIMER_OF disabled leads to a harmless warning:
arm-linux-gnueabi-ld: warning: orphan section __timer_of_table' from drivers/clocksource/timer-ixp4xx.o' being placed in section `__timer_of_table'
Move the select statement from the platform code into the driver so it always gets enabled in configurations that rely on it.
--- arch/arm/mach-ixp4xx/Kconfig | 1 - drivers/clocksource/Kconfig | 1 + 2 files changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-ixp4xx/Kconfig +0 -1
@@ -13,7 +13,6 @@ config MACH_IXP4XX_OF select I2C select I2C_IOP3XX select PCI - select TIMER_OF select USE_OF help Say 'Y' here to support Device Tree-based IXP4xx platforms.
drivers/clocksource/Kconfig +1 -0
@@ -79,6 +79,7 @@ config IXP4XX_TIMER bool "Intel XScale IXP4xx timer driver" if COMPILE_TEST depends on HAS_IOMEM select CLKSRC_MMIO + select TIMER_OF if OF help Enables support for the Intel XScale IXP4xx SoC timer.
Signature · 1 line
2.29.2
Quoted 5 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Compile-testing the ixp4xx timer with
CONFIG_OFenabled butCONFIG_TIMER_OFdisabled leads to a harmless warning:
Quoted 7 lines
arm-linux-gnueabi-ld: warning: orphan section
__timer_of_table' fromdrivers/clocksource/timer-ixp4xx.o' being placed in section `__timer_of_table'Move the select statement from the platform code into the driver so it always gets enabled in configurations that rely on it.
Fixes 40df14cc5cc0 ("clocksource/drivers/ixp4xx: Add OF initialization support")Signed-off-by Arnd Bergmann <[email protected]>
That's a nice fix!
Yours,
Linus Walleij
[tip: timers/urgent] clocksource/drivers/ixp4xx: Select TIMER_OF when needed
In reply to Arnd BergmannThe following commit has been merged into the timers/urgent branch of tip:
The following commit has been merged into the timers/urgent branch of tip:
Commit-ID: 7a3b8758bd6e45f7b671723b5c9fa2b69d0787ae Gitweb: https://git.kernel.org/tip/7a3b8758bd6e45f7b671723b5c9fa2b69d0787ae Author: Arnd Bergmann <[email protected]> AuthorDate: Sun, 03 Jan 2021 14:59:24 +01:00 Committer: Daniel Lezcano <[email protected]> CommitterDate: Mon, 18 Jan 2021 16:20:15 +01:00
clocksource/drivers/ixp4xx: Select TIMER_OF when needed
Compile-testing the ixp4xx timer with CONFIG_OF enabled but CONFIG_TIMER_OF disabled leads to a harmless warning:
arm-linux-gnueabi-ld: warning: orphan section __timer_of_table' from drivers/clocksource/timer-ixp4xx.o' being placed in section `__timer_of_table'
Move the select statement from the platform code into the driver so it always gets enabled in configurations that rely on it.
--- arch/arm/mach-ixp4xx/Kconfig | 1 - drivers/clocksource/Kconfig | 1 + 2 files changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-ixp4xx/Kconfig +0 -1
@@ -13,7 +13,6 @@ config MACH_IXP4XX_OF select I2C select I2C_IOP3XX select PCI - select TIMER_OF select USE_OF help Say 'Y' here to support Device Tree-based IXP4xx platforms.
drivers/clocksource/Kconfig +1 -0
@@ -79,6 +79,7 @@ config IXP4XX_TIMER bool "Intel XScale IXP4xx timer driver" if COMPILE_TEST depends on HAS_IOMEM select CLKSRC_MMIO + select TIMER_OF if OF help Enables support for the Intel XScale IXP4xx SoC timer.