Skip to contentSkip to conversation

fs: block_dev.c: fix kernel-doc warnings from struct block_device changes

PATCH Applied Randy Dunlap 3 participants 3 messages Dec 29, 2020 – Jan 4, 2021 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: block_dev.c: fix kernel-doc warnings from struct block_device changes

Fix new kernel-doc warnings in fs/block_dev.c:

../fs/block_dev.c:1066: warning: Excess function parameter 'whole' description in 'bd_abort_claiming' ../fs/block_dev.c:1837: warning: Function parameter or member 'dev' not described in 'lookup_bdev'

Fixes 4e7b5671c6a8 ("block: remove i_bdev")
Fixes 37c3fc9abb25 ("block: simplify the block device claiming interface")
Cc Jens Axboe <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Alexander Viro <[email protected]>
---
 fs/block_dev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/block_dev.c +1 -1
@@ -1055,7 +1055,6 @@ static void bd_finish_claiming(struct bl
 /**
  * bd_abort_claiming - abort claiming of a block device
  * @bdev: block device of interest
- * @whole: whole block device
  * @holder: holder that has claimed @bdev
  *
  * Abort claiming of a block device when the exclusive open failed. This can be
@@ -1828,6 +1827,7 @@ const struct file_operations def_blk_fop
 /**
  * lookup_bdev  - lookup a struct block_device by name
  * @pathname:	special file representing the block device
+ * @dev:	return value of the block device's dev_t
  *
  * Get a reference to the blockdevice at @pathname in the current
  * namespace if possible and return it.  Return ERR_PTR(error)
Applied
#1 lore raw
Quoted 4 lines · Randy Dunlap

Fix new kernel-doc warnings in fs/block_dev.c:

../fs/block_dev.c:1066: warning: Excess function parameter 'whole' description in 'bd_abort_claiming' ../fs/block_dev.c:1837: warning: Function parameter or member 'dev' not described in 'lookup_bdev'

Applied, thanks.

Signature · 1 line
Jens Axboe