mhi: use irq_flags if controller driver configures it
PATCH v3 1/1 mhi: use irq_flags if controller driver configures it
If controller driver has specified the irq_flags, mhi uses this specified irq_flags. Otherwise, mhi uses default irq_flags.
The purpose of this change is to support one MSI vector for QCA6390. MHI will use one same MSI vector too in this scenario.
In case of one MSI vector, IRQ_NO_BALANCING is needed when irq handler is requested. The reason is if irq migration happens, the msi_data may change too. However, the msi_data is already programmed to QCA6390 hardware during initialization phase. This msi_data inconsistence will result in crash in kernel.
Another issue is in case of one MSI vector, IRQF_NO_SUSPEND will trigger WARNINGS because QCA6390 wants to disable the IRQ during the suspend.
To avoid above two issues, QCA6390 driver specifies the irq_flags in case of one MSI vector when mhi_register_controller is called.
---
v3:
- replace "client driver" with "controller driver"
- add Reviewed-by: Manivannan Sadhasivam
v2:
- document irq_flags added to mhi_controller
drivers/bus/mhi/core/init.c | 9 +++++++-- include/linux/mhi.h | 2 ++ 2 files changed, 9 insertions(+), 2 deletions(-)
drivers/bus/mhi/core/init.c +7 -2
@@ -148,12 +148,17 @@ int mhi_init_irq_setup(struct mhi_controller *mhi_cntrl) {struct mhi_event *mhi_event = mhi_cntrl->mhi_event;struct device *dev = &mhi_cntrl->mhi_dev->dev; +unsigned long irq_flags =IRQF_SHARED |IRQF_NO_SUSPEND ;int i, ret; +/* if controller driver has set irq_flags, use it */ +if (mhi_cntrl->irq_flags) + irq_flags = mhi_cntrl->irq_flags; +/* Setup BHI_INTVEC IRQ */ ret =request_threaded_irq (mhi_cntrl->irq[0 ], mhi_intvec_handler, mhi_intvec_threaded_handler, -IRQF_SHARED |IRQF_NO_SUSPEND , + irq_flags,"bhi" , mhi_cntrl);if (ret)return ret;
@@ -171,7 +176,7 @@ int mhi_init_irq_setup(struct mhi_controller *mhi_cntrl) ret =request_irq (mhi_cntrl->irq[mhi_event->irq], mhi_irq_handler, -IRQF_SHARED |IRQF_NO_SUSPEND , + irq_flags,"mhi" , mhi_event);if (ret) { dev_err(dev, "Error requesting irq:%d for ev:%d\n",
include/linux/mhi.h +2 -0
@@ -351,6 +351,7 @@ struct mhi_controller_config {* @fbc_download: MHI host needs to do complete image transfer (optional) * @pre_init: MHI host needs to do pre-initialization before power up * @wake_set: Device wakeup set flag +* @irq_flags: irq flags passed to request_irq (optional) * * Fields marked as (required) need to be populated by the controller driver * before calling mhi_register_controller(). For the fields marked as (optional)
@@ -440,6 +441,7 @@ struct mhi_controller {bool fbc_download;bool pre_init;bool wake_set; +unsigned long irq_flags; };/**
Signature · 7 lines
2.7.4 -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Manivannan Sadhasivam
AppliedQuoted 12 lines · Carl Huang
If controller driver has specified the
irq_flags, mhi uses this specifiedirq_flags. Otherwise, mhi uses defaultirq_flags.The purpose of this change is to support one MSI vector for QCA6390. MHI will use one same MSI vector too in this scenario.
In case of one MSI vector,
IRQ_NO_BALANCINGis needed when irq handler is requested. The reason is if irq migration happens, themsi_datamay change too. However, themsi_datais already programmed to QCA6390 hardware during initialization phase. Thismsi_datainconsistence will result in crash in kernel.
Quoted 8 lines
Another issue is in case of one MSI vector,
IRQF_NO_SUSPENDwill trigger WARNINGS because QCA6390 wants to disable the IRQ during the suspend.To avoid above two issues, QCA6390 driver specifies the
irq_flagsin case of one MSI vector whenmhi_register_controlleris called.Signed-off-by Carl Huang <[email protected]>Reviewed-by Manivannan Sadhasivam <[email protected]>
Applied to mhi-next!
Thanks,
Mani
Quoted 67 lines
---
v3:
- replace "client driver" with "controller driver"
- add Reviewed-by: Manivannan Sadhasivamv2:
- documentirq_flagsadded tomhi_controllerdrivers/bus/mhi/core/init.c | 9 +++++++-- include/linux/mhi.h | 2 ++ 2 files changed, 9 insertions(+), 2 deletions(-)drivers/bus/mhi/core/init.c +7
-2@@ -148,12 +148,17 @@ int mhi_init_irq_setup(struct mhi_controller *mhi_cntrl) {struct mhi_event *mhi_event = mhi_cntrl->mhi_event;struct device *dev = &mhi_cntrl->mhi_dev->dev; +unsigned long irq_flags =IRQF_SHARED |IRQF_NO_SUSPEND ;int i, ret; +/* if controller driver has set irq_flags, use it */ +if (mhi_cntrl->irq_flags) + irq_flags = mhi_cntrl->irq_flags; +/* Setup BHI_INTVEC IRQ */ ret =request_threaded_irq (mhi_cntrl->irq[0 ], mhi_intvec_handler, mhi_intvec_threaded_handler, -IRQF_SHARED |IRQF_NO_SUSPEND , + irq_flags,"bhi" , mhi_cntrl);if (ret)return ret;@@ -171,7 +176,7 @@ int mhi_init_irq_setup(struct mhi_controller *mhi_cntrl) ret =request_irq (mhi_cntrl->irq[mhi_event->irq], mhi_irq_handler, -IRQF_SHARED |IRQF_NO_SUSPEND , + irq_flags,"mhi" , mhi_event);if (ret) { dev_err(dev, "Error requesting irq:%d for ev:%d\n",include/linux/mhi.h +2
-0@@ -351,6 +351,7 @@ struct mhi_controller_config {* @fbc_download: MHI host needs to do complete image transfer (optional) * @pre_init: MHI host needs to do pre-initialization before power up * @wake_set: Device wakeup set flag +* @irq_flags: irq flags passed to request_irq (optional) * * Fields marked as (required) need to be populated by the controller driver * before calling mhi_register_controller(). For the fields marked as (optional) @@ -440,6 +441,7 @@ struct mhi_controller {bool fbc_download;bool pre_init;bool wake_set; +unsigned long irq_flags; };/** Signature · 1 line
2.7.4
Signature · 3 lines
ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 16 lines · Manivannan Sadhasivam
Quoted 15 lines · Carl Huang
If controller driver has specified the
irq_flags, mhi uses this specifiedirq_flags. Otherwise, mhi uses defaultirq_flags.The purpose of this change is to support one MSI vector for QCA6390. MHI will use one same MSI vector too in this scenario.
In case of one MSI vector,
IRQ_NO_BALANCINGis needed when irq handler is requested. The reason is if irq migration happens, themsi_datamay change too. However, themsi_datais already programmed to QCA6390 hardware during initialization phase. Thismsi_datainconsistence will result in crash in kernel.Another issue is in case of one MSI vector,
IRQF_NO_SUSPENDwill trigger WARNINGS because QCA6390 wants to disable the IRQ during the suspend.
Quoted 7 lines
Quoted 5 lines
To avoid above two issues, QCA6390 driver specifies the
irq_flagsin case of one MSI vector whenmhi_register_controlleris called.Signed-off-by Carl Huang <[email protected]>Reviewed-by Manivannan Sadhasivam <[email protected]>Applied to mhi-next!
Would it be possible again to have an immutable branch for this commit? We need it for implementing one MHI support to ath11k[1] required by Dell XPS 13 9310 laptops, which a lot of people are waiting. Otherwise I can only apply the feature for v5.13, which will be released on July.
[1] https://patchwork.kernel.org/project/linux-wireless/list/?series=405591&state=*
Signature · 8 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 24 lines · Kalle Valo
Quoted 22 lines · Manivannan Sadhasivam
Quoted 20 lines · Carl Huang
If controller driver has specified the
irq_flags, mhi uses this specifiedirq_flags. Otherwise, mhi uses defaultirq_flags.The purpose of this change is to support one MSI vector for QCA6390. MHI will use one same MSI vector too in this scenario.
In case of one MSI vector,
IRQ_NO_BALANCINGis needed when irq handler is requested. The reason is if irq migration happens, themsi_datamay change too. However, themsi_datais already programmed to QCA6390 hardware during initialization phase. Thismsi_datainconsistence will result in crash in kernel.Another issue is in case of one MSI vector,
IRQF_NO_SUSPENDwill trigger WARNINGS because QCA6390 wants to disable the IRQ during the suspend.To avoid above two issues, QCA6390 driver specifies the
irq_flagsin case of one MSI vector whenmhi_register_controlleris called.Signed-off-by Carl Huang <[email protected]>Reviewed-by Manivannan Sadhasivam <[email protected]>
Quoted 7 lines
Quoted 1 line
Applied to mhi-next!
Would it be possible again to have an immutable branch for this commit? We need it for implementing one MHI support to ath11k[1] required by Dell XPS 13 9310 laptops, which a lot of people are waiting. Otherwise I can only apply the feature for v5.13, which will be released on July.
Dropped this patch from mhi-next and applied to mhi-ath11k-immutable branch:
https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git/log/?h=mhi-ath11k-immutable
This branch will also be merged into mhi-next.
Thanks,
Mani
Signature · 3 lines
ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 33 lines · Manivannan Sadhasivam
Quoted 24 lines · Kalle Valo
Quoted 22 lines · Manivannan Sadhasivam
Quoted 20 lines · Carl Huang
If controller driver has specified the
irq_flags, mhi uses this specifiedirq_flags. Otherwise, mhi uses defaultirq_flags.The purpose of this change is to support one MSI vector for QCA6390. MHI will use one same MSI vector too in this scenario.
In case of one MSI vector,
IRQ_NO_BALANCINGis needed when irq handler is requested. The reason is if irq migration happens, themsi_datamay change too. However, themsi_datais already programmed to QCA6390 hardware during initialization phase. Thismsi_datainconsistence will result in crash in kernel.Another issue is in case of one MSI vector,
IRQF_NO_SUSPENDwill trigger WARNINGS because QCA6390 wants to disable the IRQ during the suspend.To avoid above two issues, QCA6390 driver specifies the
irq_flagsin case of one MSI vector whenmhi_register_controlleris called.Signed-off-by Carl Huang <[email protected]>Reviewed-by Manivannan Sadhasivam <[email protected]>Quoted 7 lines
Quoted 1 line
Applied to mhi-next!
Would it be possible again to have an immutable branch for this commit? We need it for implementing one MHI support to ath11k[1] required by Dell XPS 13 9310 laptops, which a lot of people are waiting. Otherwise I can only apply the feature for v5.13, which will be released on July.
Quoted 4 lines
Dropped this patch from mhi-next and applied to mhi-ath11k-immutable branch:
https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git/log/?h=mhi-ath11k-immutableThis branch will also be merged into mhi-next.
Thanks a lot!
And Greg will also pull this directly so that commit ids won't change? Just trying to avoid conflicts between ath and mhi trees as much as possible.
Signature · 8 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
Quoted 5 lines · Kalle Valo
Quoted 3 lines · Manivannan Sadhasivam
Quoted 2 lines · Kalle Valo
Manivannan Sadhasivam <[email protected]> writes:
[...]
Quoted 11 lines
Quoted 11 lines
Quoted 7 lines
Quoted 1 line
Applied to mhi-next!
Would it be possible again to have an immutable branch for this commit? We need it for implementing one MHI support to ath11k[1] required by Dell XPS 13 9310 laptops, which a lot of people are waiting. Otherwise I can only apply the feature for v5.13, which will be released on July.
Dropped this patch from mhi-next and applied to mhi-ath11k-immutable branch:
https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git/log/?h=mhi-ath11k-immutable
Quoted 8 lines
Quoted 1 line
This branch will also be merged into mhi-next.
Thanks a lot!
And Greg will also pull this directly so that commit ids won't change? Just trying to avoid conflicts between ath and mhi trees as much as possible.
Yes, I'm gonna send a PR to Greg this time also!
Thanks,
Mani
Quoted 4 lines
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Signature · 3 lines
ath11k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath11k
This patch was applied to qcom/linux.git (refs/heads/for-next):
Hello:
This patch was applied to qcom/linux.git (refs/heads/for-next):
Quoted 6 lines · On Mon, 4 Jan 2021 18:11:28 +0800 you wrote:
If controller driver has specified the
irq_flags, mhi uses this specifiedirq_flags. Otherwise, mhi uses defaultirq_flags.The purpose of this change is to support one MSI vector for QCA6390. MHI will use one same MSI vector too in this scenario.
Quoted 7 lines
In case of one MSI vector,
IRQ_NO_BALANCINGis needed when irq handler is requested. The reason is if irq migration happens, themsi_datamay change too. However, themsi_datais already programmed to QCA6390 hardware during initialization phase. Thismsi_datainconsistence will result in crash in kernel.[...]
Here is the summary with links:
- [v3] mhi: use irq_flags if controller driver configures it
https://git.kernel.org/qcom/c/cdce2663ffb8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html