Skip to contentSkip to conversation

net/vmxnet3: Provided API to reset vmxnet device

PATCH Applied Dheemanth Mallikarjun 3 participants 4 messages Jan 5, 2021 – Feb 22, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 net/vmxnet3: Provided API to reset vmxnet device

The vmxnet3 driver didn't have the dev_reset function pointer set. Hence, provided the necessary function pointer so that DPDK developers can use the rte_eth_dev_reset API to reset the vmxnet3 device data.

---
 drivers/net/vmxnet3/vmxnet3_ethdev.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/net/vmxnet3/vmxnet3_ethdev.c +14 -0
index 23a2ebbef..814ccfa79 100644
@@ -67,6 +67,7 @@ static int vmxnet3_dev_configure(struct rte_eth_dev *dev);
 static int vmxnet3_dev_start(struct rte_eth_dev *dev);
 static int vmxnet3_dev_stop(struct rte_eth_dev *dev);
 static int vmxnet3_dev_close(struct rte_eth_dev *dev);
+static int vmxnet3_dev_reset(struct rte_eth_dev *dev);
 static void vmxnet3_dev_set_rxmode(struct vmxnet3_hw *hw, uint32_t feature, int set);
 static int vmxnet3_dev_promiscuous_enable(struct rte_eth_dev *dev);
 static int vmxnet3_dev_promiscuous_disable(struct rte_eth_dev *dev);
@@ -112,6 +113,7 @@ static const struct eth_dev_ops vmxnet3_eth_dev_ops = {
 	.dev_start            = vmxnet3_dev_start,
 	.dev_stop             = vmxnet3_dev_stop,
 	.dev_close            = vmxnet3_dev_close,
+	.dev_reset            = vmxnet3_dev_reset,
 	.promiscuous_enable   = vmxnet3_dev_promiscuous_enable,
 	.promiscuous_disable  = vmxnet3_dev_promiscuous_disable,
 	.allmulticast_enable  = vmxnet3_dev_allmulticast_enable,
@@ -913,6 +915,18 @@ vmxnet3_dev_close(struct rte_eth_dev *dev)
 	return ret;
 }
 
+static int
+vmxnet3_dev_reset(struct rte_eth_dev *dev)
+{
+	int ret;
+
+	ret = eth_vmxnet3_dev_uninit(dev);
+	if (ret)
+		return ret;
+	ret = eth_vmxnet3_dev_init(dev);
+	return ret;
+}
+
 static void
 vmxnet3_hw_tx_stats_get(struct vmxnet3_hw *hw, unsigned int q,
 			struct UPT1_TxStats *res)
Signature · 1 line
2.17.1
#1 lore raw
Quoted 40 lines · Dheemanth Mallikarjun

The vmxnet3 driver didn't have the dev_reset function pointer set. Hence, provided the necessary function pointer so that DPDK developers can use the rte_eth_dev_reset API to reset the vmxnet3 device data.

---
  drivers/net/vmxnet3/vmxnet3_ethdev.c | 14 ++++++++++++++
  1 file changed, 14 insertions(+)
drivers/net/vmxnet3/vmxnet3_ethdev.c +7 -0
index 23a2ebbef..814ccfa79 100644
@@ -67,6 +67,7 @@ static int vmxnet3_dev_configure(struct rte_eth_dev *dev);
  static int vmxnet3_dev_start(struct rte_eth_dev *dev);
  static int vmxnet3_dev_stop(struct rte_eth_dev *dev);
  static int vmxnet3_dev_close(struct rte_eth_dev *dev);
+static int vmxnet3_dev_reset(struct rte_eth_dev *dev);
  static void vmxnet3_dev_set_rxmode(struct vmxnet3_hw *hw, uint32_t feature, int set);
  static int vmxnet3_dev_promiscuous_enable(struct rte_eth_dev *dev);
  static int vmxnet3_dev_promiscuous_disable(struct rte_eth_dev *dev);
@@ -112,6 +113,7 @@ static const struct eth_dev_ops vmxnet3_eth_dev_ops = {
  	.dev_start            = vmxnet3_dev_start,
  	.dev_stop             = vmxnet3_dev_stop,
  	.dev_close            = vmxnet3_dev_close,
+	.dev_reset            = vmxnet3_dev_reset,
  	.promiscuous_enable   = vmxnet3_dev_promiscuous_enable,
  	.promiscuous_disable  = vmxnet3_dev_promiscuous_disable,
  	.allmulticast_enable  = vmxnet3_dev_allmulticast_enable,
@@ -913,6 +915,18 @@ vmxnet3_dev_close(struct rte_eth_dev *dev)
  	return ret;
  }
 
+static int
+vmxnet3_dev_reset(struct rte_eth_dev *dev)
+{
+	int ret;
+

drivers/net/vmxnet3/vmxnet3_ethdev.c vmxnet3_dev_close(struct rte_eth_dev *dev) · line 932

Quoted 10 lines
drivers/net/vmxnet3/vmxnet3_ethdev.c +7 -0
+	ret = eth_vmxnet3_dev_uninit(dev);
+	if (ret)
+		return ret;
+	ret = eth_vmxnet3_dev_init(dev);
+	return ret;
+}
+
  static void
  vmxnet3_hw_tx_stats_get(struct vmxnet3_hw *hw, unsigned int q,
  			struct UPT1_TxStats *res)

Hi Yong,

Can you please review this patch?

Thanks,
ferruh

Acked-by on v1 2/2
#2 lore raw
In reply to Dheemanth Mallikarjun

-----Original Message-----
From: Dheemanth Mallikarjun <[email protected]>
Date: Monday, January 4, 2021 at 11:43 AM
To: "[email protected]" <[email protected]>
Cc: Yong Wang <[email protected]>
Subject: [PATCH v1 2/2] net/vmxnet3: Provided API to reset vmxnet device

The vmxnet3 driver didn't have the dev_reset function pointer set. Hence, provided the necessary function pointer so that DPDK developers can use the rte_eth_dev_reset API to reset the vmxnet3 device data.

---

     drivers/net/vmxnet3/vmxnet3_ethdev.c | 14 ++++++++++++++
     1 file changed, 14 insertions(+)
    diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c
    index 23a2ebbef..814ccfa79 100644
    --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
    +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
    @@ -67,6 +67,7 @@ static int vmxnet3_dev_configure(struct rte_eth_dev *dev);
     static int vmxnet3_dev_start(struct rte_eth_dev *dev);
     static int vmxnet3_dev_stop(struct rte_eth_dev *dev);
     static int vmxnet3_dev_close(struct rte_eth_dev *dev);
    +static int vmxnet3_dev_reset(struct rte_eth_dev *dev);
     static void vmxnet3_dev_set_rxmode(struct vmxnet3_hw *hw, uint32_t feature, int set);
     static int vmxnet3_dev_promiscuous_enable(struct rte_eth_dev *dev);
     static int vmxnet3_dev_promiscuous_disable(struct rte_eth_dev *dev);
    @@ -112,6 +113,7 @@ static const struct eth_dev_ops vmxnet3_eth_dev_ops = {
     	.dev_start            = vmxnet3_dev_start,
     	.dev_stop             = vmxnet3_dev_stop,
     	.dev_close            = vmxnet3_dev_close,
    +	.dev_reset            = vmxnet3_dev_reset,
     	.promiscuous_enable   = vmxnet3_dev_promiscuous_enable,
     	.promiscuous_disable  = vmxnet3_dev_promiscuous_disable,
     	.allmulticast_enable  = vmxnet3_dev_allmulticast_enable,
    @@ -913,6 +915,18 @@ vmxnet3_dev_close(struct rte_eth_dev *dev)
     	return ret;
     }

    +static int
    +vmxnet3_dev_reset(struct rte_eth_dev *dev)
    +{
    +	int ret;
    +
    +	ret = eth_vmxnet3_dev_uninit(dev);
    +	if (ret)
    +		return ret;
    +	ret = eth_vmxnet3_dev_init(dev);
    +	return ret;
    +}
    +
     static void
     vmxnet3_hw_tx_stats_get(struct vmxnet3_hw *hw, unsigned int q,
     			struct UPT1_TxStats *res)
    -- 
    2.17.1
Applied
#3 lore raw
Quoted 12 lines · Yong Wang

-----Original Message-----
From: Dheemanth Mallikarjun <[email protected]>
Date: Monday, January 4, 2021 at 11:43 AM
To: "[email protected]" <[email protected]>
Cc: Yong Wang <[email protected]>
Subject: [PATCH v1 2/2] net/vmxnet3: Provided API to reset vmxnet device

The vmxnet3 driver didn't have the dev_reset function pointer set. Hence, provided the necessary function pointer so that DPDK developers can use the rte_eth_dev_reset API to reset the vmxnet3 device data.

Quoted 5 lines

---

Applied to dpdk-next-net/main, thanks.