drm/amdgpu: Fix issue no bad_pages after umc ue injection
Subsystems (2)
PATCH 1/1 drm/amdgpu: Fix issue no bad_pages after umc ue injection
old code wrongly used the bad page status as the function return value, which cause amdgpu_ras_badpages_read always return failed.
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +4 -4
@@ -1518,7 +1518,7 @@ static int amdgpu_ras_badpages_read(struct amdgpu_device *adev,struct amdgpu_ras *con =amdgpu_ras_get_context (adev);struct ras_err_handler_data *data;int i =0 ; -int ret =0 ; +int ret =0 , status;if (!con || !con->eh_data || !bps || !count)return -EINVAL ;
@@ -1543,12 +1543,12 @@ static int amdgpu_ras_badpages_read(struct amdgpu_device *adev, .size = AMDGPU_GPU_PAGE_SIZE, .flags = AMDGPU_RAS_RETIRE_PAGE_RESERVED, }; - ret =amdgpu_vram_mgr_query_page_status ( + status =amdgpu_vram_mgr_query_page_status (ttm_manager_type (&adev->mman.bdev,TTM_PL_VRAM ), data->bps[i].retired_page); -if (ret == -EBUSY ) +if (status == -EBUSY ) (*bps)[i].flags =AMDGPU_RAS_RETIRE_PAGE_PENDING ; -else if (ret == -ENOENT ) +else if (status == -ENOENT ) (*bps)[i].flags =AMDGPU_RAS_RETIRE_PAGE_FAULT ; }
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[AMD Public Use]
Modifying subject to "fix no bad page issue after umc ue injection" is better.
With above fixed, the patch is:
Regards,
Guchun
-----Original Message-----
From: Dennis Li <[email protected]>
Sent: Tuesday, January 5, 2021 8:57 AM
To: [email protected]; Chen, Guchun <[email protected]>; Zhang, Hawking <[email protected]>; Koenig, Christian <[email protected]>
Cc: Li, Dennis <[email protected]>
Subject: [PATCH] drm/amdgpu: Fix issue no bad_pages after umc ue injection
old code wrongly used the bad page status as the function return value, which cause amdgpu_ras_badpages_read always return failed.
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +4 -4
@@ -1518,7 +1518,7 @@ static int amdgpu_ras_badpages_read(struct amdgpu_device *adev,struct amdgpu_ras *con =amdgpu_ras_get_context (adev);struct ras_err_handler_data *data;int i =0 ; -int ret =0 ; +int ret =0 , status;if (!con || !con->eh_data || !bps || !count)return -EINVAL ;
@@ -1543,12 +1543,12 @@ static int amdgpu_ras_badpages_read(struct amdgpu_device *adev, .size = AMDGPU_GPU_PAGE_SIZE, .flags = AMDGPU_RAS_RETIRE_PAGE_RESERVED, }; - ret =amdgpu_vram_mgr_query_page_status ( + status =amdgpu_vram_mgr_query_page_status (ttm_manager_type (&adev->mman.bdev,TTM_PL_VRAM ), data->bps[i].retired_page); -if (ret == -EBUSY ) +if (status == -EBUSY ) (*bps)[i].flags =AMDGPU_RAS_RETIRE_PAGE_PENDING ; -else if (ret == -ENOENT ) +else if (status == -ENOENT ) (*bps)[i].flags =AMDGPU_RAS_RETIRE_PAGE_FAULT ; }
--
2.17.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx