Skip to contentSkip to conversation

docs: net: fix documentation on .ndo_get_stats

PATCH Applied Jakub Kicinski 3 participants 3 messages Jan 5, 2021 – Jan 6, 2021

Subsystems (3)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH v2 1/1 docs: net: fix documentation on .ndo_get_stats

Fix calling context.

---
 Documentation/networking/netdevices.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/networking/netdevices.rst +2 -2
index 5a85fcc80c76..e65665c5ab50 100644
@@ -64,8 +64,8 @@ struct net_device synchronization rules
 	Context: process
 
 ndo_get_stats:
-	Synchronization: dev_base_lock rwlock.
-	Context: nominally process, but don't sleep inside an rwlock
+	Synchronization: rtnl_lock() semaphore, dev_base_lock rwlock, or RCU.
+	Context: atomic (can't sleep under rwlock or RCU)
 
 ndo_start_xmit:
 	Synchronization: __netif_tx_lock spinlock.
Signature · 1 line
2.26.2
Reviewed-by on v2 1/1
#1 lore raw
Quoted 25 lines · Jakub Kicinski

Fix calling context.

---
 Documentation/networking/netdevices.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/networking/netdevices.rst +2 -2
index 5a85fcc80c76..e65665c5ab50 100644
@@ -64,8 +64,8 @@ struct net_device synchronization rules
 	Context: process
 
 ndo_get_stats:
-	Synchronization: dev_base_lock rwlock.
-	Context: nominally process, but don't sleep inside an rwlock
+	Synchronization: rtnl_lock() semaphore, dev_base_lock rwlock, or RCU.
+	Context: atomic (can't sleep under rwlock or RCU)
 
 ndo_start_xmit:
 	Synchronization: __netif_tx_lock spinlock.
Signature · 1 line
2.26.2