arm64: dts: freescale: use fixed index mmcN for NXP layerscape reference boards
Subsystems (2)
PATCH v2 1/1 arm64: dts: freescale: use fixed index mmcN for NXP layerscape reference boards
The eSDHC driver has converted to use asynchronous probe. Let's use fixed index mmcN for eSDHC controllers, so that we can ignore the effect on usage, and avoid problem on previous use cases with fixed index mmcblkN.
---
Changes for v2:
- Dropped changes for ls1012afrwy.
--- arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts | 5 +++++ arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts | 5 +++++ arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts | 2 ++ arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 ++ arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts | 2 ++ 5 files changed, 16 insertions(+)
arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts +5 -0
@@ -13,6 +13,11 @@ model = "LS1012A QDS Board"; compatible = "fsl,ls1012a-qds", "fsl,ls1012a"; + aliases { + mmc0 = &esdhc0; + mmc1 = &esdhc1; + }; + sys_mclk: clock-mclk { compatible = "fixed-clock"; #clock-cells = <0>;
arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts +5 -0
@@ -12,6 +12,11 @@ / { model = "LS1012A RDB Board"; compatible = "fsl,ls1012a-rdb", "fsl,ls1012a"; + + aliases { + mmc0 = &esdhc0; + mmc1 = &esdhc1; + }; }; &duart0 {
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts +2 -0
@@ -15,6 +15,8 @@ aliases { crypto = &crypto; serial0 = &uart0; + mmc0 = &esdhc0; + mmc1 = &esdhc1; }; chosen {
arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts +2 -0
@@ -15,6 +15,8 @@ aliases { crypto = &crypto; serial0 = &uart0; + mmc0 = &esdhc0; + mmc1 = &esdhc1; }; chosen {
arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts +2 -0
@@ -15,6 +15,8 @@ aliases { crypto = &crypto; serial0 = &uart0; + mmc0 = &esdhc0; + mmc1 = &esdhc1; }; chosen {
Signature · 1 line
2.7.4
Quoted 54 lines · Yangbo Lu
The eSDHC driver has converted to use asynchronous probe. Let's use fixed index mmcN for eSDHC controllers, so that we can ignore the effect on usage, and avoid problem on previous use cases with fixed index mmcblkN.
Signed-off-by Yangbo Lu <[email protected]>---
Changes for v2:
- Dropped changes for ls1012afrwy.--- arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts | 5 +++++ arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts | 5 +++++ arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts | 2 ++ arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 ++ arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts | 2 ++ 5 files changed, 16 insertions(+)arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts +5
-0@@ -13,6 +13,11 @@ model = "LS1012A QDS Board"; compatible = "fsl,ls1012a-qds", "fsl,ls1012a"; + aliases { + mmc0 = &esdhc0; + mmc1 = &esdhc1; + }; + sys_mclk: clock-mclk { compatible = "fixed-clock"; #clock-cells = <0>;arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts +5
-0@@ -12,6 +12,11 @@ / { model = "LS1012A RDB Board"; compatible = "fsl,ls1012a-rdb", "fsl,ls1012a"; + + aliases { + mmc0 = &esdhc0; + mmc1 = &esdhc1; + }; }; &duart0 {arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts +0
-0
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts line 19
Quoted 5 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts +2
-0@@ -15,6 +15,8 @@ aliases { crypto = &crypto; serial0 = &uart0; + mmc0 = &esdhc0; + mmc1 = &esdhc1;
Sorry I did not catch this in v1 review, but the aliases list should be alphabetically sorted.
Shawn
Quoted 32 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts +0
-0}; chosen {arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts +2
-0@@ -15,6 +15,8 @@ aliases { crypto = &crypto; serial0 = &uart0; + mmc0 = &esdhc0; + mmc1 = &esdhc1; }; chosen {arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts +2
-0@@ -15,6 +15,8 @@ aliases { crypto = &crypto; serial0 = &uart0; + mmc0 = &esdhc0; + mmc1 = &esdhc1; }; chosen {Signature · 1 line
2.7.4
Hi Shawn,
Quoted 64 lines
-----Original Message-----
From: Shawn Guo <[email protected]>
Sent: Tuesday, January 5, 2021 11:20 AM
To: Y.b. Lu <[email protected]>
Cc: [email protected]; [email protected]; Leo Li <[email protected]>; Vladimir Oltean <[email protected]>; Rob Herring <[email protected]>; Michael Walle <[email protected]>
Subject: Re: [v2] arm64: dts: freescale: use fixed index mmcN for NXP layerscape reference boardsQuoted 17 lines · Yangbo Lu
The eSDHC driver has converted to use asynchronous probe. Let's use fixed index mmcN for eSDHC controllers, so that we can ignore the effect on usage, and avoid problem on previous use cases with fixed index mmcblkN.
Signed-off-by Yangbo Lu <[email protected]>---
Changes for v2:
- Dropped changes for ls1012afrwy.--- arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts | 5 +++++ arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts | 5 +++++ arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts | 2 ++ arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 2 ++ arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts | 2 ++ 5 files changed, 16 insertions(+)Review
Quoted 1 line
(quoted diff) +0
-0
b/arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dtsReview
Quoted 16 lines
index 449475a..e22c5e7 100644
arch/arm64/boot/dts/freescale/fsl-ls1012a-qds.dts +5
-0@@ -13,6 +13,11 @@ model = "LS1012A QDS Board"; compatible = "fsl,ls1012a-qds", "fsl,ls1012a"; + aliases { + mmc0 = &esdhc0; + mmc1 = &esdhc1; + }; + sys_mclk: clock-mclk { compatible = "fixed-clock"; #clock-cells = <0>;(quoted diff) +0
-0
b/arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dtsReview
Quoted 16 lines
index d45c176..f939d65 100644
arch/arm64/boot/dts/freescale/fsl-ls1012a-rdb.dts +5
-0@@ -12,6 +12,11 @@ / { model = "LS1012A RDB Board"; compatible = "fsl,ls1012a-rdb", "fsl,ls1012a"; + + aliases { + mmc0 = &esdhc0; + mmc1 = &esdhc1; + }; }; &duart0 {(quoted diff) +0
-0
b/arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
Quoted 12 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts line 19
Quoted 9 lines
index 2d1fe6c..4ec1a4c 100644
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts +2
-0@@ -15,6 +15,8 @@ aliases { crypto = &crypto; serial0 = &uart0; + mmc0 = &esdhc0; + mmc1 = &esdhc1;Sorry I did not catch this in v1 review, but the aliases list should be alphabetically sorted.
Sorry for my mistake. Sent v3.
Thanks.
Quoted 37 lines
Shawn
Review
Quoted 4 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts +0
-0}; chosen {(quoted diff) +0
-0
b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dtsReview
Quoted 13 lines
index 7723ad5..bdb3b04 100644
arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts +2
-0@@ -15,6 +15,8 @@ aliases { crypto = &crypto; serial0 = &uart0; + mmc0 = &esdhc0; + mmc1 = &esdhc1; }; chosen {(quoted diff) +0
-0
b/arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dtsQuoted 15 lines
index 9178684..69e99cb 100644
arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts +2
-1@@ -15,6 +15,8 @@ aliases { crypto = &crypto; serial0 = &uart0; + mmc0 = &esdhc0; + mmc1 = &esdhc1; }; chosen { --2.7.4