Skip to contentSkip to conversation

drm/amdgpu/psp: fix psp gfx ctrl cmds

PATCH In review Victor Zhao 2 participants 3 messages Jan 5, 2021 – Jan 7, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/amdgpu/psp: fix psp gfx ctrl cmds

psp GFX_CTRL_CMD_ID_CONSUME_CMD different for windows and linux, according to psp, linux cmds are not correct.

v2: only correct GFX_CTRL_CMD_ID_CONSUME_CMD.

---
 drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h +1 -1
index d65a5339d354..3ba7bdfde65d 100644
@@ -47,7 +47,7 @@ enum psp_gfx_crtl_cmd_id
     GFX_CTRL_CMD_ID_DISABLE_INT     = 0x00060000,   /* disable PSP-to-Gfx interrupt */
     GFX_CTRL_CMD_ID_MODE1_RST       = 0x00070000,   /* trigger the Mode 1 reset */
     GFX_CTRL_CMD_ID_GBR_IH_SET      = 0x00080000,   /* set Gbr IH_RB_CNTL registers */
-    GFX_CTRL_CMD_ID_CONSUME_CMD     = 0x000A0000,   /* send interrupt to psp for updating write pointer of vf */
+    GFX_CTRL_CMD_ID_CONSUME_CMD     = 0x00090000,   /* send interrupt to psp for updating write pointer of vf */
     GFX_CTRL_CMD_ID_DESTROY_GPCOM_RING = 0x000C0000, /* destroy GPCOM ring */
 
     GFX_CTRL_CMD_ID_MAX             = 0x000F0000,   /* max command ID */
Signature · 6 lines
2.25.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Reviewed-by Evan Quan on v2 1/1
#1 lore raw

[AMD Official Use Only - Internal Distribution Only]

Quoted 41 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Victor Zhao
Sent: Tuesday, January 5, 2021 3:51 PM
To: [email protected]
Cc: Zhao, Victor <[email protected]>
Subject: [PATCH v2] drm/amdgpu/psp: fix psp gfx ctrl cmds

psp GFX_CTRL_CMD_ID_CONSUME_CMD different for windows and linux, according to psp, linux cmds are not correct.

v2: only correct GFX_CTRL_CMD_ID_CONSUME_CMD.

---
drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h +0 -0
index d65a5339d354..3ba7bdfde65d 100644
@@ -47,7 +47,7 @@ enum psp_gfx_crtl_cmd_id
    GFX_CTRL_CMD_ID_DISABLE_INT     = 0x00060000,   /* disable PSP-to-Gfx

interrupt */

    GFX_CTRL_CMD_ID_MODE1_RST       = 0x00070000,   /* trigger the Mode 1
reset */
    GFX_CTRL_CMD_ID_GBR_IH_SET      = 0x00080000,   /* set Gbr

IH_RB_CNTL registers */
- GFX_CTRL_CMD_ID_CONSUME_CMD = 0x000A0000, /* send interrupt
to psp for updating write pointer of vf */
+ GFX_CTRL_CMD_ID_CONSUME_CMD = 0x00090000, /* send interrupt
to psp for updating write pointer of vf */

    GFX_CTRL_CMD_ID_DESTROY_GPCOM_RING = 0x000C0000, /* destroy

GPCOM ring */

    GFX_CTRL_CMD_ID_MAX             = 0x000F0000,   /* max command ID */

--
2.25.1

Quoted 11 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.f
reedesktop.org%2Fmailman%2Flistinfo%2Famd- gfx&amp;data=04%7C01%7CEmily.Deng%40amd.com%7Cb32008e7e8e1447 797ab08d8b14eb089%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0% 7C637454298972763193%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&amp;s data=2HlggVF4%2B20Ceom5OBfyr0MXYdiLMblwgUbl%2FVEeqII%3D&amp;re served=0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by
#2 lore raw

[AMD Official Use Only - Internal Distribution Only]

Sorry, reply the wrong message.

Quoted 72 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Deng, Emily
Sent: Thursday, January 7, 2021 2:26 PM
To: Zhao, Victor <[email protected]>; [email protected]
Cc: Zhao, Victor <[email protected]>
Subject: RE: [PATCH v2] drm/amdgpu/psp: fix psp gfx ctrl cmds

[AMD Official Use Only - Internal Distribution Only]

[AMD Official Use Only - Internal Distribution Only]

Quoted 26 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Victor Zhao
Sent: Tuesday, January 5, 2021 3:51 PM
To: [email protected]
Cc: Zhao, Victor <[email protected]>
Subject: [PATCH v2] drm/amdgpu/psp: fix psp gfx ctrl cmds

psp GFX_CTRL_CMD_ID_CONSUME_CMD different for windows and linux, according to psp, linux cmds are not correct.

v2: only correct GFX_CTRL_CMD_ID_CONSUME_CMD.

---
drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h +0 -0
index d65a5339d354..3ba7bdfde65d 100644
@@ -47,7 +47,7 @@ enum psp_gfx_crtl_cmd_id
    GFX_CTRL_CMD_ID_DISABLE_INT     = 0x00060000,   /* disable PSP-to-Gfx

interrupt */

Quoted 1 line
    GFX_CTRL_CMD_ID_MODE1_RST       = 0x00070000,   /* trigger the Mode

1

Quoted 8 lines

reset */

    GFX_CTRL_CMD_ID_GBR_IH_SET      = 0x00080000,   /* set Gbr

IH_RB_CNTL registers */
- GFX_CTRL_CMD_ID_CONSUME_CMD = 0x000A0000, /* send interrupt
to psp for updating write pointer of vf */
+ GFX_CTRL_CMD_ID_CONSUME_CMD = 0x00090000, /* send interrupt
to psp for updating write pointer of vf */

    GFX_CTRL_CMD_ID_DESTROY_GPCOM_RING = 0x000C0000, /* destroy

GPCOM

Quoted 6 lines

ring */

    GFX_CTRL_CMD_ID_MAX             = 0x000F0000,   /* max command ID */

--
2.25.1

Quoted 7 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists
.f
reedesktop.org%2Fmailman%2Flistinfo%2Famd- gfx&amp;data=04%7C01%7CEmily.Deng%40amd.com%7Cb32008e7e8e144

7

Quoted 3 lines

797ab08d8b14eb089%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0% 7C637454298972763193%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&amp;

s

Quoted 1 line

data=2HlggVF4%2B20Ceom5OBfyr0MXYdiLMblwgUbl%2FVEeqII%3D&amp;r

e

Quoted 1 line

served=0

Quoted 11 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.f
reedesktop.org%2Fmailman%2Flistinfo%2Famd- gfx&amp;data=04%7C01%7CEmily.Deng%40amd.com%7Cdbe3378304364ec2 161208d8b2d51127%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7 C637455975520611398%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sda ta=lmtZ%2BZjKZEq73CsfCX%2FxEcM7rzWB7%2FuKDzuJ7j3Nx8k%3D&amp;res erved=0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx