Skip to contentSkip to conversation

thunderbolt: Drop duplicated 0x prefix from format string

PATCH In review Mika Westerberg 2 participants 3 messages Jan 5, 2021 – Jan 7, 2021

Subsystems (2)
USB Thunderbolt driver
lore
Share & tools
lore

Mika Westerberg

author
#0 lore raw

PATCH 1/1 thunderbolt: Drop duplicated 0x prefix from format string

The tb_dbg() call is using %#x that already adds the 0x prefix so don't duplicate it.

Fixes 9039387e166e ("thunderbolt: Add USB4 router operation proxy for firmware connection manager")
Signed-off-by Mika Westerberg <[email protected]>
---
 drivers/thunderbolt/icm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thunderbolt/icm.c +1 -1
index 8b7f941a9bb7..b8c4159bc32d 100644
@@ -2316,7 +2316,7 @@ static int icm_usb4_switch_nvm_authenticate_status(struct tb_switch *sw,
 
 	if (auth && auth->reply.route_hi == sw->config.route_hi &&
 	    auth->reply.route_lo == sw->config.route_lo) {
-		tb_dbg(tb, "NVM_AUTH found for %llx flags 0x%#x status %#x\n",
+		tb_dbg(tb, "NVM_AUTH found for %llx flags %#x status %#x\n",
 		       tb_route(sw), auth->reply.hdr.flags, auth->reply.status);
 		if (auth->reply.hdr.flags & ICM_FLAGS_ERROR)
 			ret = -EIO;
Signature · 1 line
2.29.2
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 24 lines · Mika Westerberg

The tb_dbg() call is using %#x that already adds the 0x prefix so don't duplicate it.

Fixes 9039387e166e ("thunderbolt: Add USB4 router operation proxy for firmware connection manager")
Signed-off-by Mika Westerberg <[email protected]>
---
 drivers/thunderbolt/icm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thunderbolt/icm.c +1 -2
index 8b7f941a9bb7..b8c4159bc32d 100644
@@ -2316,7 +2316,7 @@ static int icm_usb4_switch_nvm_authenticate_status(struct tb_switch *sw,
 
        if (auth && auth->reply.route_hi == sw->config.route_hi &&
            auth->reply.route_lo == sw->config.route_lo) {
-               tb_dbg(tb, "NVM_AUTH found for %llx flags 0x%#x status %#x\n",
+               tb_dbg(tb, "NVM_AUTH found for %llx flags %#x status %#x\n",
                       tb_route(sw), auth->reply.hdr.flags, auth->reply.status);
                if (auth->reply.hdr.flags & ICM_FLAGS_ERROR)
                        ret = -EIO;
--
Quoted 2 lines

2.29.2

Reviewed-by Yehezkel Bernat <[email protected]>
author Applied
#2 lore raw
Quoted 18 lines · Yehezkel Bernat
Quoted 16 lines · Mika Westerberg

The tb_dbg() call is using %#x that already adds the 0x prefix so don't duplicate it.

Fixes 9039387e166e ("thunderbolt: Add USB4 router operation proxy for firmware connection manager")
Signed-off-by Mika Westerberg <[email protected]>
---
 drivers/thunderbolt/icm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thunderbolt/icm.c +0 -0
index 8b7f941a9bb7..b8c4159bc32d 100644
@@ -2316,7 +2316,7 @@ static int icm_usb4_switch_nvm_authenticate_status(struct tb_switch *sw,
Quoted 12 lines
Quoted 10 lines
drivers/thunderbolt/icm.c +1 -2
        if (auth && auth->reply.route_hi == sw->config.route_hi &&
            auth->reply.route_lo == sw->config.route_lo) {
-               tb_dbg(tb, "NVM_AUTH found for %llx flags 0x%#x status %#x\n",
+               tb_dbg(tb, "NVM_AUTH found for %llx flags %#x status %#x\n",
                       tb_route(sw), auth->reply.hdr.flags, auth->reply.status);
                if (auth->reply.hdr.flags & ICM_FLAGS_ERROR)
                        ret = -EIO;
--

2.29.2

Reviewed-by Yehezkel Bernat <[email protected]>

Thanks! Applied now.