i2c: remove h from printk format specifier
Subsystems (2)
PATCH 1/1 i2c: remove h from printk format specifier
From: Tom Rix <[email protected]>
See Documentation/core-api/printk-formats.rst.
h should no longer be used in the format specifier for printk.
Signed-off-by Tom Rix <[email protected]>
--- drivers/i2c/i2c-smbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/i2c-smbus.c +1 -1
@@ -396,7 +396,7 @@ void i2c_register_spd(struct i2c_adapter *adap)if (!IS_ERR (i2c_new_scanned_device (adap, &info, addr_list,NULL ))) {dev_info (&adap->dev, -"Successfully instantiated SPD at 0x%hx\n" , +"Successfully instantiated SPD at 0x%x\n" , addr_list[0 ]); dimm_count--; }
Signature · 1 line
2.27.0
Quoted 6 lines · On Tue, Dec 15, 2020 at 10:33:27AM -0800, [email protected] wrote:
From: Tom Rix <[email protected]>
See
Documentation/core-api/printk-formats.rst.
h should no longer be used in the format specifier for printk.Signed-off-by Tom Rix <[email protected]>
Adding Jean to CC. Jean, I'd think %02x would be better, what do you think?
Quoted 20 lines
--- drivers/i2c/i2c-smbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/i2c/i2c-smbus.c +1
-1@@ -396,7 +396,7 @@ void i2c_register_spd(struct i2c_adapter *adap)if (!IS_ERR (i2c_new_scanned_device (adap, &info, addr_list,NULL ))) {dev_info (&adap->dev, -"Successfully instantiated SPD at 0x%hx\n" , +"Successfully instantiated SPD at 0x%x\n" , addr_list[0 ]); dimm_count--; }Signature · 1 line
2.27.0
Jean Delvare
Reviewed-byHi Tom, Wolfram,
Quoted 10 lines · Wolfram Sang
Quoted 6 lines · On Tue, Dec 15, 2020 at 10:33:27AM -0800, [email protected] wrote:
From: Tom Rix <[email protected]>
See
Documentation/core-api/printk-formats.rst.
h should no longer be used in the format specifier for printk.Signed-off-by Tom Rix <[email protected]>Adding Jean to CC. Jean, I'd think %02x would be better, what do you think?
Agreed, 0x%02x would be better.
If this is done then you can add:
Reviewed-by Jean Delvare <[email protected]>
Quoted 17 lines
Quoted 17 lines
--- drivers/i2c/i2c-smbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/i2c/i2c-smbus.c +1
-1@@ -396,7 +396,7 @@ void i2c_register_spd(struct i2c_adapter *adap)if (!IS_ERR (i2c_new_scanned_device (adap, &info, addr_list,NULL ))) {dev_info (&adap->dev, -"Successfully instantiated SPD at 0x%hx\n" , +"Successfully instantiated SPD at 0x%x\n" , addr_list[0 ]); dimm_count--; }
Signature · 2 lines
Jean Delvare SUSE L3 Support