cyprus: Link the new cyprus firmware to the old brcm files
PATCH 2/2 cyprus: Link the new cyprus firmware to the old brcm files
By linking the new firmware to the old file it allows exisiting kernels to make use of the new firmware and make use of the newer firmware with all the associated fixes.
--- WHENCE | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)
WHENCE +21 -0
@@ -2651,26 +2651,47 @@ Licence: Redistributable. See LICENCE.broadcom_bcm43xx for details. File: brcm/brcmfmac4373.bin File: cypress/cyfmac43012-sdio.bin +Link: cypress/cyfmac43012-sdio.bin -> ../brcm/brcmfmac43012-sdio.bin File: cypress/cyfmac43012-sdio.clm_blob +Link: cypress/cyfmac43012-sdio.clm_blob -> ../brcm/brcmfmac43012-sdio.clm_blob File: cypress/cyfmac43340-sdio.bin +Link: cypress/cyfmac43340-sdio.bin -> ../brcm/brcmfmac43340-sdio.bin File: cypress/cyfmac43362-sdio.bin +Link: cypress/cyfmac43362-sdio.bin -> ../brcm/brcmfmac43362-sdio.bin File: cypress/cyfmac4339-sdio.bin +Link: cypress/cyfmac4339-sdio.bin -> ../brcm/brcmfmac4339-sdio.bin File: cypress/cyfmac43430-sdio.bin +Link: cypress/cyfmac43430-sdio.bin -> ../brcm/brcmfmac43430-sdio.bin File: cypress/cyfmac43430-sdio.clm_blob +Link: cypress/cyfmac43430-sdio.clm_blob -> ../brcm/brcmfmac43430-sdio.clm_blob File: cypress/cyfmac43455-sdio.bin +Link: cypress/cyfmac43455-sdio.bin -> ../brcm/brcmfmac43455-sdio.bin File: cypress/cyfmac43455-sdio.clm_blob +Link: cypress/cyfmac43455-sdio.clm_blob -> ../brcm/brcmfmac43455-sdio.clm_blob File: cypress/cyfmac4354-sdio.bin +Link: cypress/cyfmac4354-sdio.bin -> ../brcm/brcmfmac4354-sdio.bin File: cypress/cyfmac4354-sdio.clm_blob +Link: cypress/cyfmac4354-sdio.clm_blob -> ../brcm/brcmfmac4354-sdio.clm_blob File: cypress/cyfmac4356-pcie.bin +Link: cypress/cyfmac4356-pcie.bin -> ../brcm/brcmfmac4356-pcie.bin File: cypress/cyfmac4356-pcie.clm_blob +Link: cypress/cyfmac4356-pcie.clm_blob -> ../brcm/brcmfmac4356-pcie.clm_blob File: cypress/cyfmac4356-sdio.bin +Link: cypress/cyfmac4356-sdio.bin -> ../brcm/brcmfmac4356-sdio.bin File: cypress/cyfmac4356-sdio.clm_blob +Link: cypress/cyfmac4356-sdio.clm_blob -> ../brcm/brcmfmac4356-sdio.clm_blob File: cypress/cyfmac43570-pcie.bin +Link: cypress/cyfmac43570-pcie.bin -> ../brcm/brcmfmac43570-pcie.bin File: cypress/cyfmac43570-pcie.clm_blob +Link: cypress/cyfmac43570-pcie.clm_blob -> ../brcm/brcmfmac43570-pcie.clm_blob File: cypress/cyfmac4373-sdio.bin +Link: cypress/cyfmac4373-sdio.bin -> ../brcm/brcmfmac4373-sdio.bin File: cypress/cyfmac4373-sdio.clm_blob +Link: cypress/cyfmac4373-sdio.clm_blob -> ../brcm/brcmfmac4373-sdio.clm_blob File: cypress/cyfmac54591-pcie.bin +Link: cypress/cyfmac54591-pcie.bin -> ../brcm/brcmfmac54591-pcie.bin File: cypress/cyfmac54591-pcie.clm_blob +Link: cypress/cyfmac54591-pcie.clm_blob -> ../brcm/brcmfmac54591-pcie.clm_blob Licence: Redistributable. See LICENCE.cypress for details.
Signature · 1 line
2.29.2
PATCH 1/2 brcm: remove old brcm firmwares that have newer cyprus variants
Cyprus pushed newer versions of the following firmwares:
- 43012
- 43340
- 43362
- 4339
- 43430
- 43455
- 4354
- 4356
- 43570
- 4373
- 54591
Remove these old ones as they're likely vulnerable to at least the KrØØk vulnerability (CVE-2019-15126).
--- WHENCE | 10 ---------- brcm/brcmfmac43340-sdio.bin | Bin 400864 -> 0 bytes brcm/brcmfmac43362-sdio.bin | Bin 202107 -> 0 bytes brcm/brcmfmac4339-sdio.bin | Bin 562183 -> 0 bytes brcm/brcmfmac43430-sdio.bin | Bin 388739 -> 0 bytes brcm/brcmfmac43455-sdio.bin | Bin 488193 -> 0 bytes brcm/brcmfmac4354-sdio.bin | Bin 605388 -> 0 bytes brcm/brcmfmac4356-pcie.bin | Bin 648770 -> 0 bytes brcm/brcmfmac4356-sdio.bin | Bin 526383 -> 0 bytes brcm/brcmfmac43570-pcie.bin | Bin 550333 -> 0 bytes brcm/brcmfmac4373-sdio.bin | Bin 457994 -> 0 bytes 11 files changed, 10 deletions(-) delete mode 100644 brcm/brcmfmac43340-sdio.bin delete mode 100644 brcm/brcmfmac43362-sdio.bin delete mode 100644 brcm/brcmfmac4339-sdio.bin delete mode 100644 brcm/brcmfmac43430-sdio.bin delete mode 100644 brcm/brcmfmac43455-sdio.bin delete mode 100644 brcm/brcmfmac4354-sdio.bin delete mode 100644 brcm/brcmfmac4356-pcie.bin delete mode 100644 brcm/brcmfmac4356-sdio.bin delete mode 100644 brcm/brcmfmac43570-pcie.bin delete mode 100644 brcm/brcmfmac4373-sdio.bin
WHENCE +0 -10
@@ -2630,7 +2630,6 @@ File: brcm/brcmfmac4329-sdio.bin File: brcm/brcmfmac4330-sdio.bin File: brcm/brcmfmac4334-sdio.bin File: brcm/brcmfmac4335-sdio.bin -File: brcm/brcmfmac4339-sdio.bin File: brcm/brcmfmac43241b0-sdio.bin File: brcm/brcmfmac43241b4-sdio.bin File: brcm/brcmfmac43241b5-sdio.bin
@@ -2638,12 +2637,9 @@ File: brcm/brcmfmac43242a.bin File: brcm/brcmfmac43143.bin File: brcm/brcmfmac43143-sdio.bin File: brcm/brcmfmac43430a0-sdio.bin -File: brcm/brcmfmac43455-sdio.bin File: brcm/brcmfmac4350c2-pcie.bin File: brcm/brcmfmac4350-pcie.bin -File: brcm/brcmfmac4356-sdio.bin File: brcm/brcmfmac43569.bin -File: brcm/brcmfmac43570-pcie.bin File: brcm/brcmfmac4358-pcie.bin File: brcm/brcmfmac43602-pcie.bin File: brcm/brcmfmac43602-pcie.ap.bin
@@ -2653,12 +2649,6 @@ File: brcm/brcmfmac4371-pcie.bin Licence: Redistributable. See LICENCE.broadcom_bcm43xx for details. -File: brcm/brcmfmac43340-sdio.bin -File: brcm/brcmfmac43362-sdio.bin -File: brcm/brcmfmac43430-sdio.bin -File: brcm/brcmfmac4354-sdio.bin -File: brcm/brcmfmac4356-pcie.bin -File: brcm/brcmfmac4373-sdio.bin File: brcm/brcmfmac4373.bin File: cypress/cyfmac43012-sdio.bin File: cypress/cyfmac43012-sdio.clm_blob
brcm/brcmfmac43340-sdio.bin deleted binary +0 -0
brcm/brcmfmac43362-sdio.bin deleted binary +0 -0
brcm/brcmfmac4339-sdio.bin deleted binary +0 -0
brcm/brcmfmac43430-sdio.bin deleted binary +0 -0
brcm/brcmfmac43455-sdio.bin deleted binary +0 -0
brcm/brcmfmac4354-sdio.bin deleted binary +0 -0
brcm/brcmfmac4356-pcie.bin deleted binary +0 -0
brcm/brcmfmac4356-sdio.bin deleted binary +0 -0
brcm/brcmfmac43570-pcie.bin deleted binary +0 -0
brcm/brcmfmac4373-sdio.bin deleted binary +0 -0
Signature · 1 line
2.29.2
Peter Robinson 於 2021/1/6 上午 12:04 寫道:
Quoted 7 lines
By linking the new firmware to the old file it allows exisiting kernels to make use of the new firmware and make use of the newer firmware with all the associated fixes.
Signed-off-by Peter Robinson <[email protected]>Cc Hans de Goede <[email protected]>Cc Chi-Hsien Lin <[email protected]>
(+Arend and lists)
Hi Peter,
The folder name is Cypress instead of cyprus. Could you please fix this in v2 commit messages?
Regards,
Chi-hsien Lin
Quoted 56 lines
--- WHENCE | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)WHENCE +21
-0@@ -2651,26 +2651,47 @@ Licence: Redistributable. See LICENCE.broadcom_bcm43xx for details. File: brcm/brcmfmac4373.bin File: cypress/cyfmac43012-sdio.bin +Link: cypress/cyfmac43012-sdio.bin -> ../brcm/brcmfmac43012-sdio.bin File: cypress/cyfmac43012-sdio.clm_blob +Link: cypress/cyfmac43012-sdio.clm_blob -> ../brcm/brcmfmac43012-sdio.clm_blob File: cypress/cyfmac43340-sdio.bin +Link: cypress/cyfmac43340-sdio.bin -> ../brcm/brcmfmac43340-sdio.bin File: cypress/cyfmac43362-sdio.bin +Link: cypress/cyfmac43362-sdio.bin -> ../brcm/brcmfmac43362-sdio.bin File: cypress/cyfmac4339-sdio.bin +Link: cypress/cyfmac4339-sdio.bin -> ../brcm/brcmfmac4339-sdio.bin File: cypress/cyfmac43430-sdio.bin +Link: cypress/cyfmac43430-sdio.bin -> ../brcm/brcmfmac43430-sdio.bin File: cypress/cyfmac43430-sdio.clm_blob +Link: cypress/cyfmac43430-sdio.clm_blob -> ../brcm/brcmfmac43430-sdio.clm_blob File: cypress/cyfmac43455-sdio.bin +Link: cypress/cyfmac43455-sdio.bin -> ../brcm/brcmfmac43455-sdio.bin File: cypress/cyfmac43455-sdio.clm_blob +Link: cypress/cyfmac43455-sdio.clm_blob -> ../brcm/brcmfmac43455-sdio.clm_blob File: cypress/cyfmac4354-sdio.bin +Link: cypress/cyfmac4354-sdio.bin -> ../brcm/brcmfmac4354-sdio.bin File: cypress/cyfmac4354-sdio.clm_blob +Link: cypress/cyfmac4354-sdio.clm_blob -> ../brcm/brcmfmac4354-sdio.clm_blob File: cypress/cyfmac4356-pcie.bin +Link: cypress/cyfmac4356-pcie.bin -> ../brcm/brcmfmac4356-pcie.bin File: cypress/cyfmac4356-pcie.clm_blob +Link: cypress/cyfmac4356-pcie.clm_blob -> ../brcm/brcmfmac4356-pcie.clm_blob File: cypress/cyfmac4356-sdio.bin +Link: cypress/cyfmac4356-sdio.bin -> ../brcm/brcmfmac4356-sdio.bin File: cypress/cyfmac4356-sdio.clm_blob +Link: cypress/cyfmac4356-sdio.clm_blob -> ../brcm/brcmfmac4356-sdio.clm_blob File: cypress/cyfmac43570-pcie.bin +Link: cypress/cyfmac43570-pcie.bin -> ../brcm/brcmfmac43570-pcie.bin File: cypress/cyfmac43570-pcie.clm_blob +Link: cypress/cyfmac43570-pcie.clm_blob -> ../brcm/brcmfmac43570-pcie.clm_blob File: cypress/cyfmac4373-sdio.bin +Link: cypress/cyfmac4373-sdio.bin -> ../brcm/brcmfmac4373-sdio.bin File: cypress/cyfmac4373-sdio.clm_blob +Link: cypress/cyfmac4373-sdio.clm_blob -> ../brcm/brcmfmac4373-sdio.clm_blob File: cypress/cyfmac54591-pcie.bin +Link: cypress/cyfmac54591-pcie.bin -> ../brcm/brcmfmac54591-pcie.bin File: cypress/cyfmac54591-pcie.clm_blob +Link: cypress/cyfmac54591-pcie.clm_blob -> ../brcm/brcmfmac54591-pcie.clm_blob Licence: Redistributable. See LICENCE.cypress for details.
Quoted 11 lines · Chi-Hsien Lin
Peter Robinson 於 2021/1/6 上午 12:04 寫道:
Quoted 7 lines
By linking the new firmware to the old file it allows exisiting kernels to make use of the new firmware and make use of the newer firmware with all the associated fixes.
Signed-off-by Peter Robinson <[email protected]>Cc Hans de Goede <[email protected]>Cc Chi-Hsien Lin <[email protected]>
Quoted 6 lines
(+Arend and lists)
Hi Peter,
The folder name is Cypress instead of cyprus. Could you please fix this in v2 commit messages?
Yes, of course. I'll wait a little for some other feedback.
Peter
Quoted 62 lines
Regards,
Chi-hsien Lin
Quoted 56 lines
--- WHENCE | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)WHENCE +21
-0@@ -2651,26 +2651,47 @@ Licence: Redistributable. See LICENCE.broadcom_bcm43xx for details. File: brcm/brcmfmac4373.bin File: cypress/cyfmac43012-sdio.bin +Link: cypress/cyfmac43012-sdio.bin -> ../brcm/brcmfmac43012-sdio.bin File: cypress/cyfmac43012-sdio.clm_blob +Link: cypress/cyfmac43012-sdio.clm_blob -> ../brcm/brcmfmac43012-sdio.clm_blob File: cypress/cyfmac43340-sdio.bin +Link: cypress/cyfmac43340-sdio.bin -> ../brcm/brcmfmac43340-sdio.bin File: cypress/cyfmac43362-sdio.bin +Link: cypress/cyfmac43362-sdio.bin -> ../brcm/brcmfmac43362-sdio.bin File: cypress/cyfmac4339-sdio.bin +Link: cypress/cyfmac4339-sdio.bin -> ../brcm/brcmfmac4339-sdio.bin File: cypress/cyfmac43430-sdio.bin +Link: cypress/cyfmac43430-sdio.bin -> ../brcm/brcmfmac43430-sdio.bin File: cypress/cyfmac43430-sdio.clm_blob +Link: cypress/cyfmac43430-sdio.clm_blob -> ../brcm/brcmfmac43430-sdio.clm_blob File: cypress/cyfmac43455-sdio.bin +Link: cypress/cyfmac43455-sdio.bin -> ../brcm/brcmfmac43455-sdio.bin File: cypress/cyfmac43455-sdio.clm_blob +Link: cypress/cyfmac43455-sdio.clm_blob -> ../brcm/brcmfmac43455-sdio.clm_blob File: cypress/cyfmac4354-sdio.bin +Link: cypress/cyfmac4354-sdio.bin -> ../brcm/brcmfmac4354-sdio.bin File: cypress/cyfmac4354-sdio.clm_blob +Link: cypress/cyfmac4354-sdio.clm_blob -> ../brcm/brcmfmac4354-sdio.clm_blob File: cypress/cyfmac4356-pcie.bin +Link: cypress/cyfmac4356-pcie.bin -> ../brcm/brcmfmac4356-pcie.bin File: cypress/cyfmac4356-pcie.clm_blob +Link: cypress/cyfmac4356-pcie.clm_blob -> ../brcm/brcmfmac4356-pcie.clm_blob File: cypress/cyfmac4356-sdio.bin +Link: cypress/cyfmac4356-sdio.bin -> ../brcm/brcmfmac4356-sdio.bin File: cypress/cyfmac4356-sdio.clm_blob +Link: cypress/cyfmac4356-sdio.clm_blob -> ../brcm/brcmfmac4356-sdio.clm_blob File: cypress/cyfmac43570-pcie.bin +Link: cypress/cyfmac43570-pcie.bin -> ../brcm/brcmfmac43570-pcie.bin File: cypress/cyfmac43570-pcie.clm_blob +Link: cypress/cyfmac43570-pcie.clm_blob -> ../brcm/brcmfmac43570-pcie.clm_blob File: cypress/cyfmac4373-sdio.bin +Link: cypress/cyfmac4373-sdio.bin -> ../brcm/brcmfmac4373-sdio.bin File: cypress/cyfmac4373-sdio.clm_blob +Link: cypress/cyfmac4373-sdio.clm_blob -> ../brcm/brcmfmac4373-sdio.clm_blob File: cypress/cyfmac54591-pcie.bin +Link: cypress/cyfmac54591-pcie.bin -> ../brcm/brcmfmac54591-pcie.bin File: cypress/cyfmac54591-pcie.clm_blob +Link: cypress/cyfmac54591-pcie.clm_blob -> ../brcm/brcmfmac54591-pcie.clm_blob Licence: Redistributable. See LICENCE.cypress for details.
Hans de Goede
Reviewed-byHi,
Quoted 12 lines · Peter Robinson
Quoted 11 lines · Chi-Hsien Lin
Peter Robinson 於 2021/1/6 上午 12:04 寫道:
Quoted 7 lines
By linking the new firmware to the old file it allows exisiting kernels to make use of the new firmware and make use of the newer firmware with all the associated fixes.
Signed-off-by Peter Robinson <[email protected]>Cc Hans de Goede <[email protected]>Cc Chi-Hsien Lin <[email protected]>
Quoted 8 lines
Quoted 6 lines
(+Arend and lists)
Hi Peter,
The folder name is Cypress instead of cyprus. Could you please fix this in v2 commit messages?
Yes, of course. I'll wait a little for some other feedback.
I thought I already send this yesterday, but I think I did the review and then forgot to reply...
The entire series looks good to me, so for v2 you can add my:
To both patches.
Regards,
Hans
Quoted 57 lines
Quoted 56 lines
Quoted 56 lines
--- WHENCE | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)WHENCE +21
-0@@ -2651,26 +2651,47 @@ Licence: Redistributable. See LICENCE.broadcom_bcm43xx for details. File: brcm/brcmfmac4373.bin File: cypress/cyfmac43012-sdio.bin +Link: cypress/cyfmac43012-sdio.bin -> ../brcm/brcmfmac43012-sdio.bin File: cypress/cyfmac43012-sdio.clm_blob +Link: cypress/cyfmac43012-sdio.clm_blob -> ../brcm/brcmfmac43012-sdio.clm_blob File: cypress/cyfmac43340-sdio.bin +Link: cypress/cyfmac43340-sdio.bin -> ../brcm/brcmfmac43340-sdio.bin File: cypress/cyfmac43362-sdio.bin +Link: cypress/cyfmac43362-sdio.bin -> ../brcm/brcmfmac43362-sdio.bin File: cypress/cyfmac4339-sdio.bin +Link: cypress/cyfmac4339-sdio.bin -> ../brcm/brcmfmac4339-sdio.bin File: cypress/cyfmac43430-sdio.bin +Link: cypress/cyfmac43430-sdio.bin -> ../brcm/brcmfmac43430-sdio.bin File: cypress/cyfmac43430-sdio.clm_blob +Link: cypress/cyfmac43430-sdio.clm_blob -> ../brcm/brcmfmac43430-sdio.clm_blob File: cypress/cyfmac43455-sdio.bin +Link: cypress/cyfmac43455-sdio.bin -> ../brcm/brcmfmac43455-sdio.bin File: cypress/cyfmac43455-sdio.clm_blob +Link: cypress/cyfmac43455-sdio.clm_blob -> ../brcm/brcmfmac43455-sdio.clm_blob File: cypress/cyfmac4354-sdio.bin +Link: cypress/cyfmac4354-sdio.bin -> ../brcm/brcmfmac4354-sdio.bin File: cypress/cyfmac4354-sdio.clm_blob +Link: cypress/cyfmac4354-sdio.clm_blob -> ../brcm/brcmfmac4354-sdio.clm_blob File: cypress/cyfmac4356-pcie.bin +Link: cypress/cyfmac4356-pcie.bin -> ../brcm/brcmfmac4356-pcie.bin File: cypress/cyfmac4356-pcie.clm_blob +Link: cypress/cyfmac4356-pcie.clm_blob -> ../brcm/brcmfmac4356-pcie.clm_blob File: cypress/cyfmac4356-sdio.bin +Link: cypress/cyfmac4356-sdio.bin -> ../brcm/brcmfmac4356-sdio.bin File: cypress/cyfmac4356-sdio.clm_blob +Link: cypress/cyfmac4356-sdio.clm_blob -> ../brcm/brcmfmac4356-sdio.clm_blob File: cypress/cyfmac43570-pcie.bin +Link: cypress/cyfmac43570-pcie.bin -> ../brcm/brcmfmac43570-pcie.bin File: cypress/cyfmac43570-pcie.clm_blob +Link: cypress/cyfmac43570-pcie.clm_blob -> ../brcm/brcmfmac43570-pcie.clm_blob File: cypress/cyfmac4373-sdio.bin +Link: cypress/cyfmac4373-sdio.bin -> ../brcm/brcmfmac4373-sdio.bin File: cypress/cyfmac4373-sdio.clm_blob +Link: cypress/cyfmac4373-sdio.clm_blob -> ../brcm/brcmfmac4373-sdio.clm_blob File: cypress/cyfmac54591-pcie.bin +Link: cypress/cyfmac54591-pcie.bin -> ../brcm/brcmfmac54591-pcie.bin File: cypress/cyfmac54591-pcie.clm_blob +Link: cypress/cyfmac54591-pcie.clm_blob -> ../brcm/brcmfmac54591-pcie.clm_blob Licence: Redistributable. See LICENCE.cypress for details.
Quoted 25 lines · Hans de Goede
Hi,
Quoted 12 lines · Peter Robinson
Quoted 11 lines · Chi-Hsien Lin
Peter Robinson 於 2021/1/6 上午 12:04 寫道:
Quoted 7 lines
By linking the new firmware to the old file it allows exisiting kernels to make use of the new firmware and make use of the newer firmware with all the associated fixes.
Signed-off-by Peter Robinson <[email protected]>Cc Hans de Goede <[email protected]>Cc Chi-Hsien Lin <[email protected]>Quoted 8 lines
Quoted 6 lines
(+Arend and lists)
Hi Peter,
The folder name is Cypress instead of cyprus. Could you please fix this in v2 commit messages?
Yes, of course. I'll wait a little for some other feedback.
Quoted 8 lines
I thought I already send this yesterday, but I think I did the review and then forgot to reply...
The entire series looks good to me, so for v2 you can add my:
Reviewed-by Hans de Goede <[email protected]>To both patches.
I'll just edit the commit messages locally when I apply the patches. No need for a full v2 submission unless there are other changes to be made. I'll wait for a bit before committing to allow for any other feedback.
josh
Quoted 58 lines
Quoted 57 lines
Quoted 56 lines
Quoted 56 lines
--- WHENCE | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)WHENCE +21
-0@@ -2651,26 +2651,47 @@ Licence: Redistributable. See LICENCE.broadcom_bcm43xx for details. File: brcm/brcmfmac4373.bin File: cypress/cyfmac43012-sdio.bin +Link: cypress/cyfmac43012-sdio.bin -> ../brcm/brcmfmac43012-sdio.bin File: cypress/cyfmac43012-sdio.clm_blob +Link: cypress/cyfmac43012-sdio.clm_blob -> ../brcm/brcmfmac43012-sdio.clm_blob File: cypress/cyfmac43340-sdio.bin +Link: cypress/cyfmac43340-sdio.bin -> ../brcm/brcmfmac43340-sdio.bin File: cypress/cyfmac43362-sdio.bin +Link: cypress/cyfmac43362-sdio.bin -> ../brcm/brcmfmac43362-sdio.bin File: cypress/cyfmac4339-sdio.bin +Link: cypress/cyfmac4339-sdio.bin -> ../brcm/brcmfmac4339-sdio.bin File: cypress/cyfmac43430-sdio.bin +Link: cypress/cyfmac43430-sdio.bin -> ../brcm/brcmfmac43430-sdio.bin File: cypress/cyfmac43430-sdio.clm_blob +Link: cypress/cyfmac43430-sdio.clm_blob -> ../brcm/brcmfmac43430-sdio.clm_blob File: cypress/cyfmac43455-sdio.bin +Link: cypress/cyfmac43455-sdio.bin -> ../brcm/brcmfmac43455-sdio.bin File: cypress/cyfmac43455-sdio.clm_blob +Link: cypress/cyfmac43455-sdio.clm_blob -> ../brcm/brcmfmac43455-sdio.clm_blob File: cypress/cyfmac4354-sdio.bin +Link: cypress/cyfmac4354-sdio.bin -> ../brcm/brcmfmac4354-sdio.bin File: cypress/cyfmac4354-sdio.clm_blob +Link: cypress/cyfmac4354-sdio.clm_blob -> ../brcm/brcmfmac4354-sdio.clm_blob File: cypress/cyfmac4356-pcie.bin +Link: cypress/cyfmac4356-pcie.bin -> ../brcm/brcmfmac4356-pcie.bin File: cypress/cyfmac4356-pcie.clm_blob +Link: cypress/cyfmac4356-pcie.clm_blob -> ../brcm/brcmfmac4356-pcie.clm_blob File: cypress/cyfmac4356-sdio.bin +Link: cypress/cyfmac4356-sdio.bin -> ../brcm/brcmfmac4356-sdio.bin File: cypress/cyfmac4356-sdio.clm_blob +Link: cypress/cyfmac4356-sdio.clm_blob -> ../brcm/brcmfmac4356-sdio.clm_blob File: cypress/cyfmac43570-pcie.bin +Link: cypress/cyfmac43570-pcie.bin -> ../brcm/brcmfmac43570-pcie.bin File: cypress/cyfmac43570-pcie.clm_blob +Link: cypress/cyfmac43570-pcie.clm_blob -> ../brcm/brcmfmac43570-pcie.clm_blob File: cypress/cyfmac4373-sdio.bin +Link: cypress/cyfmac4373-sdio.bin -> ../brcm/brcmfmac4373-sdio.bin File: cypress/cyfmac4373-sdio.clm_blob +Link: cypress/cyfmac4373-sdio.clm_blob -> ../brcm/brcmfmac4373-sdio.clm_blob File: cypress/cyfmac54591-pcie.bin +Link: cypress/cyfmac54591-pcie.bin -> ../brcm/brcmfmac54591-pcie.bin File: cypress/cyfmac54591-pcie.clm_blob +Link: cypress/cyfmac54591-pcie.clm_blob -> ../brcm/brcmfmac54591-pcie.clm_blob Licence: Redistributable. See LICENCE.cypress for details.
Quoted 32 lines · Josh Boyer
Quoted 30 lines · Hans de Goede
Hi,
Quoted 12 lines · Peter Robinson
Quoted 11 lines · Chi-Hsien Lin
Peter Robinson 於 2021/1/6 上午 12:04 寫道:
Quoted 7 lines
By linking the new firmware to the old file it allows exisiting kernels to make use of the new firmware and make use of the newer firmware with all the associated fixes.
Signed-off-by Peter Robinson <[email protected]>Cc Hans de Goede <[email protected]>Cc Chi-Hsien Lin <[email protected]>Quoted 8 lines
Quoted 6 lines
(+Arend and lists)
Hi Peter,
The folder name is Cypress instead of cyprus. Could you please fix this in v2 commit messages?
Yes, of course. I'll wait a little for some other feedback.
I thought I already send this yesterday, but I think I did the review and then forgot to reply...
The entire series looks good to me, so for v2 you can add my:
Quoted 8 lines
Quoted 3 lines
Reviewed-by Hans de Goede <[email protected]>To both patches.
I'll just edit the commit messages locally when I apply the patches. No need for a full v2 submission unless there are other changes to be made. I'll wait for a bit before committing to allow for any other feedback.
Both applied and pushed out.
josh
Quoted 57 lines
Quoted 57 lines
Quoted 56 lines
Quoted 55 lines
Quoted 55 lines
WHENCE | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)WHENCE +21
-0@@ -2651,26 +2651,47 @@ Licence: Redistributable. See LICENCE.broadcom_bcm43xx for details. File: brcm/brcmfmac4373.bin File: cypress/cyfmac43012-sdio.bin +Link: cypress/cyfmac43012-sdio.bin -> ../brcm/brcmfmac43012-sdio.bin File: cypress/cyfmac43012-sdio.clm_blob +Link: cypress/cyfmac43012-sdio.clm_blob -> ../brcm/brcmfmac43012-sdio.clm_blob File: cypress/cyfmac43340-sdio.bin +Link: cypress/cyfmac43340-sdio.bin -> ../brcm/brcmfmac43340-sdio.bin File: cypress/cyfmac43362-sdio.bin +Link: cypress/cyfmac43362-sdio.bin -> ../brcm/brcmfmac43362-sdio.bin File: cypress/cyfmac4339-sdio.bin +Link: cypress/cyfmac4339-sdio.bin -> ../brcm/brcmfmac4339-sdio.bin File: cypress/cyfmac43430-sdio.bin +Link: cypress/cyfmac43430-sdio.bin -> ../brcm/brcmfmac43430-sdio.bin File: cypress/cyfmac43430-sdio.clm_blob +Link: cypress/cyfmac43430-sdio.clm_blob -> ../brcm/brcmfmac43430-sdio.clm_blob File: cypress/cyfmac43455-sdio.bin +Link: cypress/cyfmac43455-sdio.bin -> ../brcm/brcmfmac43455-sdio.bin File: cypress/cyfmac43455-sdio.clm_blob +Link: cypress/cyfmac43455-sdio.clm_blob -> ../brcm/brcmfmac43455-sdio.clm_blob File: cypress/cyfmac4354-sdio.bin +Link: cypress/cyfmac4354-sdio.bin -> ../brcm/brcmfmac4354-sdio.bin File: cypress/cyfmac4354-sdio.clm_blob +Link: cypress/cyfmac4354-sdio.clm_blob -> ../brcm/brcmfmac4354-sdio.clm_blob File: cypress/cyfmac4356-pcie.bin +Link: cypress/cyfmac4356-pcie.bin -> ../brcm/brcmfmac4356-pcie.bin File: cypress/cyfmac4356-pcie.clm_blob +Link: cypress/cyfmac4356-pcie.clm_blob -> ../brcm/brcmfmac4356-pcie.clm_blob File: cypress/cyfmac4356-sdio.bin +Link: cypress/cyfmac4356-sdio.bin -> ../brcm/brcmfmac4356-sdio.bin File: cypress/cyfmac4356-sdio.clm_blob +Link: cypress/cyfmac4356-sdio.clm_blob -> ../brcm/brcmfmac4356-sdio.clm_blob File: cypress/cyfmac43570-pcie.bin +Link: cypress/cyfmac43570-pcie.bin -> ../brcm/brcmfmac43570-pcie.bin File: cypress/cyfmac43570-pcie.clm_blob +Link: cypress/cyfmac43570-pcie.clm_blob -> ../brcm/brcmfmac43570-pcie.clm_blob File: cypress/cyfmac4373-sdio.bin +Link: cypress/cyfmac4373-sdio.bin -> ../brcm/brcmfmac4373-sdio.bin File: cypress/cyfmac4373-sdio.clm_blob +Link: cypress/cyfmac4373-sdio.clm_blob -> ../brcm/brcmfmac4373-sdio.clm_blob File: cypress/cyfmac54591-pcie.bin +Link: cypress/cyfmac54591-pcie.bin -> ../brcm/brcmfmac54591-pcie.bin File: cypress/cyfmac54591-pcie.clm_blob +Link: cypress/cyfmac54591-pcie.clm_blob -> ../brcm/brcmfmac54591-pcie.clm_blob Licence: Redistributable. See LICENCE.cypress for details.