Skip to contentSkip to conversation

net: mvneta: fix error message when MTU too large for XDP

PATCH Applied Marek Behún 2 participants 2 messages Jan 5, 2021 – Jan 7, 2021

Subsystems (3)
Networking Network drivers Marvell mvneta Ethernet driver
lore
Share & tools
lore

Marek Behún

author
#0 lore raw

PATCH v2 1/1 net: mvneta: fix error message when MTU too large for XDP

The error message says that "Jumbo frames are not supported on XDP", but the code checks for mtu > MVNETA_MAX_RX_BUF_SIZE, not mtu > 1500.

Fix this error message.

Signed-off-by Marek Behún <[email protected]>
Fixes 0db51da7a8e9 ("net: mvneta: add basic XDP support")
Cc Lorenzo Bianconi <[email protected]>
Cc Thomas Petazzoni <[email protected]>
---
 drivers/net/ethernet/marvell/mvneta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/marvell/mvneta.c +1 -1
index 563ceac3060f..e11292bd60a8 100644
@@ -4432,7 +4432,7 @@ static int mvneta_xdp_setup(struct net_device *dev, struct bpf_prog *prog,
 	struct bpf_prog *old_prog;
 
 	if (prog && dev->mtu > MVNETA_MAX_RX_BUF_SIZE) {
-		NL_SET_ERR_MSG_MOD(extack, "Jumbo frames not supported on XDP");
+		NL_SET_ERR_MSG_MOD(extack, "MTU too large for XDP");
 		return -EOPNOTSUPP;
 	}
Signature · 1 line
2.26.2
CI Applied
#1 lore raw
This patch was applied to netdev/net.git (refs/heads/master):

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

Quoted 11 lines · On Tue, 5 Jan 2021 18:23:33 +0100 you wrote:

The error message says that "Jumbo frames are not supported on XDP", but the code checks for mtu > MVNETA_MAX_RX_BUF_SIZE, not mtu > 1500.

Fix this error message.

Signed-off-by Marek Behún <[email protected]>
Fixes 0db51da7a8e9 ("net: mvneta: add basic XDP support")
Cc Lorenzo Bianconi <[email protected]>
Cc Thomas Petazzoni <[email protected]>

[...]

Here is the summary with links:
- [net-next,v2] net: mvneta: fix error message when MTU too large for XDP

    https://git.kernel.org/netdev/net/c/0d136f5cd9a7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html