Skip to contentSkip to conversation

clk: sunxi-ng: h6: Fix CEC clock

PATCH Applied Andre Przywara 3 participants 3 messages Jan 6, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: sunxi-ng: h6: Fix CEC clock

The CEC clock on the H6 SoC is a bit special, since it uses a fixed pre-dividier for one source clock (the PLL), but conveys the other clock (32K OSC) directly.
We are using a fixed predivider array for that, but fail to use the right flag to actually activate that.

Fixes 524353ea480b ("clk: sunxi-ng: add support for the Allwinner H6 CCU")
---
 drivers/clk/sunxi-ng/ccu-sun50i-h6.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/sunxi-ng/ccu-sun50i-h6.c +1 -1
index f2497d0a4683..a26dbbdff80d 100644
@@ -682,7 +682,7 @@ static struct ccu_mux hdmi_cec_clk = {
 
 	.common		= {
 		.reg		= 0xb10,
-		.features	= CCU_FEATURE_VARIABLE_PREDIV,
+		.features	= CCU_FEATURE_FIXED_PREDIV,
 		.hw.init	= CLK_HW_INIT_PARENTS("hdmi-cec",
 						      hdmi_cec_parents,
 						      &ccu_mux_ops,
Signature · 1 line
2.17.5
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Andre Przywara

The CEC clock on the H6 SoC is a bit special, since it uses a fixed pre-dividier for one source clock (the PLL), but conveys the other clock (32K OSC) directly.
We are using a fixed predivider array for that, but fail to use the right flag to actually activate that.

Fixes 524353ea480b ("clk: sunxi-ng: add support for the Allwinner H6 CCU")
#2 lore raw
In reply to Andre Przywara
Quoted 9 lines · Andre Przywara

The CEC clock on the H6 SoC is a bit special, since it uses a fixed pre-dividier for one source clock (the PLL), but conveys the other clock (32K OSC) directly.
We are using a fixed predivider array for that, but fail to use the right flag to actually activate that.

Fixes 524353ea480b ("clk: sunxi-ng: add support for the Allwinner H6 CCU")

Applied, thanks!
Maxime