Skip to contentSkip to conversation

net: eth-uclass: Change uclass driver name to ethernet

PATCH New David Wu 2 participants 2 messages Jan 7, 2021 Networking

lore
Share & tools
lore

David Wu

author
#0 lore raw

PATCH 1/1 net: eth-uclass: Change uclass driver name to ethernet

dev_read_alias_seq() used uc_drv->name compared to alias stem string, Ethernet's alias stem uses "ethernet", which does not match the eth-uclass driver name "eth", can not get the correct index of ethernet alias namer. So it seems change uclass driver name to match the alias stem is a more reasonable way.

---
 net/eth-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/eth-uclass.c +1 -1
index e14695c0f1..7dd962db64 100644
@@ -594,7 +594,7 @@ static int eth_pre_remove(struct udevice *dev)
 }
 
 UCLASS_DRIVER(eth) = {
-	.name		= "eth",
+	.name		= "ethernet",
 	.id		= UCLASS_ETH,
 	.post_bind	= eth_post_bind,
 	.pre_unbind	= eth_pre_unbind,
Signature · 1 line
2.19.1
#1 lore raw

PATCH 1/1 net: eth-uclass: Change uclass driver name to ethernet

Hi David,

Quoted 18 lines · David Wu

dev_read_alias_seq() used uc_drv->name compared to alias stem string, Ethernet's alias stem uses "ethernet", which does not match the eth-uclass driver name "eth", can not get the correct index of ethernet alias namer. So it seems change uclass driver name to match the alias stem is a more reasonable way.

---
 net/eth-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/eth-uclass.c +0 -0
index e14695c0f1..7dd962db64 100644

net/eth-uclass.c static int eth_pre_remove(struct udevice *dev) · line 596

Quoted 3 lines
net/eth-uclass.c +0 -0
@@ -594,7 +594,7 @@ static int eth_pre_remove(struct udevice *dev)
 }
 
 UCLASS_DRIVER(eth) = {

Should change this one too ^

Quoted 9 lines
net/eth-uclass.c +1 -2
-       .name           = "eth",
+       .name           = "ethernet",
        .id             = UCLASS_ETH,
        .post_bind      = eth_post_bind,
        .pre_unbind     = eth_pre_unbind,
--

2.19.1

Regards,
Simon

Quoted 1 line