Skip to contentSkip to conversation

package/genimage : fix dependency to host-mtools mcopy is used by genimage when creating fat parts

PATCH New Fabien Lehoussel 2 participants 2 messages Jan 7, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/genimage : fix dependency to host-mtools mcopy is used by genimage when creating fat parts

---
 package/genimage/Config.in.host | 1 +
 package/genimage/genimage.mk    | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
package/genimage/Config.in.host +1 -0
index cf831a143c..8db7eed8e4 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_HOST_GENIMAGE
 	bool "host genimage"
+	select BR2_PACKAGE_HOST_MTOOLS
 	help
 	  genimage is a tool to generate multiple filesystem and flash
 	  images from a given root filesystem tree. genimage is
package/genimage/genimage.mk +1 -1
index dde8f8b9e0..1fa93e0854 100644
@@ -7,7 +7,7 @@
 GENIMAGE_VERSION = 13
 GENIMAGE_SOURCE = genimage-$(GENIMAGE_VERSION).tar.xz
 GENIMAGE_SITE = https://github.com/pengutronix/genimage/releases/download/v$(GENIMAGE_VERSION)
-HOST_GENIMAGE_DEPENDENCIES = host-pkgconf host-libconfuse
+HOST_GENIMAGE_DEPENDENCIES = host-pkgconf host-libconfuse host-mtools
 GENIMAGE_LICENSE = GPL-2.0
 GENIMAGE_LICENSE_FILES = COPYING
 
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 package/genimage : fix dependency to host-mtools mcopy is used by genimage when creating fat parts

Fabien, All,

On 2021-01-07 12:06 +0100, Fabien Lehoussel spake thusly:

Quoted 22 lines
---
 package/genimage/Config.in.host | 1 +
 package/genimage/genimage.mk    | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
package/genimage/Config.in.host +1 -0
index cf831a143c..8db7eed8e4 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_HOST_GENIMAGE
 	bool "host genimage"
+	select BR2_PACKAGE_HOST_MTOOLS
 	help
 	  genimage is a tool to generate multiple filesystem and flash
 	  images from a given root filesystem tree. genimage is
package/genimage/genimage.mk +0 -0
index dde8f8b9e0..1fa93e0854 100644

package/genimage/genimage.mk line 10

Quoted 5 lines
package/genimage/genimage.mk +1 -1
@@ -7,7 +7,7 @@
 GENIMAGE_VERSION = 13
 GENIMAGE_SOURCE = genimage-$(GENIMAGE_VERSION).tar.xz
 GENIMAGE_SITE = https://github.com/pengutronix/genimage/releases/download/v$(GENIMAGE_VERSION)
-HOST_GENIMAGE_DEPENDENCIES = host-pkgconf host-libconfuse
+HOST_GENIMAGE_DEPENDENCIES = host-pkgconf host-libconfuse host-mtools

Not all genimage configurations require creating a vfat partition.

For example, we do have a few such configurations in Buildroot:

    $ grep -c vfat $(find board/ -name '*genimage*') |grep -E ':0$' |wc -l
    27
    $ cat board/amarula/vyasa/genimage.cfg
    image sdcard.img {
        hdimage {
        }

partition u-boot-tpl-spl-dtb {
in-partition-table = "no"
image = "u-boot-tpl-spl-dtb.img"
offset = 32K
}

partition u-boot-dtb {
in-partition-table = "no"
image = "u-boot-dtb.img"
offset = 8M
size = 30M # falcon mode: args @ 16M args, uImage @ 17M
}

partition rootfs {
partition-type = 0x83
image = "rootfs.ext4"
}
}

It is your respnsibility to enable whatever filesystem image generators you need for your system.

Regards,
Yann E. MORIN.

Quoted 10 lines
package/genimage/genimage.mk +0 -0
 GENIMAGE_LICENSE = GPL-2.0
 GENIMAGE_LICENSE_FILES = COPYING
 
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'