Skip to contentSkip to conversation

spi: bcm2835: Set controller max_speed_hz

PATCH In review Richard Fitzgerald 2 participants 3 messages Jan 7, 2021 – Jan 13, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: bcm2835: Set controller max_speed_hz

Set the struct spi_controller max_speed_hz. This is based on the reported source clock frequency during probe. The maximum bus clock is half the source clock (as per the code in bcm2835_spi_transfer_one).

If the controller max_speed_hz is not set, the spi core will limit all transfers to 0 Hz so only the minimum possible bus frequency would be used.

---
 drivers/spi/spi-bcm2835.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/spi/spi-bcm2835.c +2 -0
index 197485f2c2b2..8e161f4f7766 100644
@@ -1307,6 +1307,8 @@ static int bcm2835_spi_probe(struct platform_device *pdev)
 		return dev_err_probe(&pdev->dev, PTR_ERR(bs->clk),
 				     "could not get clk\n");
 
+	ctlr->max_speed_hz = clk_get_rate(bs->clk) / 2;
+
 	bs->irq = platform_get_irq(pdev, 0);
 	if (bs->irq <= 0)
 		return bs->irq ? bs->irq : -ENODEV;
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 2 lines · Richard Fitzgerald

If the controller max_speed_hz is not set, the spi core will limit all transfers to 0 Hz so only the minimum possible bus frequency would be used.

That was a bug and is now fixed.

maintainer
#2 lore raw
In reply to Richard Fitzgerald
Quoted 6 lines · Richard Fitzgerald

Set the struct spi_controller max_speed_hz. This is based on the reported source clock frequency during probe. The maximum bus clock is half the source clock (as per the code in bcm2835_spi_transfer_one).

If the controller max_speed_hz is not set, the spi core will limit all transfers to 0 Hz so only the minimum possible bus frequency would be used.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: bcm2835: Set controller max_speed_hz

      commit: c6892892a95debac8050579b0709214b7b28b514

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark