Skip to contentSkip to conversation

rcu-make-call_rcu-print-mem_dump_obj-info-for-double-freed-callback.patch removed from -mm tree

merged [email protected] 1 participant 1 message Jan 7, 2021

lore
Share & tools
lore

[email protected]

author tree notice Applied
#0 lore raw

The patch titled
Subject: rcu: make call_rcu() print mem_dump_obj() info for double-freed callback
has been removed from the -mm tree. Its filename was
rcu-make-call_rcu-print-mem_dump_obj-info-for-double-freed-callback.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: "Paul E. McKenney" <[email protected]>
Subject: rcu: make call_rcu() print mem_dump_obj() info for double-freed callback

The debug-object double-free checks in __call_rcu() print out the RCU callback function, which is usually sufficient to track down the double free. However, all uses of things like queue_rcu_work() will have the same RCU callback function (rcu_work_rcufn() in this case), so a diagnostic message for a double queue_rcu_work() needs more than just the callback function.

This commit therefore calls mem_dump_obj() to dump out any additional available information on the double-freed callback.

---

 kernel/rcu/tree.c |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
kernel/rcu/tree.c renamed from kernel/rcu/tree.c~rcu-make-call_rcu-print-mem_dump_obj-info-for-double-freed-callback +5 -2
@@ -2941,6 +2941,7 @@ static void check_cb_ovld(struct rcu_dat
 static void
 __call_rcu(struct rcu_head *head, rcu_callback_t func)
 {
+	static atomic_t doublefrees;
 	unsigned long flags;
 	struct rcu_data *rdp;
 	bool was_alldone;
@@ -2954,8 +2955,10 @@ __call_rcu(struct rcu_head *head, rcu_ca
 		 * Use rcu:rcu_callback trace event to find the previous
 		 * time callback was passed to __call_rcu().
 		 */
-		WARN_ONCE(1, "__call_rcu(): Double-freed CB %p->%pS()!!!\n",
-			  head, head->func);
+		if (atomic_inc_return(&doublefrees) < 4) {
+			pr_err("%s(): Double-freed CB %p->%pS()!!!  ", __func__, head, head->func);
+			mem_dump_obj(head);
+		}
 		WRITE_ONCE(head->func, rcu_leak_callback);
 		return;
 	}

_

Patches currently in -mm which might be from [email protected] are