fs/ext2: fix the file not found error when symlink filesize is 60
PATCH v2 1/1 fs/ext2: fix the file not found error when symlink filesize is 60
We encountered a file not found error when the symlink filesize is 60:
$ ls -l initrd lrwxrwxrwx 1 root root 60 Jan 6 16:37 initrd -> secure-core-image-initramfs-5.10.2-yoctodev-standard.cpio.gz
When booting, we got the following error in grub:
error: file `/initrd' not found
The root cause is although the size of diro->inode.symlink is 60, it includes the trailing '\0'. So if the symlink filesize is exactly 60, it is also stored in a separate block rather than in the inode.
--- grub-core/fs/ext2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
grub-core/fs/ext2.c +1 -1
@@ -732,7 +732,7 @@ grub_ext2_read_symlink (grub_fshelp_node_t node)/* If the filesize of the symlink is bigger than 60 the symlink is stored in a separate block, otherwise it is stored in the inode. */ -if (grub_le_to_cpu32 (diro->inode.size) <=sizeof (diro->inode.symlink)) +if (grub_le_to_cpu32 (diro->inode.size) <sizeof (diro->inode.symlink))grub_memcpy (symlink, diro->inode.symlink,grub_le_to_cpu32 (diro->inode.size));
Signature · 1 line
2.25.1
Quoted 4 lines · Yi Zhao
We encountered a file not found error when the symlink filesize is 60:
$ ls -l initrd lrwxrwxrwx 1 root root 60 Jan 6 16:37 initrd -> secure-core-image-initramfs-5.10.2-yoctodev-standard.cpio.gz
Quoted 8 lines
When booting, we got the following error in grub:
error: file `/initrd' not foundThe root cause is although the size of
diro->inode.symlinkis 60, it includes the trailing '\0'. So if the symlink filesize is exactly 60, it is also stored in a separate block rather than in the inode.Signed-off-by Yi Zhao <[email protected]>
Daniel