Skip to contentSkip to conversation

ARM: dts: rockchip: minor tweaks for rk3288-miqi.This series adds a missing mali GPU node and two additional CPU opp points

PATCH Applied Demetris Ierokipides 2 participants 5 messages Jan 8, 2021 – Jan 9, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover ARM: dts: rockchip: minor tweaks for rk3288-miqi.This series adds a missing mali GPU node and two additional CPU opp points

From: Ntemis <[email protected]>

Demetris Ierokipides (2):
ARM: dts: rockchip: add gpu node to rk3288-miqi
ARM: dts: rockchip: add extra cpu opp points to rk3288-miqi

 arch/arm/boot/dts/rk3288-miqi.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/2 ARM: dts: rockchip: add gpu node to rk3288-miqi

Add the Mali GPU node to the MiQi device-tree.

---
 arch/arm/boot/dts/rk3288-miqi.dts | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/rk3288-miqi.dts +5 -0
index cf54d5ffff2f..713f55e143c6 100644
@@ -123,6 +123,11 @@ &gmac {
 	status = "okay";
 };
 
+&gpu {
+	mali-supply = <&vdd_gpu>;
+	status = "okay";
+};
+
 &hdmi {
 	ddc-i2c-bus = <&i2c5>;
 	status = "okay";
Signature · 1 line
2.25.1
#2 lore raw

PATCH 2/2 ARM: dts: rockchip: add extra cpu opp points to rk3288-miqi

In reply to Demetris Ierokipides

Add extra 1.7GHz and 1.8GHz opp points to the MiQi device-tree to improve performance.

---
 arch/arm/boot/dts/rk3288-miqi.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)
arch/arm/boot/dts/rk3288-miqi.dts +12 -0
index 713f55e143c6..1b48855db6ff 100644
@@ -96,6 +96,18 @@ &cpu3 {
 	cpu-supply = <&vdd_cpu>;
 };
 
+&cpu_opp_table {
+	opp-1704000000 {
+		opp-hz = /bits/ 64 <1704000000>;
+		opp-microvolt = <1350000>;
+	};
+
+	opp-1800000000 {
+		opp-hz = /bits/ 64 <1800000000>;
+		opp-microvolt = <1350000>;
+	};
+};
+
 &emmc {
 	bus-width = <8>;
 	cap-mmc-highspeed;
Signature · 1 line
2.25.1
maintainer
#3 lore raw

Re: [PATCH 2/2] ARM: dts: rockchip: add extra cpu opp points to rk3288-miqi

Hi Demetris,

Am Freitag, 8. Januar 2021, 16:10:36 CET schrieb Demetris Ierokipides:

Quoted 18 lines

Add extra 1.7GHz and 1.8GHz opp points to the MiQi device-tree to improve performance.

---
 arch/arm/boot/dts/rk3288-miqi.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)
arch/arm/boot/dts/rk3288-miqi.dts +2 -0
index 713f55e143c6..1b48855db6ff 100644
@@ -96,6 +96,18 @@ &cpu3 {
 	cpu-supply = <&vdd_cpu>;
 };
 
+&cpu_opp_table {
+	opp-1704000000 {

arch/arm/boot/dts/rk3288-miqi.dts &cpu3 { · line 110

Quoted 10 lines
arch/arm/boot/dts/rk3288-miqi.dts +10 -0
+		opp-hz = /bits/ 64 <1704000000>;
+		opp-microvolt = <1350000>;
+	};
+
+	opp-1800000000 {
+		opp-hz = /bits/ 64 <1800000000>;
+		opp-microvolt = <1350000>;
+	};
+};
+

sorry, but no .

The OPPs in the mainline kernel match the specifications released by the soc vendor. Going outside these specs _may_ affect things like stability on some boards or in general simply the lifetime of the chip itself.

So yes, while boards may generally work with these higher frequencies I don't think this should be the default coming from the mainline kernel.

If board-owners feel the need to exceed the specs they can still modify the dts, but we shouldn't force this decision on everyone.

Heiko

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

maintainer Applied
#4 lore raw

Re: (subset) [PATCH 0/2] ARM: dts: rockchip: minor tweaks for rk3288-miqi.This series adds a missing mali GPU node and two additional CPU opp points

In reply to Demetris Ierokipides
Quoted 6 lines · Demetris Ierokipides

Demetris Ierokipides (2):
ARM: dts: rockchip: add gpu node to rk3288-miqi
ARM: dts: rockchip: add extra cpu opp points to rk3288-miqi

 arch/arm/boot/dts/rk3288-miqi.dts | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Applied, thanks!

[1/2] ARM: dts: rockchip: add gpu node to rk3288-miqi

      commit: 36948ec3d4d0d1b9260d87b550a56fab8d86d17d

Best regards,

Signature · 6 lines
Heiko Stuebner <[email protected]>

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip