arm64: dts: rockchip: rename pinctrl nodename to gmac2io for nanopi-r2s board
Subsystems (2)
PATCH 1/1 arm64: dts: rockchip: rename pinctrl nodename to gmac2io for nanopi-r2s board
A test with the command below gives this error:
/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dt.yaml:
ethernet-phy: 'reg' is a required property
The pinctrl nodename "ethernet-phy" conflicts with the rules in the "ethernet-phy.yaml" document, so rename it to "gmac2io".
make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/ethernet-phy.yaml
--- arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts +1 -1
@@ -280,7 +280,7 @@ }; }; - ethernet-phy { + gmac2io { eth_phy_reset_pin: eth-phy-reset-pin { rockchip,pins = <1 RK_PC2 RK_FUNC_GPIO &pcfg_pull_down>; };
Signature · 7 lines
2.11.0 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Hi Rob,
Quoted 7 lines · Johan Jonker
A test with the command below gives this error:
/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dt.yaml:
ethernet-phy: 'reg' is a required propertyThe pinctrl nodename "ethernet-phy" conflicts with the rules in the "
ethernet-phy.yaml" document, so rename it to "gmac2io".
This seems more like an unintended side effect of the ethernet-phy binding. Is there a way to limit the matching of the binding only if the parent is an "mdio" or "ethernet" node? Would that make more sense?
Regards
ChenYu
Quoted 25 lines
make ARCH=arm64
dtbs_checkDT_SCHEMA_FILES=Documentation/devicetree/bindings/net/ethernet-phy.yamlSigned-off-by Johan Jonker <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dts +1
-2@@ -280,7 +280,7 @@ }; }; - ethernet-phy { + gmac2io { eth_phy_reset_pin: eth-phy-reset-pin { rockchip,pins = <1 RK_PC2 RK_FUNC_GPIO &pcfg_pull_down>; }; --2.11.0
Quoted 4 lines
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Quoted 8 lines · Johan Jonker
A test with the command below gives this error:
/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s.dt.yaml:
ethernet-phy: 'reg' is a required propertyThe pinctrl nodename "ethernet-phy" conflicts with the rules in the "
ethernet-phy.yaml" document, so rename it to "gmac2io".[...]
Applied, thanks!
[1/1] arm64: dts: rockchip: rename pinctrl nodename to gmac2io for nanopi-r2s board
commit: 16459ecac6d6bf6a817d9c0cf78d696461fdcd26
Best regards,
Signature · 6 lines
Heiko Stuebner <[email protected]> _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip