clk: imx: fix Kconfig warning for i.MX SCU clk
Subsystems (3)
PATCH 1/1 clk: imx: fix Kconfig warning for i.MX SCU clk
From: Arnd Bergmann <[email protected]>
A previous patch introduced a harmless randconfig warning:
WARNING: unmet direct dependencies detected for MXC_CLK_SCU
Depends on [n]: COMMON_CLK [=y] && ARCH_MXC [=n] && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y]
Selected by [m]:
- CLK_IMX8QXP [=m] && COMMON_CLK [=y] && (ARCH_MXC [=n] && ARM64 [=y] || COMPILE_TEST [=y]) && IMX_SCU [=y] && HAVE_ARM_SMCCC [=y]
Since the symbol is now hidden and only selected by other symbols, just remove the dependencies and require the other drivers to get it right.
--- drivers/clk/imx/Kconfig | 2 -- 1 file changed, 2 deletions(-)
drivers/clk/imx/Kconfig +0 -2
@@ -6,8 +6,6 @@ config MXC_CLK config MXC_CLK_SCU tristate - depends on ARCH_MXC - depends on IMX_SCU && HAVE_ARM_SMCCC config CLK_IMX1 def_bool SOC_IMX1
Signature · 1 line
2.29.2
Quoted 9 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
A previous patch introduced a harmless randconfig warning:
WARNING: unmet direct dependencies detected for
MXC_CLK_SCU
Depends on [n]:COMMON_CLK[=y] &&ARCH_MXC[=n] &&IMX_SCU[=y] &&HAVE_ARM_SMCCC[=y]
Selected by [m]:
-CLK_IMX8QXP[=m] &&COMMON_CLK[=y] && (ARCH_MXC[=n] && ARM64 [=y] ||COMPILE_TEST[=y]) &&IMX_SCU[=y] &&HAVE_ARM_SMCCC[=y]
Quoted 7 lines
Since the symbol is now hidden and only selected by other symbols, just remove the dependencies and require the other drivers to get it right.
Fixes 6247e31b7530 ("clk: imx: scu: fix MXC_CLK_SCU module build break")Reported-by Anders Roxell <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>
Looks good to me.
Stephen, I assume that you will pick it up as a material for 5.11-rc.
Shawn
Stephen Boyd
maintainerQuoting Shawn Guo (2021-01-10 17:41:11)
Quoted 14 lines · Arnd Bergmann
Quoted 13 lines
From: Arnd Bergmann <[email protected]>
A previous patch introduced a harmless randconfig warning:
WARNING: unmet direct dependencies detected for
MXC_CLK_SCU
Depends on [n]:COMMON_CLK[=y] &&ARCH_MXC[=n] &&IMX_SCU[=y] &&HAVE_ARM_SMCCC[=y]
Selected by [m]:
-CLK_IMX8QXP[=m] &&COMMON_CLK[=y] && (ARCH_MXC[=n] && ARM64 [=y] ||COMPILE_TEST[=y]) &&IMX_SCU[=y] &&HAVE_ARM_SMCCC[=y]Since the symbol is now hidden and only selected by other symbols, just remove the dependencies and require the other drivers to get it right.
Quoted 8 lines
Quoted 3 lines
Fixes 6247e31b7530 ("clk: imx: scu: fix MXC_CLK_SCU module build break")Reported-by Anders Roxell <[email protected]>Signed-off-by Arnd Bergmann <[email protected]>Looks good to me.
Stephen, I assume that you will pick it up as a material for 5.11-rc.
Sure. Applied to clk-fixes.