rcu: Only trace when cbs are accelerated
PATCH 1/1 rcu: Only trace when cbs are accelerated
Fix rcu_accelerate_cbs() traces to only trace when cbs are accelerated in current call.
Signed-off-by Neeraj Upadhyay <[email protected]>
--- kernel/rcu/tree.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
kernel/rcu/tree.c +3 -2
@@ -1508,8 +1508,9 @@ static bool rcu_accelerate_cbs(struct rcu_node *rnp, struct rcu_data *rdp)* number. */ gp_seq_req =rcu_seq_snap (&rcu_state.gp_seq); -if (rcu_segcblist_accelerate (&rdp->cblist, gp_seq_req)) - ret =rcu_start_this_gp (rnp, rdp, gp_seq_req); +if (!rcu_segcblist_accelerate (&rdp->cblist, gp_seq_req)) +return ret; + ret =rcu_start_this_gp (rnp, rdp, gp_seq_req);/* Trace depending on how much we were able to accelerate. */ if (rcu_segcblist_restempty (&rdp->cblist,RCU_WAIT_TAIL ))
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Steven Rostedt
reviewerQuoted 2 lines · On Mon, 11 Jan 2021 17:15:01 +0530 Neeraj Upadhyay <[email protected]>…
Fix
rcu_accelerate_cbs()traces to only trace when cbs are accelerated in current call.
The body of the commit should explain "why" not "what". Why not trace the cbs when not accelerated in the current call?
-- Steve
Quoted 2 lines
Signed-off-by Neeraj Upadhyay <[email protected]>