Skip to contentSkip to conversation

package/coremark-pro: fix build without threads

PATCH New Chris Packham 2 participants 3 messages Jan 11, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/coremark-pro: fix build without threads

Coremark-pro requires threads so add a depends on
BR2_TOOLCHAIN_HAS_THREADS.

Fixes:
- http://autobuild.buildroot.net/results/ab574485a7856fcf5cd643c154c44b4bfcb34a97/

---
 package/coremark-pro/Config.in | 5 +++++
 1 file changed, 5 insertions(+)
package/coremark-pro/Config.in +5 -0
index dd6821056c..362826f47b 100644
@@ -1,8 +1,13 @@
 config BR2_PACKAGE_COREMARK_PRO
 	bool "coremark-pro"
 	depends on BR2_USE_MMU # perl uses fork()
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_PERL
 	help
 	  CoreMark-PRO is a comprehensive, advanced processor benchmark.
 
 	  https://www.eembc.org/coremark-pro/
+
+comment "coremark-pro needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_USE_MMU
Signature · 1 line
2.30.0
#1 lore raw

PATCH 1/1 package/coremark-pro: fix build without threads

Quoted 10 lines · On Mon, 11 Jan 2021 22:13:53 +1300 Chris Packham <[email protected]>…

Coremark-pro requires threads so add a depends on
BR2_TOOLCHAIN_HAS_THREADS.

Fixes:
- http://autobuild.buildroot.net/results/ab574485a7856fcf5cd643c154c44b4bfcb34a97/

---
 package/coremark-pro/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

I've adjusted the commit title, but this commit doesn't really "fix build without threads", it rather adds a dependency on threads :-)

Applied with this minor change. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/coremark-pro: fix build without threads

Quoted 10 lines · On Tue, Jan 12, 2021, 10:22 Thomas Petazzoni <[email protected]>…
Quoted 5 lines · On Mon, 11 Jan 2021 22:13:53 +1300 Chris Packham <[email protected]>…

Coremark-pro requires threads so add a depends on
BR2_TOOLCHAIN_HAS_THREADS.

Fixes:
-

http://autobuild.buildroot.net/results/ab574485a7856fcf5cd643c154c44b4bfcb34a97/

Quoted 1 line
Quoted 8 lines
Quoted 4 lines
---
 package/coremark-pro/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

I've adjusted the commit title, but this commit doesn't really "fix build without threads", it rather adds a dependency on threads :-)

Thanks. I did struggle to come up with a sensible commit message so ended up copying the last commit that did something similar.

Quoted 8 lines

Applied with this minor change. Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210112/ebf8aaa1/attachment.html>