Add MIPI rx DPI support
Subsystems (4)
v2 cover Add MIPI rx DPI support
Hi all, this patch series implement MIPI rx DPI feature. Please help to review.
This is the v2 version, any mistakes, please let me know, I'll fix it in the next series.
Change history:
v2: Fix Rob Herring comment
- Fix yamllint warnings/errors in analogix,anx7625.yaml
- Fix kernel robot compiling warning
v1: initial MIPI rx DPI feature support
Xin Ji (2):
dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting drm/bridge: anx7625: add MIPI DPI input feature support
.../bindings/display/bridge/analogix,anx7625.yaml | 25 +- drivers/gpu/drm/bridge/analogix/anx7625.c | 344 +++++++++++++++++++-- drivers/gpu/drm/bridge/analogix/anx7625.h | 24 +- 3 files changed, 371 insertions(+), 22 deletions(-)
Signature · 1 line
2.7.4
PATCH v2 1/2 dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting
Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add swing setting for adjusting DP tx PHY swing
--- .../bindings/display/bridge/analogix,anx7625.yaml | 25 ++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +23 -2
@@ -34,6 +34,16 @@ properties: description: used for reset chip control, RESET_N pin B7. maxItems: 1 + analogix,swing-setting: + type: uint8-array + $ref: /schemas/types.yaml#/definitions/uint32-array + description: an array of swing register setting for DP tx PHY + + analogix,mipi-dpi-in: + type: int + $ref: /schemas/types.yaml#/definitions/uint32 + description: indicate the MIPI rx signal type is DPI or DSI + ports: type: object
@@ -49,8 +59,8 @@ properties: Video port for panel or connector. required: - - port@0 - - port@1 + - port@0 + - port@1 required: - compatible
@@ -72,6 +82,17 @@ examples: reg = <0x58>; enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; + analogix,swing-setting = <0x00 0x14>, <0x01 0x54>, + <0x02 0x64>, <0x03 0x74>, <0x04 0x29>, + <0x05 0x7b>, <0x06 0x77>, <0x07 0x5b>, + <0x08 0x7f>, <0x0c 0x20>, <0x0d 0x60>, + <0x10 0x60>, <0x12 0x40>, <0x13 0x60>, + <0x14 0x14>, <0x15 0x54>, <0x16 0x64>, + <0x17 0x74>, <0x18 0x29>, <0x19 0x7b>, + <0x1a 0x77>, <0x1b 0x5b>, <0x1c 0x7f>, + <0x20 0x20>, <0x21 0x60>, <0x24 0x60>, + <0x26 0x40>, <0x27 0x60>; + analogix,mipi-dpi-in = <0>; ports { #address-cells = <1>;
Signature · 1 line
2.7.4
Rob Herring
maintainerRe: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting
Quoted 13 lines · Xin Ji
Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add swing setting for adjusting DP tx PHY swing
Signed-off-by Xin Ji <[email protected]>--- .../bindings/display/bridge/analogix,anx7625.yaml | 25 ++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +0
-0
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml properties: · line 38
Quoted 5 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +2
-0@@ -34,6 +34,16 @@ properties: description: used for reset chip control, RESET_N pin B7. maxItems: 1 + analogix,swing-setting: + type: uint8-array
Humm, this should have be rejected by the meta-schema.
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml properties: · line 39
Quoted 1 line
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +1
-0+ $ref: /schemas/types.yaml#/definitions/uint32-array
This is how types are defined other than boolean or nodes (object).
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml properties: · line 45
Quoted 6 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +6
-0+ description: an array of swing register setting for DP tx PHY + + analogix,mipi-dpi-in: + type: int + $ref: /schemas/types.yaml#/definitions/uint32 + description: indicate the MIPI rx signal type is DPI or DSI
Why does this need to be in DT, you should be able to determine this based on what you are connected to.
Quoted 19 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +3
-2+ ports: type: object@@ -49,8 +59,8 @@ properties: Video port for panel or connector. required: - - port@0 - - port@1 + - port@0 + - port@1 required: - compatible@@ -72,6 +82,17 @@ examples: reg = <0x58>; enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml examples: · line 94
Quoted 10 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +10
-0+ analogix,swing-setting = <0x00 0x14>, <0x01 0x54>, + <0x02 0x64>, <0x03 0x74>, <0x04 0x29>, + <0x05 0x7b>, <0x06 0x77>, <0x07 0x5b>, + <0x08 0x7f>, <0x0c 0x20>, <0x0d 0x60>, + <0x10 0x60>, <0x12 0x40>, <0x13 0x60>, + <0x14 0x14>, <0x15 0x54>, <0x16 0x64>, + <0x17 0x74>, <0x18 0x29>, <0x19 0x7b>, + <0x1a 0x77>, <0x1b 0x5b>, <0x1c 0x7f>, + <0x20 0x20>, <0x21 0x60>, <0x24 0x60>, + <0x26 0x40>, <0x27 0x60>;
This is a matrix, which is different from an array type.
Quoted 7 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +1
-0+ analogix,mipi-dpi-in = <0>; ports { #address-cells = <1>;Signature · 1 line
2.7.4
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting
Hi Rob Herring, thanks for the comments.
Quoted 17 lines · Rob Herring
Quoted 16 lines · Xin Ji
Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add swing setting for adjusting DP tx PHY swing
Signed-off-by Xin Ji <[email protected]>--- .../bindings/display/bridge/analogix,anx7625.yaml | 25 ++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +0
-0@@ -34,6 +34,16 @@ properties: description: used for reset chip control, RESET_N pin B7. maxItems: 1
Quoted 4 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml properties: · line 38
Quoted 2 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +2
-0+ analogix,swing-setting: + type: uint8-arrayHumm, this should have be rejected by the meta-schema.
We needs define an array to adjust DP tx PHY swing, the developer hopes these settings are changeable, so I moved the register data to DT. Can you give me some suggestion if it is rejected by the meta-schema?
Quoted 12 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml properties: · line 39
Quoted 2 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +1
-0+ $ref: /schemas/types.yaml#/definitions/uint32-arrayThis is how types are defined other than boolean or nodes (object).
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml properties: · line 45
Quoted 6 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +6
-0+ description: an array of swing register setting for DP tx PHY + + analogix,mipi-dpi-in: + type: int + $ref: /schemas/types.yaml#/definitions/uint32 + description: indicate the MIPI rx signal type is DPI or DSI
Quoted 2 lines
Why does this need to be in DT, you should be able to determine this based on what you are connected to.
As the anx7625 can receive MIPI DSI and DPI data (depends on hardware implement, we have a project which have two anx7625, one is DSI input, the other is DPI input), we needs to let driver know what kind of MIPI rx signal input. And there is no other way to tell driver the MIPI rx signal type, we needs define this flag.
Quoted 24 lines
Quoted 24 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +7
-2+ ports: type: object@@ -49,8 +59,8 @@ properties: Video port for panel or connector. required: - - port@0 - - port@1 + - port@0 + - port@1 required: - compatible@@ -72,6 +82,17 @@ examples: reg = <0x58>; enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; + analogix,swing-setting = <0x00 0x14>, <0x01 0x54>, + <0x02 0x64>, <0x03 0x74>, <0x04 0x29>, + <0x05 0x7b>, <0x06 0x77>, <0x07 0x5b>, + <0x08 0x7f>, <0x0c 0x20>, <0x0d 0x60>,
Quoted 8 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml examples: · line 94
Quoted 6 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +6
-0+ <0x10 0x60>, <0x12 0x40>, <0x13 0x60>, + <0x14 0x14>, <0x15 0x54>, <0x16 0x64>, + <0x17 0x74>, <0x18 0x29>, <0x19 0x7b>, + <0x1a 0x77>, <0x1b 0x5b>, <0x1c 0x7f>, + <0x20 0x20>, <0x21 0x60>, <0x24 0x60>, + <0x26 0x40>, <0x27 0x60>;This is a matrix, which is different from an array type.
OK, I'll change to array if this vendor define has been accepted.
Quoted 8 lines
Quoted 8 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +1
-0+ analogix,mipi-dpi-in = <0>; ports { #address-cells = <1>;Signature · 1 line
2.7.4
Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting
Quoted 79 lines · Xin Ji
Hi Rob Herring, thanks for the comments.
Quoted 17 lines · Rob Herring
Quoted 16 lines · Xin Ji
Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add swing setting for adjusting DP tx PHY swing
Signed-off-by Xin Ji <[email protected]>--- .../bindings/display/bridge/analogix,anx7625.yaml | 25 ++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +0
-0@@ -34,6 +34,16 @@ properties: description: used for reset chip control, RESET_N pin B7. maxItems: 1Quoted 4 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml properties: · line 38
Quoted 2 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +2
-0+ analogix,swing-setting: + type: uint8-arrayHumm, this should have be rejected by the meta-schema.
We needs define an array to adjust DP tx PHY swing, the developer hopes these settings are changeable, so I moved the register data to DT. Can you give me some suggestion if it is rejected by the meta-schema?
Quoted 12 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml properties: · line 39
Quoted 2 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +1
-0+ $ref: /schemas/types.yaml#/definitions/uint32-arrayThis is how types are defined other than boolean or nodes (object).
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml properties: · line 45
Quoted 6 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +6
-0+ description: an array of swing register setting for DP tx PHY + + analogix,mipi-dpi-in: + type: int + $ref: /schemas/types.yaml#/definitions/uint32 + description: indicate the MIPI rx signal type is DPI or DSIQuoted 2 lines
Why does this need to be in DT, you should be able to determine this based on what you are connected to.
As the anx7625 can receive MIPI DSI and DPI data (depends on hardware implement, we have a project which have two anx7625, one is DSI input, the other is DPI input), we needs to let driver know what kind of MIPI rx signal input. And there is no other way to tell driver the MIPI rx signal type, we needs define this flag.
Quoted 24 lines
Quoted 24 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +7
-2+ ports: type: object@@ -49,8 +59,8 @@ properties: Video port for panel or connector. required: - - port@0 - - port@1 + - port@0 + - port@1 required: - compatible@@ -72,6 +82,17 @@ examples: reg = <0x58>; enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; + analogix,swing-setting = <0x00 0x14>, <0x01 0x54>, + <0x02 0x64>, <0x03 0x74>, <0x04 0x29>, + <0x05 0x7b>, <0x06 0x77>, <0x07 0x5b>, + <0x08 0x7f>, <0x0c 0x20>, <0x0d 0x60>,Quoted 8 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml examples: · line 94
Quoted 6 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +6
-0+ <0x10 0x60>, <0x12 0x40>, <0x13 0x60>, + <0x14 0x14>, <0x15 0x54>, <0x16 0x64>, + <0x17 0x74>, <0x18 0x29>, <0x19 0x7b>, + <0x1a 0x77>, <0x1b 0x5b>, <0x1c 0x7f>, + <0x20 0x20>, <0x21 0x60>, <0x24 0x60>, + <0x26 0x40>, <0x27 0x60>;This is a matrix, which is different from an array type.
Quoted 1 line
OK, I'll change to array if this vendor define has been accepted.
I also wonder if we want to split the parameters per lane, and simply have a flat array (instead of reg/value pairs like you have now).
Registers 0x00 to 0x13 have to do with Lane 0 (and 0x14 to 0x27 with Lane 1): you can almost tell from the example values, they repeat. I'm not sure if there's any value splitting those further (I don't think anybody will be able to tune those without ANX's help).
So, maybe something like:
anx,swing-setting = <<[reg values for lane 0]>, <[reg values for lane 1]>> where <[reg values for lane 0]> would be something like <0x14, 0x54, 0x64, ...> (that is, all the values between 0x00 and 0x13).
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +1
-1+ analogix,mipi-dpi-in = <0>; ports { #address-cells = <1>; --2.7.4
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting
Quoted 90 lines · Nicolas Boichat
Quoted 79 lines · Xin Ji
Hi Rob Herring, thanks for the comments.
Quoted 17 lines · Rob Herring
Quoted 16 lines · Xin Ji
Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add swing setting for adjusting DP tx PHY swing
Signed-off-by Xin Ji <[email protected]>--- .../bindings/display/bridge/analogix,anx7625.yaml | 25 ++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +0
-0@@ -34,6 +34,16 @@ properties: description: used for reset chip control, RESET_N pin B7. maxItems: 1Quoted 4 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml properties: · line 38
Quoted 2 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +2
-0+ analogix,swing-setting: + type: uint8-arrayHumm, this should have be rejected by the meta-schema.
We needs define an array to adjust DP tx PHY swing, the developer hopes these settings are changeable, so I moved the register data to DT. Can you give me some suggestion if it is rejected by the meta-schema?
Quoted 12 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml properties: · line 39
Quoted 2 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +1
-0+ $ref: /schemas/types.yaml#/definitions/uint32-arrayThis is how types are defined other than boolean or nodes (object).
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml properties: · line 45
Quoted 6 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +6
-0+ description: an array of swing register setting for DP tx PHY + + analogix,mipi-dpi-in: + type: int + $ref: /schemas/types.yaml#/definitions/uint32 + description: indicate the MIPI rx signal type is DPI or DSIQuoted 2 lines
Why does this need to be in DT, you should be able to determine this based on what you are connected to.
As the anx7625 can receive MIPI DSI and DPI data (depends on hardware implement, we have a project which have two anx7625, one is DSI input, the other is DPI input), we needs to let driver know what kind of MIPI rx signal input. And there is no other way to tell driver the MIPI rx signal type, we needs define this flag.
Quoted 24 lines
Quoted 24 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +7
-2+ ports: type: object@@ -49,8 +59,8 @@ properties: Video port for panel or connector. required: - - port@0 - - port@1 + - port@0 + - port@1 required: - compatible@@ -72,6 +82,17 @@ examples: reg = <0x58>; enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; + analogix,swing-setting = <0x00 0x14>, <0x01 0x54>, + <0x02 0x64>, <0x03 0x74>, <0x04 0x29>, + <0x05 0x7b>, <0x06 0x77>, <0x07 0x5b>, + <0x08 0x7f>, <0x0c 0x20>, <0x0d 0x60>,Quoted 8 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml examples: · line 94
Quoted 6 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +6
-0+ <0x10 0x60>, <0x12 0x40>, <0x13 0x60>, + <0x14 0x14>, <0x15 0x54>, <0x16 0x64>, + <0x17 0x74>, <0x18 0x29>, <0x19 0x7b>, + <0x1a 0x77>, <0x1b 0x5b>, <0x1c 0x7f>, + <0x20 0x20>, <0x21 0x60>, <0x24 0x60>, + <0x26 0x40>, <0x27 0x60>;This is a matrix, which is different from an array type.
Quoted 1 line
OK, I'll change to array if this vendor define has been accepted.
I also wonder if we want to split the parameters per lane, and simply have a flat array (instead of reg/value pairs like you have now).
Registers
0x00to0x13have to do with Lane 0 (and0x14to0x27with Lane 1): you can almost tell from the example values, they repeat. I'm not sure if there's any value splitting those further (I don't think anybody will be able to tune those without ANX's help).
Quoted 4 lines
So, maybe something like:
anx,swing-setting = <<[reg values for lane 0]>, <[reg values for lane 1]>> where <[reg values for lane 0]> would be something like <0x14,0x54,0x64, ...> (that is, all the values between0x00and0x13).
Hi Nicolas, it is a good way, 0x00 to 0x13 for lane0, 0x14 to 0x27 for lane1. I'll split the parameters per lane.
Thanks,
Xin
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +1
-1+ analogix,mipi-dpi-in = <0>; ports { #address-cells = <1>; --2.7.4
Rob Herring
maintainerRe: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting
In reply to Xin JiQuoted 40 lines · Xin Ji
Hi Rob Herring, thanks for the comments.
Quoted 17 lines · Rob Herring
Quoted 16 lines · Xin Ji
Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add swing setting for adjusting DP tx PHY swing
Signed-off-by Xin Ji <[email protected]>--- .../bindings/display/bridge/analogix,anx7625.yaml | 25 ++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +0
-0@@ -34,6 +34,16 @@ properties: description: used for reset chip control, RESET_N pin B7. maxItems: 1Quoted 4 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml properties: · line 38
Quoted 2 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +2
-0+ analogix,swing-setting: + type: uint8-arrayHumm, this should have be rejected by the meta-schema.
We needs define an array to adjust DP tx PHY swing, the developer hopes these settings are changeable, so I moved the register data to DT. Can you give me some suggestion if it is rejected by the meta-schema?
Quoted 12 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml properties: · line 39
Quoted 2 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +1
-0+ $ref: /schemas/types.yaml#/definitions/uint32-arrayThis is how types are defined other than boolean or nodes (object).
Quoted 6 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +6
-0+ description: an array of swing register setting for DP tx PHY + + analogix,mipi-dpi-in: + type: int + $ref: /schemas/types.yaml#/definitions/uint32 + description: indicate the MIPI rx signal type is DPI or DSI
Quoted 7 lines
Quoted 2 lines
Why does this need to be in DT, you should be able to determine this based on what you are connected to.
As the anx7625 can receive MIPI DSI and DPI data (depends on hardware implement, we have a project which have two anx7625, one is DSI input, the other is DPI input), we needs to let driver know what kind of MIPI rx signal input. And there is no other way to tell driver the MIPI rx signal type, we needs define this flag.
That's only true if what's driving the output is a single h/w block that can drive either. But typically you have 2 blocks: an LCD controller driving parallel signals and a DSI controller in front of it doing parallel to DSI conversion. The anx7625 would be connected to the LCD controller or DSI controller via the graph binding depending on the h/w connection.
However, if you do need this, then let's extend video-interfaces.yaml 'bus-type' to include DSI (it already has parallel).
Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting
Quoted 56 lines · Rob Herring
Quoted 40 lines · Xin Ji
Hi Rob Herring, thanks for the comments.
Quoted 17 lines · Rob Herring
Quoted 16 lines · Xin Ji
Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add swing setting for adjusting DP tx PHY swing
Signed-off-by Xin Ji <[email protected]>--- .../bindings/display/bridge/analogix,anx7625.yaml | 25 ++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +0
-0@@ -34,6 +34,16 @@ properties: description: used for reset chip control, RESET_N pin B7. maxItems: 1Quoted 4 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml properties: · line 38
Quoted 2 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +2
-0+ analogix,swing-setting: + type: uint8-arrayHumm, this should have be rejected by the meta-schema.
We needs define an array to adjust DP tx PHY swing, the developer hopes these settings are changeable, so I moved the register data to DT. Can you give me some suggestion if it is rejected by the meta-schema?
Quoted 12 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml properties: · line 39
Quoted 2 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +1
-0+ $ref: /schemas/types.yaml#/definitions/uint32-arrayThis is how types are defined other than boolean or nodes (object).
Quoted 6 lines
Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml +6
-0+ description: an array of swing register setting for DP tx PHY + + analogix,mipi-dpi-in: + type: int + $ref: /schemas/types.yaml#/definitions/uint32 + description: indicate the MIPI rx signal type is DPI or DSIQuoted 7 lines
Quoted 2 lines
Why does this need to be in DT, you should be able to determine this based on what you are connected to.
As the anx7625 can receive MIPI DSI and DPI data (depends on hardware implement, we have a project which have two anx7625, one is DSI input, the other is DPI input), we needs to let driver know what kind of MIPI rx signal input. And there is no other way to tell driver the MIPI rx signal type, we needs define this flag.
That's only true if what's driving the output is a single h/w block that can drive either. But typically you have 2 blocks: an LCD controller driving parallel signals and a DSI controller in front of it doing parallel to DSI conversion. The anx7625 would be connected to the LCD controller or DSI controller via the graph binding depending on the h/w connection.
Quoted 4 lines
However, if you do need this, then let's extend
video-interfaces.yaml'bus-type' to include DSI (it already has parallel).Rob
Hi Rob, thanks, I'll add 'bus-type' in the next version. Thanks,
Xin
PATCH v2 2/2 drm/bridge: anx7625: add MIPI DPI input feature support
In reply to Xin JiAdd MIPI rx DPI input support
--- drivers/gpu/drm/bridge/analogix/anx7625.c | 344 ++++++++++++++++++++++++++++-- drivers/gpu/drm/bridge/analogix/anx7625.h | 24 ++- 2 files changed, 348 insertions(+), 20 deletions(-)
drivers/gpu/drm/bridge/analogix/anx7625.c +325 -19
@@ -164,6 +164,20 @@ static int anx7625_write_and_or(struct anx7625_data *ctx, offset, (val & and_mask) | (or_mask)); } +static int anx7625_config_bit_matrix (struct anx7625_data *ctx) +{ +int i, ret; + + ret =anx7625_reg_write (ctx, ctx->i2c.tx_p2_client, +AUDIO_CONTROL_REGISTER ,0x80 ); +for (i =0 ; i <13 ; i++) + ret |=anx7625_reg_write (ctx, ctx->i2c.tx_p2_client, +VIDEO_BIT_MATRIX_12 + i, +0x18 + i); + +return ret; +} +static int anx7625_read_ctrl_status_p0 (struct anx7625_data *ctx) {return anx7625_reg_read (ctx, ctx->i2c.rx_p0_client,AP_AUX_CTRL_STATUS );
@@ -189,10 +203,64 @@ static int wait_aux_op_finish(struct anx7625_data *ctx) AP_AUX_CTRL_STATUS);if (val <0 || (val &0x0F )) {DRM_DEV_ERROR (dev,"aux status %02x\n" , val); - val = -EIO ; +return -EIO ; } -return val; +return 0 ; +} + +static int anx7625_aux_dpcd_read (struct anx7625_data *ctx, +u8 addrh,u8 addrm,u8 addrl, +u8 len,u8 *buf) +{ +struct device *dev = &ctx->client->dev; +int ret; +u8 cmd; + +if (len >MAX_DPCD_BUFFER_SIZE ) { +DRM_DEV_ERROR (dev,"exceed aux buffer len.\n" ); +return -E2BIG ; + } + + cmd = ((len -1 ) <<4 ) |0x09 ; + +/* Set command and length */ + ret =anx7625_reg_write (ctx, ctx->i2c.rx_p0_client, +AP_AUX_COMMAND , cmd); + +/* Set aux access address */ + ret |=anx7625_reg_write (ctx, ctx->i2c.rx_p0_client, +AP_AUX_ADDR_7_0 , addrl); + ret |=anx7625_reg_write (ctx, ctx->i2c.rx_p0_client, +AP_AUX_ADDR_15_8 , addrm); + ret |=anx7625_write_and (ctx, ctx->i2c.rx_p0_client, +AP_AUX_ADDR_19_16 , addrh); + +/* Enable aux access */ + ret |=anx7625_write_or (ctx, ctx->i2c.rx_p0_client, +AP_AUX_CTRL_STATUS ,AP_AUX_CTRL_OP_EN ); + +if (ret <0 ) { +DRM_DEV_ERROR (dev,"cannot access aux related register.\n" ); +return -EIO ; + } + +usleep_range (2000 ,2100 ); + + ret =wait_aux_op_finish (ctx); +if (ret) { +DRM_DEV_ERROR (dev,"aux IO error: wait aux op finish.\n" ); +return ret; + } + + ret =anx7625_reg_block_read (ctx, ctx->i2c.rx_p0_client, +AP_AUX_BUFF_START , len, buf); +if (ret <0 ) { +DRM_DEV_ERROR (dev,"read dpcd register failed\n" ); +return -EIO ; + } + +return 0 ; } static int anx7625_video_mute_control(struct anx7625_data *ctx,
@@ -595,6 +663,101 @@ static int anx7625_dsi_config(struct anx7625_data *ctx)return ret; } +static int anx7625_api_dpi_config (struct anx7625_data *ctx) +{ +struct device *dev = &ctx->client->dev; +u16 freq = ctx->dt.pixelclock.min /1000 ; +int ret; + +/* configure pixel clock */ + ret =anx7625_reg_write (ctx, ctx->i2c.rx_p0_client, +PIXEL_CLOCK_L , freq &0xFF ); + ret |=anx7625_reg_write (ctx, ctx->i2c.rx_p0_client, +PIXEL_CLOCK_H , (freq >>8 )); + +/* set DPI mode */ +/* set to DPI PLL module sel */ + ret |=anx7625_reg_write (ctx, ctx->i2c.rx_p1_client, +MIPI_DIGITAL_PLL_9 ,0x20 ); +/* power down MIPI */ + ret |=anx7625_reg_write (ctx, ctx->i2c.rx_p1_client, +MIPI_LANE_CTRL_10 ,0x08 ); +/* enable DPI mode */ + ret |=anx7625_reg_write (ctx, ctx->i2c.rx_p1_client, +MIPI_DIGITAL_PLL_18 ,0x1C ); +/* set first edge */ + ret |=anx7625_reg_write (ctx, ctx->i2c.tx_p2_client, +VIDEO_CONTROL_0 ,0x06 ); +if (ret <0 ) +DRM_DEV_ERROR (dev,"IO error : dpi phy set failed.\n" ); + +return ret; +} + +static int anx7625_dpi_config (struct anx7625_data *ctx) +{ +struct device *dev = &ctx->client->dev; +int ret; + +DRM_DEV_DEBUG_DRIVER (dev,"config dpi\n" ); + +/* DSC disable */ + ret =anx7625_write_and (ctx, ctx->i2c.rx_p0_client, +R_DSC_CTRL_0 , ~DSC_EN ); +if (ret <0 ) { +DRM_DEV_ERROR (dev,"IO error : disable dsc failed.\n" ); +return ret; + } + + ret =anx7625_config_bit_matrix (ctx); +if (ret <0 ) { +DRM_DEV_ERROR (dev,"config bit matrix failed.\n" ); +return ret; + } + + ret =anx7625_api_dpi_config (ctx); +if (ret <0 ) { +DRM_DEV_ERROR (dev,"mipi phy(dpi) setup failed.\n" ); +return ret; + } + +/* set MIPI RX EN */ + ret =anx7625_write_or (ctx, ctx->i2c.rx_p0_client, +AP_AV_STATUS ,AP_MIPI_RX_EN ); +/* clear mute flag */ + ret |=anx7625_write_and (ctx, ctx->i2c.rx_p0_client, +AP_AV_STATUS , (u8 )~AP_MIPI_MUTE ); +if (ret <0 ) +DRM_DEV_ERROR (dev,"IO error : enable mipi rx failed.\n" ); + +return ret; +} + +static int anx7625_hdcp_setting (struct anx7625_data *ctx) +{ +u8 bcap; +struct device *dev = &ctx->client->dev; + +if (!(ctx->hdcp_support && ctx->hdcp_en)) { +DRM_DEV_DEBUG_DRIVER (dev,"hdcp_support(%d), hdcp_en(%d)\n" , + ctx->hdcp_support, ctx->hdcp_en); +DRM_DEV_DEBUG_DRIVER (dev,"disable HDCP by config\n" ); +return anx7625_write_and (ctx, ctx->i2c.rx_p1_client, +0xee ,0x9f ); + } + +anx7625_aux_dpcd_read (ctx,0x06 ,0x80 ,0x28 ,1 , &bcap); +if (!(bcap &0x01 )) { +DRM_WARN ("downstream not support HDCP 1.4, cap(%x).\n" , bcap); +return anx7625_write_and (ctx, ctx->i2c.rx_p1_client, +0xee ,0x9f ); + } + +DRM_DEV_DEBUG_DRIVER (dev,"enable HDCP 1.4\n" ); + +return anx7625_write_or (ctx, ctx->i2c.rx_p1_client,0xee ,0x20 ); +} +static void anx7625_dp_start (struct anx7625_data *ctx) {int ret;
@@ -605,9 +768,15 @@ static void anx7625_dp_start(struct anx7625_data *ctx)return ; } +/* HDCP config */ +anx7625_hdcp_setting (ctx); +anx7625_config_audio_input (ctx); - ret =anx7625_dsi_config (ctx); +if (ctx->pdata.is_dpi) + ret =anx7625_dpi_config (ctx); +else + ret =anx7625_dsi_config (ctx);if (ret <0 )DRM_DEV_ERROR (dev,"MIPI phy setup error.\n" );
@@ -688,8 +857,53 @@ static int sp_tx_get_edid_block(struct anx7625_data *ctx)return c; } -static int edid_read (struct anx7625_data *ctx, -u8 offset,u8 *pblock_buf) +static int check_hdcp_support (struct anx7625_data *ctx) +{ +int ret; +struct device *dev = &ctx->client->dev; + +/* Select HDCP1.4 Key load */ +anx7625_reg_write (ctx, ctx->i2c.rx_p0_client,FLASH_SRAM_SEL ,0x12 ); +/* Select flash addr low byte */ +anx7625_reg_write (ctx, ctx->i2c.rx_p0_client,FLASH_ADDR_LOW ,0x91 ); +/* Select flash addr high byte */ +anx7625_reg_write (ctx, ctx->i2c.rx_p0_client,FLASH_ADDR_HIGH ,0xa0 ); +/* Select sram length high byte */ +anx7625_reg_write (ctx, ctx->i2c.rx_p0_client,SRAM_LEN_HIGH ,0x00 ); +/* Select sram length low byte */ +anx7625_reg_write (ctx, ctx->i2c.rx_p0_client,SRAM_LEN_LOW ,0x27 ); +/* Select flash length high byte */ +anx7625_reg_write (ctx, ctx->i2c.rx_p0_client,FLASH_LEN_HIGH ,0x02 ); +/* Select flash length low byte */ +anx7625_reg_write (ctx, ctx->i2c.rx_p0_client,FLASH_LEN_LOW ,0x70 ); +/* Select sram addr high byte */ +anx7625_reg_write (ctx, ctx->i2c.rx_p0_client,SRAM_ADDR_HIGH ,0x00 ); +/* Select sram addr low byte */ +anx7625_reg_write (ctx, ctx->i2c.rx_p0_client,SRAM_ADDR_LOW ,0x00 ); +/* Enable load with decrypt_en */ +anx7625_reg_write (ctx, ctx->i2c.rx_p0_client,FLASH_LOAD_STA ,0x03 ); + +usleep_range (10000 ,11000 ); + +/* Check load status */ + ret =anx7625_reg_read (ctx, ctx->i2c.rx_p0_client,FLASH_LOAD_STA ); +if (ret <0 ) { +DRM_DEV_ERROR (dev,"IO error : access flash load.\n" ); +return ret; + } + +if ((ret &0xF2 ) !=0xF2 ) { + ctx->hdcp_support =0 ; +DRM_DEV_DEBUG_DRIVER (dev,"not support HDCP\n" ); + }else { + ctx->hdcp_support =1 ; +DRM_DEV_DEBUG_DRIVER (dev,"support HDCP\n" ); + } + +return 0 ; +} + +static int edid_read (struct anx7625_data *ctx,u8 offset,u8 *pblock_buf) {int ret, cnt;struct device *dev = &ctx->client->dev;
@@ -992,8 +1206,10 @@ static void anx7625_chip_control(struct anx7625_data *ctx, int state)if (state) {atomic_inc (&ctx->power_status); -if (atomic_read (&ctx->power_status) ==1 ) +if (atomic_read (&ctx->power_status) ==1 ) {anx7625_power_on_init (ctx); +check_hdcp_support (ctx); + } }else {if (atomic_read (&ctx->power_status)) {atomic_dec (&ctx->power_status);
@@ -1051,6 +1267,7 @@ static void anx7625_start_dp_work(struct anx7625_data *ctx)return ; } + ctx->hpd_status =1 ; ctx->hpd_high_cnt++;/* Not support HDCP */
@@ -1060,8 +1277,10 @@ static void anx7625_start_dp_work(struct anx7625_data *ctx) ret |=anx7625_write_or (ctx, ctx->i2c.rx_p1_client,0xec ,0x10 );/* Interrupt for DRM */ ret |=anx7625_write_or (ctx, ctx->i2c.rx_p1_client,0xff ,0x01 ); -if (ret <0 ) +if (ret <0 ) { +DRM_DEV_ERROR (dev,"fail to setting HDCP/auth\n" );return ; + } ret =anx7625_reg_read (ctx, ctx->i2c.rx_p1_client,0x86 );if (ret <0 )
@@ -1080,6 +1299,10 @@ static void anx7625_hpd_polling(struct anx7625_data *ctx)int ret, val;struct device *dev = &ctx->client->dev; +/* Interrupt mode, no need poll HPD status, just return */ +if (ctx->pdata.intp_irq) +return ; +if (atomic_read (&ctx->power_status) !=1 ) {DRM_DEV_DEBUG_DRIVER (dev,"No need to poling HPD status.\n" );return ;
@@ -1130,6 +1353,22 @@ static void anx7625_remove_edid(struct anx7625_data *ctx) ctx->slimport_edid_p.edid_block_num =-1 ; } +static void anx7625_dp_adjust_swing (struct anx7625_data *ctx) +{ +struct device *dev = &ctx->client->dev; +int i; + +if (!ctx->pdata.reg_table_size) +return ; + +DRM_DEV_DEBUG_DRIVER (dev,"adjust DP tx swing\n" ); + +for (i =0 ; i < ctx->pdata.reg_table_size; i++) +anx7625_reg_write (ctx, ctx->i2c.tx_p1_client, + ctx->pdata.art[i].offset &0xFF , + ctx->pdata.art[i].data &0xFF ); +} +static void dp_hpd_change_handler (struct anx7625_data *ctx,bool on) {struct device *dev = &ctx->client->dev;
@@ -1145,9 +1384,8 @@ static void dp_hpd_change_handler(struct anx7625_data *ctx, bool on) }else {DRM_DEV_DEBUG_DRIVER (dev," HPD high\n" );anx7625_start_dp_work (ctx); +anx7625_dp_adjust_swing (ctx); } - - ctx->hpd_status =1 ; }static int anx7625_hpd_change_detect (struct anx7625_data *ctx)
@@ -1224,12 +1462,64 @@ static irqreturn_t anx7625_intr_hpd_isr(int irq, void *data)return IRQ_HANDLED ; } +static int anx7625_get_u32_value (struct device_node *np, +const char *name, +int start_pos, +int *reg_data) +{ +int i, ret; + +/* each slot has 2 cells */ +for (i =0 ; i <2 ; i++) { + ret =of_property_read_u32_index (np, name, + start_pos + i, + ®_data[i]); +if (ret) +return ret; + } + +return 0 ; +} +static int anx7625_parse_dt (struct device *dev,struct anx7625_platform_data *pdata) {struct device_node *np = dev->of_node;struct drm_panel *panel; -int ret; +int ret, i; +int reg_data[2 ]; +int total_size, num_regs, start_pos; + +if (of_get_property (dev->of_node, +"analogix,swing-setting" , &total_size)) { +/* each slot has 2 cells */ + num_regs = total_size / (sizeof (u32) *2 ); +if (num_regs >MAX_REG_SIZE ) + num_regs =MAX_REG_SIZE ; + + pdata->reg_table_size = num_regs; + +for (i =0 ; i < num_regs; i++) { + start_pos = i *2 ; + ret =anx7625_get_u32_value (np,"analogix,swing-setting" , + start_pos, reg_data); +if (ret) { +DRM_DEV_ERROR (dev,"get swing-setting at %d\n" , + start_pos); +return -ENODEV ; + } + pdata->art[i].offset = reg_data[0 ]; + pdata->art[i].data = reg_data[1 ]; + } + } + + ret =of_property_read_u32 (dev->of_node,"analogix,mipi-dpi-in" , + &pdata->is_dpi); +if (ret) + pdata->is_dpi =0 ;/* default dsi mode */ + +DRM_DEV_DEBUG_DRIVER (dev,"MIPI RX is %s.\n" , + pdata->is_dpi ?"DPI" :"DSI" ); pdata->mipi_host_node =of_graph_get_remote_node (np,0 ,0 );if (!pdata->mipi_host_node) {
@@ -1237,7 +1527,7 @@ static int anx7625_parse_dt(struct device *dev,return -ENODEV ; } -DRM_DEV_DEBUG_DRIVER (dev,"found dsi host node.\n" ); +DRM_DEV_DEBUG_DRIVER (dev,"found MIPI host node.\n" ); ret =drm_of_find_panel_or_bridge (np,1 ,0 , &panel,NULL );if (ret <0 ) {
@@ -1300,9 +1590,13 @@ static enum drm_connector_status anx7625_sink_detect(struct anx7625_data *ctx) {struct device *dev = &ctx->client->dev; -DRM_DEV_DEBUG_DRIVER (dev,"sink detect, return connected\n" ); +DRM_DEV_DEBUG_DRIVER (dev,"sink detect\n" ); + +if (ctx->pdata.panel_bridge) +return connector_status_connected; -return connector_status_connected; +return ctx->hpd_status ? connector_status_connected : + connector_status_disconnected; }static int anx7625_attach_dsi (struct anx7625_data *ctx)
@@ -1376,10 +1670,12 @@ static int anx7625_bridge_attach(struct drm_bridge *bridge,return -ENODEV ; } - err =anx7625_attach_dsi (ctx); -if (err) { -DRM_DEV_ERROR (dev,"Fail to attach to dsi : %d\n" , err); -return err; +if (!ctx->pdata.is_dpi) { + err =anx7625_attach_dsi (ctx); +if (err) { +DRM_DEV_ERROR (dev,"Fail to attach to dsi : %d\n" , err); +return err; + } }if (ctx->pdata.panel_bridge) {
@@ -1478,6 +1774,10 @@ static bool anx7625_bridge_mode_fixup(struct drm_bridge *bridge,DRM_DEV_DEBUG_DRIVER (dev,"drm mode fixup set\n" ); +/* No need fixup for external monitor */ +if (!ctx->pdata.panel_bridge) +return true; + hsync = mode->hsync_end - mode->hsync_start; hfp = mode->hsync_start - mode->hdisplay; hbp = mode->htotal - mode->hsync_end;
@@ -1777,6 +2077,7 @@ static int anx7625_i2c_probe(struct i2c_client *client,if (platform->pdata.low_power_mode ==0 ) {anx7625_disable_pd_protocol (platform); +check_hdcp_support (platform);atomic_set (&platform->power_status,1 ); }
@@ -1786,8 +2087,13 @@ static int anx7625_i2c_probe(struct i2c_client *client, platform->bridge.funcs = &anx7625_bridge_funcs; platform->bridge.of_node = client->dev.of_node; - platform->bridge.ops =DRM_BRIDGE_OP_EDID |DRM_BRIDGE_OP_HPD ; - platform->bridge.type = DRM_MODE_CONNECTOR_eDP; + platform->bridge.ops =DRM_BRIDGE_OP_EDID ; +if (!platform->pdata.panel_bridge) + platform->bridge.ops |=DRM_BRIDGE_OP_HPD | +DRM_BRIDGE_OP_DETECT ; + platform->bridge.type = platform->pdata.panel_bridge ? + DRM_MODE_CONNECTOR_eDP : + DRM_MODE_CONNECTOR_DisplayPort;drm_bridge_add (&platform->bridge);DRM_DEV_DEBUG_DRIVER (dev,"probe done\n" );
drivers/gpu/drm/bridge/analogix/anx7625.h +23 -1
@@ -146,9 +146,19 @@#define I2C_ADDR_7E_FLASH_CONTROLLER 0x7E -#define FLASH_LOAD_STA 0x05 +#define FLASH_SRAM_SEL 0x00 +#define SRAM_ADDR_HIGH 0x01 +#define SRAM_ADDR_LOW 0x02 +#define SRAM_LEN_HIGH 0x03 +#define SRAM_LEN_LOW 0x04 +#define FLASH_LOAD_STA 0x05#define FLASH_LOAD_STA_CHK BIT(7) +#define FLASH_ADDR_LOW 0x0F +#define FLASH_ADDR_HIGH 0x10 +#define FLASH_LEN_HIGH 0x31 +#define FLASH_LEN_LOW 0x32 +#define XTAL_FRQ_SEL 0x3F/* bit field positions */ #define XTAL_FRQ_SEL_POS 5
@@ -340,6 +350,8 @@ enum audio_wd_len {#define EDID_TRY_CNT 3#define SUPPORT_PIXEL_CLOCK 300000 +#define MAX_REG_SIZE 64 +struct s_edid_data {int edid_block_num;u8 edid_raw_data[FOUR_BLOCK_SIZE ];
@@ -347,11 +359,19 @@ struct s_edid_data {/***************** Display End *****************/ +struct anx7625_reg_table { +int offset; +int data; +}; +struct anx7625_platform_data {struct gpio_desc *gpio_p_on;struct gpio_desc *gpio_reset;struct drm_bridge *panel_bridge;int intp_irq; +int is_dpi; +int reg_table_size; +struct anx7625_reg_table art[MAX_REG_SIZE ];u32 low_power_mode;struct device_node *mipi_host_node; };
@@ -371,6 +391,8 @@ struct anx7625_data {atomic_t power_status;int hpd_status;int hpd_high_cnt; +int hdcp_support; +int hdcp_en;/* Lock for work queue */ struct mutex lock;struct i2c_client *client;
Signature · 1 line
2.7.4
Re: [PATCH v2 2/2] drm/bridge: anx7625: add MIPI DPI input feature support
drivers/gpu/drm/bridge/analogix/anx7625.c static int wait_aux_op_finish(struct anx7625_data *ctx) · line 209
Quoted 13 lines · Xin Ji
static int
anx7625_read_ctrl_status_p0(struct anx7625_data *ctx){drivers/gpu/drm/bridge/analogix/anx7625.c +2
-2return anx7625_reg_read (ctx, ctx->i2c.rx_p0_client,AP_AUX_CTRL_STATUS );@@ -189,10 +203,64 @@ static int wait_aux_op_finish(struct anx7625_data *ctx) AP_AUX_CTRL_STATUS);if (val <0 || (val &0x0F )) {DRM_DEV_ERROR (dev,"aux status %02x\n" , val); - val = -EIO ; +return -EIO ; } -return val; +return 0 ;
This s/val/0/ change seems like a bug fix. Could you please send that as a separate patch at the start of the patch set?
Review static int wait_aux_op_finish(struct anx7625_data *ctx) · line 210
Quoted 1 line
(quoted diff) +1
-0+}
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 2/2] drm/bridge: anx7625: add MIPI DPI input feature support
Quoted 12 lines · Dan Carpenter
Quoted 11 lines · Xin Ji
static int
anx7625_read_ctrl_status_p0(struct anx7625_data *ctx){drivers/gpu/drm/bridge/analogix/anx7625.c +1
-1return anx7625_reg_read (ctx, ctx->i2c.rx_p0_client,AP_AUX_CTRL_STATUS );@@ -189,10 +203,64 @@ static int wait_aux_op_finish(struct anx7625_data *ctx) AP_AUX_CTRL_STATUS);if (val <0 || (val &0x0F )) {DRM_DEV_ERROR (dev,"aux status %02x\n" , val); - val = -EIO ; +return -EIO ; }
Quoted 5 lines
Review static int wait_aux_op_finish(struct anx7625_data *ctx) · line 209
Quoted 2 lines
(quoted diff) +1
-1- return val; + return 0;This s/val/0/ change seems like a bug fix. Could you please send that as a separate patch at the start of the patch set?
Hi Dan Carpenter, OK, I'll send this as a separate patch. Thanks,
Xin
Quoted 5 lines
Review static int wait_aux_op_finish(struct anx7625_data *ctx) · line 210
Quoted 2 lines
(quoted diff) +1
-0+}regards,
dan carpenter