Skip to contentSkip to conversation

imd: change disabled checksum tag info to debug

PATCH Applied Steffen Trumtrar 2 participants 2 messages Jan 12, 2021 – Jan 13, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imd: change disabled checksum tag info to debug

From: Steffen Trumtrar <[email protected]>

When the checksum tag is disabled the CRC is most likely invalid. And if the checksum tag is disabled and the CRC is actually invalid the user doesn't care for it anyway.

This information only confuses the user so make it a debug message.

---
 common/imd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/imd.c +1 -1
index ef9eff876b..aff3b00b6b 100644
@@ -406,7 +406,7 @@ int imd_verify_crc32(void *buf, size_t size)
 			       *p, crc);
 			return -EILSEQ;
 		} else if (*p != crc && !imd_crc32_is_valid(*flags)) {
-			printf("CRC: is invalid, but the checksum tag is not enabled\n");
+			debug("CRC: is invalid, but the checksum tag is not enabled\n");
 			return -EINVAL;
 		} else {
 			printf("CRC: valid\n");
Signature · 7 lines
2.20.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Applied
#1 lore raw
Quoted 6 lines · Steffen Trumtrar

From: Steffen Trumtrar <[email protected]>

When the checksum tag is disabled the CRC is most likely invalid. And if the checksum tag is disabled and the CRC is actually invalid the user doesn't care for it anyway.

Quoted 6 lines

This information only confuses the user so make it a debug message.

---
 common/imd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks

Sascha

Quoted 23 lines
common/imd.c +1 -1
index ef9eff876b..aff3b00b6b 100644
@@ -406,7 +406,7 @@ int imd_verify_crc32(void *buf, size_t size)
 			       *p, crc);
 			return -EILSEQ;
 		} else if (*p != crc && !imd_crc32_is_valid(*flags)) {
-			printf("CRC: is invalid, but the checksum tag is not enabled\n");
+			debug("CRC: is invalid, but the checksum tag is not enabled\n");
 			return -EINVAL;
 		} else {
 			printf("CRC: valid\n");
Signature · 7 lines
2.20.1


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Signature · 9 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox