regulator: mt6358: Add OF match table
Subsystems (2)
PATCH v3 1/2 regulator: mt6358: Add OF match table
From: Matthias Brugger <[email protected]>
The binding documentation mentions that a compatible is required for the MT6358 device node. But the driver does not provide a OF match table. This way auto-loading is broken as the MFD driver that registers the device has a .of_compatible set which makes the platform .uevent callback report a OF modalias, but that's not in the module.
---
Changes in v3:
- drop mt6360 patch
Changes in v2:
- check for CONFIG_OF
- add Fixes tag
drivers/regulator/mt6358-regulator.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/regulator/mt6358-regulator.c +9 -0
@@ -534,9 +534,18 @@ static const struct platform_device_id mt6358_platform_ids[] = { };MODULE_DEVICE_TABLE (platform, mt6358_platform_ids); +#ifdef CONFIG_OF +static const struct of_device_id mt6358_of_match[] = { + { .compatible ="mediatek,mt6358-regulator" , }, + {/* sentinel */ }, +}; +MODULE_DEVICE_TABLE (of, mt6358_of_match); +#endif +static struct platform_driver mt6358_regulator_driver = { .driver = { .name ="mt6358-regulator" , + .of_match_table =of_match_ptr (mt6358_of_match), }, .probe = mt6358_regulator_probe, .id_table = mt6358_platform_ids,
Signature · 7 lines
2.29.2 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
PATCH v3 2/2 regulator: mt6323: Add OF match table
From: Matthias Brugger <[email protected]>
The binding documentation mentions that a compatible is required for the MT6323 device node. But the driver does not provide a OF match table. This way auto-loading is broken as the MFD driver that registers the device has a .of_compatible set which makes the platform .uevent callback report a OF modalias, but that's not in the module.
---
Changes in v3: None
Changes in v2:
- check for CONFIG_OF
- add Fixes tag
drivers/regulator/mt6323-regulator.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/regulator/mt6323-regulator.c +9 -0
@@ -406,9 +406,18 @@ static const struct platform_device_id mt6323_platform_ids[] = { };MODULE_DEVICE_TABLE (platform, mt6323_platform_ids); +#ifdef CONFIG_OF +static const struct of_device_id mt6323_of_match[] = { + { .compatible ="mediatek,mt6323-regulator" , }, + {/* sentinel */ }, +}; +MODULE_DEVICE_TABLE (of, mt6323_of_match); +#endif +static struct platform_driver mt6323_regulator_driver = { .driver = { .name ="mt6323-regulator" , + .of_match_table =of_match_ptr (mt6323_of_match), }, .probe = mt6323_regulator_probe, .id_table = mt6323_platform_ids,
Signature · 7 lines
2.29.2 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
Mark Brown
maintainerQuoted 5 lines · On Tue, Jan 12, 2021 at 11:06:57AM +0100, [email protected] wrote:
The binding documentation mentions that a compatible is required for the MT6358 device node. But the driver does not provide a OF match table. This way auto-loading is broken as the MFD driver that registers the device has a .of_compatible set which makes the platform .uevent callback report a OF modalias, but that's not in the module.
As previously discussed it'd be better to fix the binding document to deprecate the requirement for the compatible and remove the usage from the MFD.
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek