Skip to contentSkip to conversation

package/dotnet-sdk: new package

PATCH New Raul Hidalgo Caballero 2 participants 3 messages Jan 12, 2021 – Jan 13, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/dotnet-sdk: new package

---
 DEVELOPERS                                    |  5 ++++
 package/Config.in.host                        |  1 +
 package/dotnet-sdk/dotnet-sdk.hash            |  3 ++
 package/dotnet-sdk/dotnet-sdk.mk              | 20 +++++++++++++
 package/dotnet/Config.in.host                 | 15 ++++++++++
 .../testing/tests/package/test_dotnet_sdk.py  | 28 +++++++++++++++++++
 6 files changed, 72 insertions(+)
 create mode 100644 package/dotnet-sdk/dotnet-sdk.hash
 create mode 100644 package/dotnet-sdk/dotnet-sdk.mk
 create mode 100644 package/dotnet/Config.in.host
 create mode 100644 support/testing/tests/package/test_dotnet_sdk.py
DEVELOPERS +5 -0
index 05b509c9c4..ea85f7c9c3 100644
@@ -2206,6 +2206,11 @@ F:       package/python-botocore/
 F:     package/python-jmespath/
 F:     package/python-s3transfer/
 
+N:     Raul Hidalgo Caballero <[email protected]>
+F:     package/dotnet/
+F:     package/dotnet-sdk/
+F:     support/testing/tests/package/test_dotnet_sdk.py
+
 N:     Refik Tuzakli <[email protected]>
 F:     package/freescale-imx/
 F:     package/paho-mqtt-cpp/
package/Config.in.host +1 -0
index ba6a68c728..16f0e9f690 100644
@@ -16,6 +16,7 @@ menu "Host utilities"
        source "package/dfu-util/Config.in.host"
        source "package/dos2unix/Config.in.host"
        source "package/dosfstools/Config.in.host"
+       source "package/dotnet/Config.in.host"
        source "package/doxygen/Config.in.host"
        source "package/dtc/Config.in.host"
        source "package/e2fsprogs/Config.in.host"
(quoted diff) +0 -0

b/package/dotnet-sdk/dotnet-sdk.hash
new file mode 100644
index 0000000000..a3016b2e49

package/dotnet-sdk/dotnet-sdk.hash new file +1 -0
@@ -0,0 +1,3 @@
+sha256  cfc21f5e8bd655ae997eec916138b707b1d290b83272c02a95c9f821b8c87310

LICENSE.txt
+sha256 01564961f8ca9744d0ecc5d3e72d7c1659df95898f3a077fd9140fd4023f3579
ThirdPartyNotices.txt
+sha256 23df1eca7eb1302dfb10f4edce7edf7150e57698576f61b2dcb777c833cbd80c
dotnet-sdk-5.0.101-linux-x64.tar.gz

package/dotnet-sdk/ renamed from package/dotnet-sdk/dotnet-sdk.mk +0 -0

dotnet-sdk.mk
new file mode 100644
index 0000000000..133b39b3f5

package/dotnet-sdk/dotnet-sdk.mk new file +8 -0
@@ -0,0 +1,20 @@
+################################################################################
+#
+# dotnet-sdk
+#
+################################################################################
+
+HOST_DOTNET_SDK_VERSION = 5.0.101
+HOST_DOTNET_SDK_SITE =

https://dotnetcli.azureedge.net/dotnet/Sdk/$(HOST_DOTNET_SDK_VERSION)
+HOST_DOTNET_SDK_SOURCE = dotnet-sdk-$(HOST_DOTNET_SDK_VERSION)-$(call qstrip,$(BR2_PACKAGE_HOST_DOTNET_RID)).tar.gz +HOST_DOTNET_SDK_LICENSE = MIT +HOST_DOTNET_SDK_LICENSE_FILES = LICENSE.txt ThirdPartyNotices.txt +
+define HOST_DOTNET_SDK_INSTALL_CMDS

+       mkdir -p $(HOST_DIR)/usr/share/dotnet/
+       cp -dpfr $(@D)/* $(HOST_DIR)/usr/share/dotnet/
+       mkdir -p $(HOST_DIR)/usr/bin/
+       ln -s ../share/dotnet/dotnet $(HOST_DIR)/usr/bin/dotnet

+endef
+
+$(eval $(host-generic-package))

package/dotnet/Config.in.host new file +15 -0
new file mode 100644
index 0000000000..90b477a6a1
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_HOST_DOTNET_ARCH_SUPPORTS
+       bool
+       default y if BR2_HOSTARCH = "x86_64"
+
+config BR2_PACKAGE_HOST_DOTNET_RID
+       string
+       default "linux-x64" if BR2_HOSTARCH = "x86_64"
+
+config BR2_PACKAGE_HOST_DOTNET_SDK
+       bool "host dotnet-sdk"
+       depends on BR2_PACKAGE_HOST_DOTNET_ARCH_SUPPORTS
+       help
+               Dotnet SDK
+
+               https://dotnet.microsoft.com/
(quoted diff) +0 -0

b/support/testing/tests/package/test_dotnet_sdk.py new file mode 100644
index 0000000000..288e873597

support/testing/tests/package/test_dotnet_sdk.py new file +27 -0
@@ -0,0 +1,28 @@
+import os
+import tempfile
+import subprocess
+import shutil
+
+import infra.basetest
+
+
+class TestDotnetSdkBase(infra.basetest.BRTest):
+
+    config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
+        """
+        BR2_TARGET_ROOTFS_CPIO=y
+        """
+
+class TestHostDotnetSdk(TestDotnetSdkBase):
+    config = TestDotnetSdkBase.config + \
+        """
+        BR2_PACKAGE_HOST_DOTNET_SDK=y
+        """
+
+    def test_run(self):
+        env = os.environ.copy()
+        hostdir = os.path.join(self.builddir, 'host')
+        dotnet = os.path.join(hostdir, 'usr', 'bin', 'dotnet')
+        cmd = [dotnet, '--version']
+        exit_code = subprocess.call(cmd, stdout=self.b.logfile,

stderr=self.b.logfile, env=env)
+ self.assertEqual(exit_code, 0)
--
2.25.1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210112/a7ee6e4d/attachment.html>

#1 lore raw

PATCH 1/1 package/dotnet-sdk: new package

Hello Raul,

Quoted 7 lines · On Tue, 12 Jan 2021 16:07:23 +0100 Raul Hidalgo Caballero <[email protected]>…
---
 DEVELOPERS                                    |  5 ++++
 package/Config.in.host                        |  1 +
 package/dotnet-sdk/dotnet-sdk.hash            |  3 ++
 package/dotnet-sdk/dotnet-sdk.mk              | 20 +++++++++++++
 package/dotnet/Config.in.host                 | 15 ++++++++++

Why is this Config.in.host in package/dotnet/ and not package/dotnet-sdk/ ?

package/dotnet-sdk/dotnet-sdk.hash

Quoted 13 lines
package/dotnet-sdk/dotnet-sdk.hash new file +3 -0
new file mode 100644
index 0000000000..a3016b2e49
@@ -0,0 +1,3 @@
+sha256  cfc21f5e8bd655ae997eec916138b707b1d290b83272c02a95c9f821b8c87310
 LICENSE.txt
+sha256  01564961f8ca9744d0ecc5d3e72d7c1659df95898f3a077fd9140fd4023f3579
 ThirdPartyNotices.txt
+sha256  23df1eca7eb1302dfb10f4edce7edf7150e57698576f61b2dcb777c833cbd80c
 dotnet-sdk-5.0.101-linux-x64.tar.gz

Note: your patch is line-wrapped. Could you use "git send-email" to send it ?

Quoted 9 lines
package/dotnet/Config.in.host new file +3 -0
new file mode 100644
index 0000000000..90b477a6a1
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_HOST_DOTNET_ARCH_SUPPORTS
+       bool
+       default y if BR2_HOSTARCH = "x86_64"

package/dotnet/Config.in.host line 13

Quoted 10 lines
package/dotnet/Config.in.host new file +10 -0
+
+config BR2_PACKAGE_HOST_DOTNET_RID
+       string
+       default "linux-x64" if BR2_HOSTARCH = "x86_64"
+
+config BR2_PACKAGE_HOST_DOTNET_SDK
+       bool "host dotnet-sdk"
+       depends on BR2_PACKAGE_HOST_DOTNET_ARCH_SUPPORTS
+       help
+               Dotnet SDK

This is a bit short :-)

package/dotnet/Config.in.host line 15

Quoted 2 lines
package/dotnet/Config.in.host new file +2 -0
+
+               https://dotnet.microsoft.com/

The indentation for the help text is one tab + two spaces. You can run "make check-package" to find this kind of coding style details.

Quoted 1 line

+class TestDotnetSdkBase(infra.basetest.BRTest):

You don't need this "Base" class, since there's only one subclass using it.

package/dotnet/Config.in.host

Quoted 7 lines
package/dotnet/Config.in.host new file +7 -0
+
+    config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
+        """
+        BR2_TARGET_ROOTFS_CPIO=y
+        """
+
+class TestHostDotnetSdk(TestDotnetSdkBase):

Just make this class inherit from infra.basetest.BRTest directly.

package/dotnet/Config.in.host

Quoted 4 lines
package/dotnet/Config.in.host new file +4 -0
+    config = TestDotnetSdkBase.config + \
+        """
+        BR2_PACKAGE_HOST_DOTNET_SDK=y
+        """

use:

	config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
		"""
		BR2_PACKAGE_HOST_DOTNET_SDK=y
		BR2_TARGET_ROOTFS_CPIO=y
		"""

package/dotnet/Config.in.host

Quoted 2 lines
package/dotnet/Config.in.host new file +2 -0
+    def test_run(self):
+        env = os.environ.copy()

Why do we have to do this ? You don't tweak any environment variable.

Quoted 8 lines
package/dotnet/Config.in.host new file +4 -0
+        hostdir = os.path.join(self.builddir, 'host')
+        dotnet = os.path.join(hostdir, 'usr', 'bin', 'dotnet')
+        cmd = [dotnet, '--version']
+        exit_code = subprocess.call(cmd, stdout=self.b.logfile,

stderr=self.b.logfile, env=env)
+ self.assertEqual(exit_code, 0)
--
2.25.1

Otherwise, looks good. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/dotnet-sdk: new package

I Thomas,

Regarding the Config.in.host being in the dotnet package.
In the future, I expect to add: dotnet-runtime and dotnet-aspnet. They all share most of the configuration, like the RID (Runtime Identifier, something like the target triplet) and end exposing the "dotnet" command. Basically, dotnet-runtime is a subset of dotnet-aspnet, and dotnet-aspnet is a subset of dotnet-sdk.
I took as a reference the rust packages.

Regarding the tests, I expect to add more tests in the future while I add support for having the dotnet-sdk as a target package.
Also I expect to add more tests for a bit more complex cases. So I would like to left the Tests as they are, except for the environment things that you are right. I'd just took the rust tests as a reference and I left that env variable.

Quoted 104 lines · Thomas Petazzoni

Hello Raul,

Quoted 7 lines · On Tue, 12 Jan 2021 16:07:23 +0100 Raul Hidalgo Caballero <[email protected]>…
---
 DEVELOPERS                                    |  5 ++++
 package/Config.in.host                        |  1 +
 package/dotnet-sdk/dotnet-sdk.hash            |  3 ++
 package/dotnet-sdk/dotnet-sdk.mk              | 20 +++++++++++++
 package/dotnet/Config.in.host                 | 15 ++++++++++

Why is this Config.in.host in package/dotnet/ and not package/dotnet-sdk/ ?

package/dotnet-sdk/dotnet-sdk.hash

Quoted 13 lines
package/dotnet-sdk/dotnet-sdk.hash new file +3 -0
new file mode 100644
index 0000000000..a3016b2e49
@@ -0,0 +1,3 @@
+sha256  cfc21f5e8bd655ae997eec916138b707b1d290b83272c02a95c9f821b8c87310
 LICENSE.txt
+sha256  01564961f8ca9744d0ecc5d3e72d7c1659df95898f3a077fd9140fd4023f3579
 ThirdPartyNotices.txt
+sha256  23df1eca7eb1302dfb10f4edce7edf7150e57698576f61b2dcb777c833cbd80c
 dotnet-sdk-5.0.101-linux-x64.tar.gz

Note: your patch is line-wrapped. Could you use "git send-email" to send it ?

Review

Quoted 1 line
(quoted diff) +0 -0

b/package/dotnet/Config.in.host

Quoted 8 lines

new file mode 100644
index 0000000000..90b477a6a1

package/dotnet/Config.in.host new file +3 -0
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_HOST_DOTNET_ARCH_SUPPORTS
+       bool
+       default y if BR2_HOSTARCH = "x86_64"

package/dotnet/Config.in.host line 13

Quoted 10 lines
package/dotnet/Config.in.host new file +10 -0
+
+config BR2_PACKAGE_HOST_DOTNET_RID
+       string
+       default "linux-x64" if BR2_HOSTARCH = "x86_64"
+
+config BR2_PACKAGE_HOST_DOTNET_SDK
+       bool "host dotnet-sdk"
+       depends on BR2_PACKAGE_HOST_DOTNET_ARCH_SUPPORTS
+       help
+               Dotnet SDK

This is a bit short :-)

package/dotnet/Config.in.host line 15

Quoted 2 lines
package/dotnet/Config.in.host new file +2 -0
+
+               https://dotnet.microsoft.com/

The indentation for the help text is one tab + two spaces. You can run "make check-package" to find this kind of coding style details.

Quoted 1 line

+class TestDotnetSdkBase(infra.basetest.BRTest):

You don't need this "Base" class, since there's only one subclass using it.

package/dotnet/Config.in.host

Quoted 7 lines
package/dotnet/Config.in.host new file +7 -0
+
+    config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
+        """
+        BR2_TARGET_ROOTFS_CPIO=y
+        """
+
+class TestHostDotnetSdk(TestDotnetSdkBase):

Just make this class inherit from infra.basetest.BRTest directly.

package/dotnet/Config.in.host

Quoted 4 lines
package/dotnet/Config.in.host new file +4 -0
+    config = TestDotnetSdkBase.config + \
+        """
+        BR2_PACKAGE_HOST_DOTNET_SDK=y
+        """

use:

        config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
                """
                BR2_PACKAGE_HOST_DOTNET_SDK=y
                BR2_TARGET_ROOTFS_CPIO=y
                """

package/dotnet/Config.in.host

Quoted 2 lines
package/dotnet/Config.in.host new file +2 -0
+    def test_run(self):
+        env = os.environ.copy()

Why do we have to do this ? You don't tweak any environment variable.

Quoted 8 lines
package/dotnet/Config.in.host new file +4 -0
+        hostdir = os.path.join(self.builddir, 'host')
+        dotnet = os.path.join(hostdir, 'usr', 'bin', 'dotnet')
+        cmd = [dotnet, '--version']
+        exit_code = subprocess.call(cmd, stdout=self.b.logfile,

stderr=self.b.logfile, env=env)
+ self.assertEqual(exit_code, 0)
--
2.25.1

Quoted 8 lines

Otherwise, looks good. Thanks!

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210113/7d0e13b1/attachment.html>