net: ipa: add config dependency on QCOM_SMEM
Subsystems (3)
PATCH 1/1 net: ipa: add config dependency on QCOM_SMEM
The IPA driver depends on some SMEM functionality (qcom_smem_init(), qcom_smem_alloc(), and qcom_smem_virt_to_phys()), but this is not reflected in the configuration dependencies. Add a dependency on QCOM_SMEM to avoid attempts to build the IPA driver without SMEM. This avoids a link error for certain configurations.
--- drivers/net/ipa/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ipa/Kconfig +1 -1
@@ -1,6 +1,6 @@ config QCOM_IPA tristate "Qualcomm IPA support" - depends on 64BIT && NET + depends on 64BIT && NET && QCOM_SMEM depends on ARCH_QCOM || COMPILE_TEST depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST) select QCOM_MDT_LOADER if ARCH_QCOM
Signature · 1 line
2.20.1
Quoted 9 lines · Alex Elder
The IPA driver depends on some SMEM functionality (
qcom_smem_init(),qcom_smem_alloc(), andqcom_smem_virt_to_phys()), but this is not reflected in the configuration dependencies. Add a dependency onQCOM_SMEMto avoid attempts to build the IPA driver without SMEM. This avoids a link error for certain configurations.Reported-by Randy Dunlap <[email protected]>Fixes 38a4066f593c5 ("net: ipa: support COMPILE_TEST")Signed-off-by Alex Elder <[email protected]>
Thanks.
Quoted 17 lines
--- drivers/net/ipa/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/ipa/Kconfig +1
-1@@ -1,6 +1,6 @@ config QCOM_IPA tristate "Qualcomm IPA support" - depends on 64BIT && NET + depends on 64BIT && NET && QCOM_SMEM depends on ARCH_QCOM || COMPILE_TEST depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST) select QCOM_MDT_LOADER if ARCH_QCOM
Signature · 1 line
~Randy
Quoted 9 lines · Alex Elder
The IPA driver depends on some SMEM functionality (
qcom_smem_init(),qcom_smem_alloc(), andqcom_smem_virt_to_phys()), but this is not reflected in the configuration dependencies. Add a dependency onQCOM_SMEMto avoid attempts to build the IPA driver without SMEM. This avoids a link error for certain configurations.Reported-by Randy Dunlap <[email protected]>Fixes 38a4066f593c5 ("net: ipa: support COMPILE_TEST")Signed-off-by Alex Elder <[email protected]>
Regards,
Bjorn
Quoted 19 lines
--- drivers/net/ipa/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/ipa/Kconfig +1
-1@@ -1,6 +1,6 @@ config QCOM_IPA tristate "Qualcomm IPA support" - depends on 64BIT && NET + depends on 64BIT && NET && QCOM_SMEM depends on ARCH_QCOM || COMPILE_TEST depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST) select QCOM_MDT_LOADER if ARCH_QCOMSignature · 1 line
2.20.1
This patch was applied to netdev/net-next.git (refs/heads/master):
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
Quoted 11 lines · On Tue, 12 Jan 2021 13:21:34 -0600 you wrote:
The IPA driver depends on some SMEM functionality (
qcom_smem_init(),qcom_smem_alloc(), andqcom_smem_virt_to_phys()), but this is not reflected in the configuration dependencies. Add a dependency onQCOM_SMEMto avoid attempts to build the IPA driver without SMEM. This avoids a link error for certain configurations.Reported-by Randy Dunlap <[email protected]>Fixes 38a4066f593c5 ("net: ipa: support COMPILE_TEST")Signed-off-by Alex Elder <[email protected]>[...]
Here is the summary with links:
- [net-next] net: ipa: add config dependency on QCOM_SMEM
https://git.kernel.org/netdev/net-next/c/46e05e1df628
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html