Skip to contentSkip to conversation

rtw88: 8723de: adjust the LTR setting

PATCH In review Ping-Ke Shih 2 participants 2 messages Jan 13, 2021 – Jan 26, 2021 Realtek wireless driver (rtw88)

lore
Share & tools
lore

Ping-Ke Shih

author maintainer
#0 lore raw

PATCH 1/1 rtw88: 8723de: adjust the LTR setting

From: Chin-Yen Lee <[email protected]>

The LTR mechanism enables PCIE Endpoints to report the service latency requirements and CPU will enter appropriate sleep state to save power based on the LTR value.

8723de provides two registers to config the LTR, and the original setting is too short for CPU to ente sleep state. The patch adjust the LTR setting.

---
 drivers/net/wireless/realtek/rtw88/rtw8723d.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/realtek/rtw88/rtw8723d.c +2 -2
index 9268ea8b6dda..3fdbaf7302c5 100644
@@ -60,8 +60,8 @@ static const struct rtw_hw_reg rtw8723d_txagc[] = {
 #define WLAN_MAX_AGG_NR		0x0A
 #define WLAN_AMPDU_MAX_TIME	0x1C
 #define WLAN_ANT_SEL		0x82
-#define WLAN_LTR_IDLE_LAT	0x883C883C
-#define WLAN_LTR_ACT_LAT	0x880B880B
+#define WLAN_LTR_IDLE_LAT	0x90039003
+#define WLAN_LTR_ACT_LAT	0x883c883c
 #define WLAN_LTR_CTRL1		0xCB004010
 #define WLAN_LTR_CTRL2		0x01233425
 
Signature · 1 line
2.21.0
#1 lore raw
Quoted 11 lines · Ping-Ke Shih

From: Chin-Yen Lee <[email protected]>

The LTR mechanism enables PCIE Endpoints to report the service latency requirements and CPU will enter appropriate sleep state to save power based on the LTR value.

8723de provides two registers to config the LTR, and the original setting is too short for CPU to ente sleep state. The patch adjust the LTR setting.

Patch applied to wireless-drivers-next.git, thanks.

6598f32d9dfe rtw88: 8723de: adjust the LTR setting

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches