arch: kernel: cpu: x86/resctrl: Takes a letter away and append a colon to match below struct member
Subsystems (2)
PATCH v4 1/1 arch: kernel: cpu: x86/resctrl: Takes a letter away and append a colon to match below struct member
s/kernlfs/kernfs/
s/@mon_data_kn/@mon_data_kn:/
---
Changes from V3: Fix the subject line typo stuc to struct and mention cpu architecture
arch/x86/kernel/cpu/resctrl/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/resctrl/internal.h +1 -1
@@ -142,7 +142,7 @@ enum rdtgrp_mode {/** * struct mongroup - store mon group's data in resctrl fs. -* @mon_data_kn kernlfs node for the mon_data directory +* @mon_data_kn: kernfs node for the mon_data directory * @parent: parent rdtgrp * @crdtgrp_list: child rdtgroup node list * @rmid: rmid for this rdtgroup
--
2.20.1
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 12 lines · Gustavo A. R. Silva
Quoted 6 lines · Bhaskar Chowdhury
s/kernlfs/kernfs/
s/@mon_data_kn/@mon_data_kn:/Signed-off-by Bhaskar Chowdhury <[email protected]>---
Changes from V3: Fix the subject line typo stuc to struct and mention cpu architecture...and what changed from v1 to v2 and from v2 to v3?
Gustavo, it seems you are not following up properly ....could you please put little more effort for know it????
There were mails....pls scan and read ..
Quoted 3 lines
Bhaskar
--
Gustavo
Quoted 11 lines · Bhaskar Chowdhury
Quoted 10 lines · Gustavo A. R. Silva
Quoted 6 lines · Bhaskar Chowdhury
s/kernlfs/kernfs/
s/@mon_data_kn/@mon_data_kn:/Signed-off-by Bhaskar Chowdhury <[email protected]>---
Changes from V3: Fix the subject line typo stuc to struct and mention cpu architecture
Quoted 7 lines
Quoted 2 lines
...and what changed from v1 to v2 and from v2 to v3?
Gustavo, it seems you are not following up properly ....could you please put little more effort for know it????
There were mails....pls scan and read ..
All of these version change logs should be in this patch, under the "---" line.
Signature · 3 lines
~Randy You can't do anything without having to do something else first. -- Belefant's Law
Quoted 15 lines · Randy Dunlap
Quoted 14 lines · Bhaskar Chowdhury
Quoted 12 lines · Gustavo A. R. Silva
Quoted 6 lines · Bhaskar Chowdhury
s/kernlfs/kernfs/
s/@mon_data_kn/@mon_data_kn:/Signed-off-by Bhaskar Chowdhury <[email protected]>---
Changes from V3: Fix the subject line typo stuc to struct and mention cpu architecture...and what changed from v1 to v2 and from v2 to v3?
Quoted 8 lines
Quoted 4 lines
Gustavo, it seems you are not following up properly ....could you please put little more effort for know it????
There were mails....pls scan and read ..
All of these version change logs should be in this patch, under the "---" line.
Point noted for future reference.Thanks.
Quoted 5 lines
--
~Randy
You can't do anything without having to do something else first. -- Belefant's Law
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 20 lines · Gustavo A. R. Silva
Quoted 17 lines · Bhaskar Chowdhury
Quoted 12 lines · Gustavo A. R. Silva
Quoted 6 lines · Bhaskar Chowdhury
s/kernlfs/kernfs/
s/@mon_data_kn/@mon_data_kn:/Signed-off-by Bhaskar Chowdhury <[email protected]>---
Changes from V3: Fix the subject line typo stuc to struct and mention cpu architecture...and what changed from v1 to v2 and from v2 to v3?
Gustavo, it seems you are not following up properly ....could you please put little more effort for know it????
Quoted 7 lines
Quoted 1 line
There were mails....pls scan and read ..
This is my point... this is exactly what maintainers and reviewers should not do: to go back and read emails, trying to understand why are you sending a version N of your patch, because you didn't include all the previous change logs in the most recent version of your patch.
Thanks, will follow what you advice.
Quoted 2 lines
--
Gustavo
Reinette Chatre
maintainerHi Bhaskar,
The prefix in the subject line should be "x86/resctrl:" only. The subject line could be (also taking liberty to shorten it here):
x86/resctrl: Fix typo and append a colon to match struct member
I would like to repeat my suggestion made in response to your previous version, especially if you are planning cleanup in many areas of the kernel: Use "git log" to take a look at the custom of patches in the area you are contributing to. While the kernel may appear to be a single code base there can be different customs in the various subsystems.
Quoted 23 lines · Bhaskar Chowdhury
s/kernlfs/kernfs/
s/@mon_data_kn/@mon_data_kn:/Signed-off-by Bhaskar Chowdhury <[email protected]>---
Changes from V3: Fix the subject line typo stuc to struct and mention cpu architecturearch/x86/kernel/cpu/resctrl/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/x86/kernel/cpu/resctrl/internal.h +1
-2@@ -142,7 +142,7 @@ enum rdtgrp_mode {/** * struct mongroup - store mon group's data in resctrl fs. -* @mon_data_kn kernlfs node for the mon_data directory +* @mon_data_kn: kernfs node for the mon_data directory * @parent: parent rdtgrp * @crdtgrp_list: child rdtgroup node list * @rmid: rmid for this rdtgroup --
Quoted 2 lines
2.20.1
Reinette
Quoted 2 lines · Bhaskar Chowdhury
s/kernlfs/kernfs/
s/@mon_data_kn/@mon_data_kn:/
May change the message to describe the problems like:
Fix typo "kernlfs" and add missing ":" to match with other comments.
Quoted 5 lines
Signed-off-by Bhaskar Chowdhury <[email protected]>---
Changes from V3: Fix the subject line typo stuc to struct and mention cpu architecture
Please read Documentation/process/submitting-patches.rst. It talks about the subject, description of problem, changelog, etc for submitting a patch.
Thanks.
-Fenghua