drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static
Subsystems (3)
PATCH 1/1 drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static
kernel test robot throws below warnings ->
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
warning: no previous prototype for 'vangogh_clk_dpm_is_enabled' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
warning: no previous prototype for function 'vangogh_clk_dpm_is_enabled' [-Wmissing-prototypes]
Mark vangogh_clk_dpm_is_enabled() as static.
--- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +1 -1
@@ -610,7 +610,7 @@ static int vangogh_get_profiling_clk_mask(struct smu_context *smu,return 0 ; } -bool vangogh_clk_dpm_is_enabled (struct smu_context *smu, +static bool vangogh_clk_dpm_is_enabled (struct smu_context *smu,enum smu_clk_type clk_type) {enum smu_feature_mask feature_id =0 ;
Signature · 6 lines
1.9.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Alex Deucher
AppliedQuoted 10 lines · Souptick Joarder
kernel test robot throws below warnings ->
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
warning: no previous prototype for 'vangogh_clk_dpm_is_enabled' [-Wmissing-prototypes]drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
warning: no previous prototype for function 'vangogh_clk_dpm_is_enabled' [-Wmissing-prototypes]
Quoted 4 lines
Mark
vangogh_clk_dpm_is_enabled()as static.Reported-by kernel test robot <[email protected]>Signed-off-by Souptick Joarder <[email protected]>
Applied. Thanks!
Alex
Quoted 20 lines
--- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +1
-2@@ -610,7 +610,7 @@ static int vangogh_get_profiling_clk_mask(struct smu_context *smu,return 0 ; } -bool vangogh_clk_dpm_is_enabled (struct smu_context *smu, +static bool vangogh_clk_dpm_is_enabled (struct smu_context *smu,enum smu_clk_type clk_type) {enum smu_feature_mask feature_id =0 ; --1.9.1
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 22 lines · Souptick Joarder
kernel test robot throws below warnings ->
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
warning: no previous prototype for 'vangogh_clk_dpm_is_enabled' [-Wmissing-prototypes]drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
warning: no previous prototype for function 'vangogh_clk_dpm_is_enabled' [-Wmissing-prototypes]Mark
vangogh_clk_dpm_is_enabled()as static.Reported-by kernel test robot <[email protected]>Signed-off-by Souptick Joarder <[email protected]>--- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +0
-0
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c static int vangogh_get_profiling_clk_mask(struct smu_context *smu, · line 614
Quoted 6 lines
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +1
-1@@ -610,7 +610,7 @@ static int vangogh_get_profiling_clk_mask(struct smu_context *smu,return 0 ; } -bool vangogh_clk_dpm_is_enabled (struct smu_context *smu, +static bool vangogh_clk_dpm_is_enabled (struct smu_context *smu,enum smu_clk_type clk_type)
Ah, I have another patch which will use this function in another file.
Thanks,
Ray
Quoted 5 lines
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +0
-0{enum smu_feature_mask feature_id =0 ;Signature · 1 line
1.9.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 27 lines · Huang Rui
Quoted 25 lines · Souptick Joarder
kernel test robot throws below warnings ->
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
warning: no previous prototype for 'vangogh_clk_dpm_is_enabled' [-Wmissing-prototypes]drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
warning: no previous prototype for function 'vangogh_clk_dpm_is_enabled' [-Wmissing-prototypes]Mark
vangogh_clk_dpm_is_enabled()as static.Reported-by kernel test robot <[email protected]>Signed-off-by Souptick Joarder <[email protected]>--- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +0
-0@@ -610,7 +610,7 @@ static int vangogh_get_profiling_clk_mask(struct smu_context *smu,return 0 ; }
Quoted 6 lines
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c static int vangogh_get_profiling_clk_mask(struct smu_context *smu, · line 614
Quoted 3 lines
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +1
-1-bool vangogh_clk_dpm_is_enabled (struct smu_context *smu, +static bool vangogh_clk_dpm_is_enabled (struct smu_context *smu,enum smu_clk_type clk_type)Ah, I have another patch which will use this function in another file.
I can drop it if you plan to land those patches soon.
Alex
Quoted 8 lines
Thanks,
RayQuoted 5 lines
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +0
-1{enum smu_feature_mask feature_id =0 ; --1.9.1
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 28 lines · Alex Deucher
Quoted 27 lines · Huang Rui
Quoted 25 lines · Souptick Joarder
kernel test robot throws below warnings ->
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
warning: no previous prototype for 'vangogh_clk_dpm_is_enabled' [-Wmissing-prototypes]drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
warning: no previous prototype for function 'vangogh_clk_dpm_is_enabled' [-Wmissing-prototypes]Mark
vangogh_clk_dpm_is_enabled()as static.Reported-by kernel test robot <[email protected]>Signed-off-by Souptick Joarder <[email protected]>--- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +0
-0@@ -610,7 +610,7 @@ static int vangogh_get_profiling_clk_mask(struct smu_context *smu,return 0 ; }
Quoted 8 lines
Quoted 6 lines
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c static int vangogh_get_profiling_clk_mask(struct smu_context *smu, · line 614
Quoted 3 lines
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +1
-1-bool vangogh_clk_dpm_is_enabled (struct smu_context *smu, +static bool vangogh_clk_dpm_is_enabled (struct smu_context *smu,enum smu_clk_type clk_type)Ah, I have another patch which will use this function in another file.
I can drop it if you plan to land those patches soon.
Thanks Alex. Yes, I will upload them after verify them on the new firmware today.
Thanks,
Ray
Quoted 16 lines
Alex
Quoted 12 lines
Thanks,
RayQuoted 5 lines
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +0
-1{enum smu_feature_mask feature_id =0 ; --1.9.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Cray.huang%40amd.com%7C19fce6891f2d4f6df7de08d8b768c8a9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637461007972405505%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=v2JGTkklMHOE2hN1s4dYZ1hT7ctLeUHpwkpn1M3nyi8%3D&reserved=0
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Huang Rui
Reviewed-byQuoted 36 lines · Huang Rui
Quoted 35 lines · Alex Deucher
Quoted 33 lines · Huang Rui
Quoted 22 lines · Souptick Joarder
kernel test robot throws below warnings ->
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
warning: no previous prototype for 'vangogh_clk_dpm_is_enabled' [-Wmissing-prototypes]drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
warning: no previous prototype for function 'vangogh_clk_dpm_is_enabled' [-Wmissing-prototypes]Mark
vangogh_clk_dpm_is_enabled()as static.Reported-by kernel test robot <[email protected]>Signed-off-by Souptick Joarder <[email protected]>--- drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +0
-0drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c static int vangogh_get_profiling_clk_mask(struct smu_context *smu, · line 614
Quoted 6 lines
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +1
-1@@ -610,7 +610,7 @@ static int vangogh_get_profiling_clk_mask(struct smu_context *smu,return 0 ; } -bool vangogh_clk_dpm_is_enabled (struct smu_context *smu, +static bool vangogh_clk_dpm_is_enabled (struct smu_context *smu,enum smu_clk_type clk_type)Ah, I have another patch which will use this function in another file.
Quoted 4 lines
Quoted 1 line
I can drop it if you plan to land those patches soon.
Thanks Alex. Yes, I will upload them after verify them on the new firmware today.
Sorry Alex, I miss read the function name as "cclk_dpm". This patch is good, please go forward to apply it.
Thanks,
Ray
Quoted 20 lines
Thanks,
RayQuoted 16 lines
Alex
Quoted 12 lines
Thanks,
RayQuoted 5 lines
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c +0
-1{enum smu_feature_mask feature_id =0 ; --1.9.1
_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Cray.huang%40amd.com%7C19fce6891f2d4f6df7de08d8b768c8a9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637461007972405505%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=v2JGTkklMHOE2hN1s4dYZ1hT7ctLeUHpwkpn1M3nyi8%3D&reserved=0
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx