Skip to contentSkip to conversation

arm64: dts: broadcom: bcm4908: describe PMB block

PATCH Superseded Rafał Miłecki 2 participants 4 messages Jan 12, 2021 – Jan 20, 2021 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: broadcom: bcm4908: describe PMB block

From: Rafał Miłecki <[email protected]>

PMB (Power Management Bus) controls powering connected devices (e.g. PCIe, USB, SATA). In BCM4908 it's a part of the PROCMON block.

---
Florian: this patch is based on top of the
[PATCH] arm64: dts: broadcom: bcm4908: describe internal switch one. Both modify "ranges".

---
 .../boot/dts/broadcom/bcm4908/bcm4908.dtsi      | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi +16 -1
index 0b44f32fdef1..882953885bfc 100644
@@ -108,7 +108,7 @@ soc {
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
-		ranges = <0x00 0x00 0x80000000 0xd0000>;
+		ranges = <0x00 0x00 0x80000000 0x281000>;
 
 		usb@c300 {
 			compatible = "generic-ehci";
@@ -213,6 +213,21 @@ phy12: phy@c {
 				};
 			};
 		};
+
+		procmon: syscon@280000 {
+			compatible = "simple-mfd";
+			reg = <0x280000 0x1000>;
+			ranges;
+
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			power-controller@2800c0 {
+				compatible = "brcm,bcm4908-pmb";
+				reg = <0x2800c0 0x40>;
+				#power-domain-cells = <1>;
+			};
+		};
 	};
 
 	bus@ff800000 {
Signature · 1 line
2.26.2
#1 lore raw
Quoted 28 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

PMB (Power Management Bus) controls powering connected devices (e.g. PCIe, USB, SATA). In BCM4908 it's a part of the PROCMON block.

---
Florian: this patch is based on top of the
[PATCH] arm64: dts: broadcom: bcm4908: describe internal switch one. Both modify "ranges".

---
 .../boot/dts/broadcom/bcm4908/bcm4908.dtsi      | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi +1 -1
index 0b44f32fdef1..882953885bfc 100644
@@ -108,7 +108,7 @@ soc {
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
-		ranges = <0x00 0x00 0x80000000 0xd0000>;
+		ranges = <0x00 0x00 0x80000000 0x281000>;
 
 		usb@c300 {
 			compatible = "generic-ehci";

arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi phy12: phy@c { · line 218

Quoted 6 lines
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi +3 -0
@@ -213,6 +213,21 @@ phy12: phy@c {
 				};
 			};
 		};
+
+		procmon: syscon@280000 {
+			compatible = "simple-mfd";

Likewise, I would use "simple-bus" here instead of "simple-mfd" even if this does not create a functional difference.

Signature · 1 line
Florian
#2 lore raw

PATCH v2 1/1 arm64: dts: broadcom: bcm4908: describe PMB block

In reply to Rafał Miłecki

From: Rafał Miłecki <[email protected]>

PMB (Power Management Bus) controls powering connected devices (e.g. PCIe, USB, SATA). In BCM4908 it's a part of the PROCMON block.

---
Florian: this patch is based on top of the
[PATCH] arm64: dts: broadcom: bcm4908: describe internal switch one. Both modify "ranges".

V2: Use simple-bus

---
 .../boot/dts/broadcom/bcm4908/bcm4908.dtsi      | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/broadcom/bcm4908/bcm4908.dtsi +16 -1
index d30dd2042786..65e186da81d9 100644
@@ -108,7 +108,7 @@ soc {
 		compatible = "simple-bus";
 		#address-cells = <1>;
 		#size-cells = <1>;
-		ranges = <0x00 0x00 0x80000000 0xd0000>;
+		ranges = <0x00 0x00 0x80000000 0x281000>;
 
 		usb@c300 {
 			compatible = "generic-ehci";
@@ -213,6 +213,21 @@ phy12: phy@c {
 				};
 			};
 		};
+
+		procmon: syscon@280000 {
+			compatible = "simple-bus";
+			reg = <0x280000 0x1000>;
+			ranges;
+
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			power-controller@2800c0 {
+				compatible = "brcm,bcm4908-pmb";
+				reg = <0x2800c0 0x40>;
+				#power-domain-cells = <1>;
+			};
+		};
 	};
 
 	bus@ff800000 {
Signature · 1 line
2.26.2
#3 lore raw
Quoted 7 lines · Rafał Miłecki

From: Rafał Miłecki <[email protected]>

PMB (Power Management Bus) controls powering connected devices (e.g. PCIe, USB, SATA). In BCM4908 it's a part of the PROCMON block.

---

Applied to devicetree-arm64/next, thanks!
--
Florian

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel