nvme: refactor ns->ctrl by request
PATCH 1/1 nvme: refactor ns->ctrl by request
Just for current code in nvme_cleanup_cmd(), we don't have to get namespace instance, but we need controller instance.
Controller instance can be retrieved by namespace instance, but it can be directly accessed by nvme_request instance from request.
ctrl = nvme_req(req)->ctrl;
We don't have to go around namespace instance from request instance through gendisk.
Signed-off-by Minwoo Im <[email protected]>
--- drivers/nvme/host/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/nvme/host/core.c +3 -3
@@ -841,11 +841,11 @@ static inline blk_status_t nvme_setup_rw(struct nvme_ns *ns,void nvme_cleanup_cmd (struct request *req) {if (req->rq_flags &RQF_SPECIAL_PAYLOAD ) { -struct nvme_ns *ns = req->rq_disk->private_data; +struct nvme_ctrl *ctrl =nvme_req (req)->ctrl;struct page *page = req->special_vec.bv_page; -if (page == ns->ctrl->discard_page) -clear_bit_unlock (0 , &ns->ctrl->discard_page_busy); +if (page == ctrl->discard_page) +clear_bit_unlock (0 , &ctrl->discard_page_busy);else kfree (page_address (page) + req->special_vec.bv_offset); }
Signature · 7 lines
2.17.1 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
Reviewed-by Sagi Grimberg <[email protected]>
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Applied to nvme-5.12, thanks.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme