Skip to contentSkip to conversation

dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified

PATCH Applied Jonathan Neuschäfer 4 participants 4 messages Jan 8, 2021 – Feb 10, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified

The NPCM750 Timer/Watchdog Controller has multiple interrupt lines, connected to multiple timers. The driver uses timer 0 for timer interrupts, so the interrupt line corresponding to timer 0 should be specified in DT.

I removed the mention of "flags for falling edge", because the timer controller uses high-level interrupts rather than falling-edge interrupts, and whether flags should be specified is up the interrupt controller's DT binding.

---

v2:
- Fix a typo in the word "watchdog"

---
 .../devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt        | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt +1 -2
index ea22dfe485bee..97258f1a1505b 100644
@@ -6,8 +6,7 @@ timer counters.
 Required properties:
 - compatible      : "nuvoton,npcm750-timer" for Poleg NPCM750.
 - reg             : Offset and length of the register set for the device.
-- interrupts      : Contain the timer interrupt with flags for
-                    falling edge.
+- interrupts      : Contain the timer interrupt of timer 0.
 - clocks          : phandle of timer reference clock (usually a 25 MHz clock).
 
 Example:

--
2.29.2

maintainer
#1 lore raw
Quoted 6 lines · Jonathan Neuschäfer

The NPCM750 Timer/Watchdog Controller has multiple interrupt lines, connected to multiple timers. The driver uses timer 0 for timer interrupts, so the interrupt line corresponding to timer 0 should be specified in DT.

Quoted 6 lines

I removed the mention of "flags for falling edge", because the timer controller uses high-level interrupts rather than falling-edge interrupts, and whether flags should be specified is up the interrupt controller's DT binding.

Reviewed-by Avi Fishman <[email protected]>

Quoted 25 lines

---

v2:
- Fix a typo in the word "watchdog"

---
 .../devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt        | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt +1 -3
index ea22dfe485bee..97258f1a1505b 100644
@@ -6,8 +6,7 @@ timer counters.
 Required properties:
 - compatible      : "nuvoton,npcm750-timer" for Poleg NPCM750.
 - reg             : Offset and length of the register set for the device.
-- interrupts      : Contain the timer interrupt with flags for
-                    falling edge.
+- interrupts      : Contain the timer interrupt of timer 0.
 - clocks          : phandle of timer reference clock (usually a 25 MHz clock).
 
 Example:
--

2.29.2

Signature · 2 lines
Regards,
Avi
maintainer Acked-by on v2 1/1
#2 lore raw
In reply to Jonathan Neuschäfer
Quoted 10 lines · Jonathan Neuschäfer

The NPCM750 Timer/Watchdog Controller has multiple interrupt lines, connected to multiple timers. The driver uses timer 0 for timer interrupts, so the interrupt line corresponding to timer 0 should be specified in DT.

I removed the mention of "flags for falling edge", because the timer controller uses high-level interrupts rather than falling-edge interrupts, and whether flags should be specified is up the interrupt controller's DT binding.

Quoted 9 lines

---

v2:
- Fix a typo in the word "watchdog"

---
 .../devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt        | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
#3 lore raw
In reply to Jonathan Neuschäfer
The following commit has been merged into the timers/core branch of tip:

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     e1922b5da0e6869f1850c4447bed0b9cb1cf5034
Gitweb:        https://git.kernel.org/tip/e1922b5da0e6869f1850c4447bed0b9cb1cf5034
Author:        Jonathan Neuschäfer <[email protected]>
AuthorDate:    Fri, 08 Jan 2021 17:30:04 +01:00
Committer:     Daniel Lezcano <[email protected]>
CommitterDate: Mon, 18 Jan 2021 16:33:51 +01:00

dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified

The NPCM750 Timer/Watchdog Controller has multiple interrupt lines, connected to multiple timers. The driver uses timer 0 for timer interrupts, so the interrupt line corresponding to timer 0 should be specified in DT.

I removed the mention of "flags for falling edge", because the timer controller uses high-level interrupts rather than falling-edge interrupts, and whether flags should be specified is up the interrupt controller's DT binding.

---
 Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt +1 -2
index ea22dfe..97258f1 100644
@@ -6,8 +6,7 @@ timer counters.
 Required properties:
 - compatible      : "nuvoton,npcm750-timer" for Poleg NPCM750.
 - reg             : Offset and length of the register set for the device.
-- interrupts      : Contain the timer interrupt with flags for
-                    falling edge.
+- interrupts      : Contain the timer interrupt of timer 0.
 - clocks          : phandle of timer reference clock (usually a 25 MHz clock).
 
 Example: