Skip to contentSkip to conversation

dts64: mt7622: fix slow sd card access

PATCH Applied Frank Wunderlich 3 participants 3 messages Jan 13, 2021 – Jan 31, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dts64: mt7622: fix slow sd card access

From: Frank Wunderlich <[email protected]>

Fix extreme slow speed (200MB takes ~20 min) on writing sdcard on bananapi-r64 by adding reset-control for mmc1 like it's done for mmc0/emmc.

Fixes 2c002a3049f7 ("arm64: dts: mt7622: add mmc related device nodes")

---
changes since v1:
- drop change to uhs-mode because mt7622 does not support it

---
 arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/mediatek/mt7622.dtsi +2 -0
index 5b9ec032ce8d..7c6d871538a6 100644
@@ -698,6 +698,8 @@ mmc1: mmc@11240000 {
 		clocks = <&pericfg CLK_PERI_MSDC30_1_PD>,
 			 <&topckgen CLK_TOP_AXI_SEL>;
 		clock-names = "source", "hclk";
+		resets = <&pericfg MT7622_PERI_MSDC1_SW_RST>;
+		reset-names = "hrst";
 		status = "disabled";
 	};
 
Signature · 7 lines
2.25.1


_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
#1 lore raw
Quoted 20 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>

Fix extreme slow speed (200MB takes ~20 min) on writing sdcard on bananapi-r64 by adding reset-control for mmc1 like it's done for mmc0/emmc.

Fixes 2c002a3049f7 ("arm64: dts: mt7622: add mmc related device nodes")

---
changes since v1:
- drop change to uhs-mode because mt7622 does not support it

---
 arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/mediatek/mt7622.dtsi +0 -0
index 5b9ec032ce8d..7c6d871538a6 100644

arch/arm64/boot/dts/mediatek/mt7622.dtsi mmc1: mmc@11240000 { · line 702

Quoted 5 lines
arch/arm64/boot/dts/mediatek/mt7622.dtsi +2 -0
@@ -698,6 +698,8 @@ mmc1: mmc@11240000 {
 		clocks = <&pericfg CLK_PERI_MSDC30_1_PD>,
 			 <&topckgen CLK_TOP_AXI_SEL>;
 		clock-names = "source", "hclk";
+		resets = <&pericfg MT7622_PERI_MSDC1_SW_RST>;
+		reset-names = "hrst";

This looks ok to me. I think it's also necessary to trigger software reset for SD(mmc1) because loader(uboot) might mess up MSDC's registers. "Software reset" here will reset registers of AHB/AXI bus domain, such as MSDC_CFG[8:15]. msdc_reset_hw() in mtk-sd.c will only reset registers of MSDC CK domain.

maintainer Applied
#2 lore raw
In reply to Frank Wunderlich
Quoted 8 lines · Frank Wunderlich

From: Frank Wunderlich <[email protected]>

Fix extreme slow speed (200MB takes ~20 min) on writing sdcard on bananapi-r64 by adding reset-control for mmc1 like it's done for mmc0/emmc.

Fixes 2c002a3049f7 ("arm64: dts: mt7622: add mmc related device nodes")

Applied to v5.11-next/dts64

Thanks!

Quoted 13 lines

---
changes since v1:
- drop change to uhs-mode because mt7622 does not support it

---
 arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/mediatek/mt7622.dtsi +0 -0
index 5b9ec032ce8d..7c6d871538a6 100644

arch/arm64/boot/dts/mediatek/mt7622.dtsi mmc1: mmc@11240000 { · line 705

Quoted 8 lines
arch/arm64/boot/dts/mediatek/mt7622.dtsi +2 -0
@@ -698,6 +698,8 @@ mmc1: mmc@11240000 {
 		clocks = <&pericfg CLK_PERI_MSDC30_1_PD>,
 			 <&topckgen CLK_TOP_AXI_SEL>;
 		clock-names = "source", "hclk";
+		resets = <&pericfg MT7622_PERI_MSDC1_SW_RST>;
+		reset-names = "hrst";
 		status = "disabled";
 	};
 

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek