package/freescale-imx/firmware-imx: fix the VPU firmware location
Fabio Estevam
reviewerPATCH v2 1/1 package/freescale-imx/firmware-imx: fix the VPU firmware location
The mainline kernel searches the coda VPU firmware inside the following locations [1]:
/lib/firmware//lib/firmware/vpu/
Currently Buildroot installs the coda firmware into /lib/firmware/imx/vpu, which is not a valid location.
Fix it by installing the coda firmwares into /lib/firmware/vpu/ which is a valid path for both mainline and NXP vendor kernels. Also create a symlink to /lib/firmware/ so that mainline kernels do not need to wait more than 60 seconds to search again inside /lib/firmware/vpu/.
---
Changes since v1:
- Create symlinks to /lib/firmware to speed up mainline kernels to found the VPU firmware.
package/freescale-imx/firmware-imx/firmware-imx.mk | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
package/freescale-imx/firmware-imx/firmware-imx.mk +5 -3
@@ -116,9 +116,11 @@ endif FIRMWARE_IMX_VPU_FW_NAME = $(call qstrip,$(BR2_PACKAGE_FIRMWARE_IMX_VPU_FW_NAME)) ifneq ($(FIRMWARE_IMX_VPU_FW_NAME),) define FIRMWARE_IMX_INSTALL_TARGET_VPU_FW - mkdir -p $(TARGET_DIR)/lib/firmware/imx/vpu - cp $(@D)/firmware/vpu/vpu_fw_$(FIRMWARE_IMX_VPU_FW_NAME)*.bin \ - $(TARGET_DIR)/lib/firmware/imx/vpu/ + mkdir -p $(TARGET_DIR)/lib/firmware/vpu + for i in $$(find $(@D)/firmware/vpu/vpu_fw_$(FIRMWARE_IMX_VPU_FW_NAME)*.bin); do \ + cp $$i $(TARGET_DIR)/lib/firmware/vpu/ ; \ + ln -sf vpu/$$(basename $$i) $(TARGET_DIR)/lib/firmware/$$(basename $$i) ; \ + done endef endif
Signature · 1 line
2.17.1
PATCH v2 1/1 package/freescale-imx/firmware-imx: fix the VPU firmware location
Hi Fabio,
Le 13/01/2021 ? 23:30, Fabio Estevam a ?crit?:
Quoted 14 lines
The mainline kernel searches the coda VPU firmware inside the following locations [1]:
/lib/firmware//lib/firmware/vpu/Currently Buildroot installs the coda firmware into
/lib/firmware/imx/vpu, which is not a valid location.Fix it by installing the coda firmwares into
/lib/firmware/vpu/which is a valid path for both mainline and NXP vendor kernels. Also create a symlink to/lib/firmware/so that mainline kernels do not need to wait more than 60 seconds to search again inside/lib/firmware/vpu/.
Quoted 4 lines
Reported-by Romain Naour <[email protected]>Suggested-by Romain Naour <[email protected]>
Best regards,
Romain
Quoted 29 lines
Signed-off-by Fabio Estevam <[email protected]>---
Changes since v1:
- Create symlinks to/lib/firmwareto speed up mainline kernels to found the VPU firmware.package/freescale-imx/firmware-imx/firmware-imx.mk | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)package/freescale-imx/firmware-imx/firmware-imx.mk +5
-3@@ -116,9 +116,11 @@ endif FIRMWARE_IMX_VPU_FW_NAME = $(call qstrip,$(BR2_PACKAGE_FIRMWARE_IMX_VPU_FW_NAME)) ifneq ($(FIRMWARE_IMX_VPU_FW_NAME),) define FIRMWARE_IMX_INSTALL_TARGET_VPU_FW - mkdir -p $(TARGET_DIR)/lib/firmware/imx/vpu - cp $(@D)/firmware/vpu/vpu_fw_$(FIRMWARE_IMX_VPU_FW_NAME)*.bin \ - $(TARGET_DIR)/lib/firmware/imx/vpu/ + mkdir -p $(TARGET_DIR)/lib/firmware/vpu + for i in $$(find $(@D)/firmware/vpu/vpu_fw_$(FIRMWARE_IMX_VPU_FW_NAME)*.bin); do \ + cp $$i $(TARGET_DIR)/lib/firmware/vpu/ ; \ + ln -sf vpu/$$(basename $$i) $(TARGET_DIR)/lib/firmware/$$(basename $$i) ; \ + done endef endif
Thomas Petazzoni
AppliedPATCH v2 1/1 package/freescale-imx/firmware-imx: fix the VPU firmware location
In reply to Fabio EstevamQuoted 16 lines · On Wed, 13 Jan 2021 19:30:39 -0300 Fabio Estevam <[email protected]> wrote:
The mainline kernel searches the coda VPU firmware inside the following locations [1]:
/lib/firmware//lib/firmware/vpu/Currently Buildroot installs the coda firmware into
/lib/firmware/imx/vpu, which is not a valid location.Fix it by installing the coda firmwares into
/lib/firmware/vpu/which is a valid path for both mainline and NXP vendor kernels. Also create a symlink to/lib/firmware/so that mainline kernels do not need to wait more than 60 seconds to search again inside/lib/firmware/vpu/.
Quoted 7 lines
Reported-by Romain Naour <[email protected]>Suggested-by Romain Naour <[email protected]>Signed-off-by Fabio Estevam <[email protected]>---
Changes since v1:
- Create symlinks to/lib/firmwareto speed up mainline kernels to found the VPU firmware.
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v2 1/1 package/freescale-imx/firmware-imx: fix the VPU firmware location
In reply to Fabio EstevamQuoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Fabio" == Fabio Estevam <[email protected]> writes:
The mainline kernel searches the coda VPU firmware inside the following locations [1]:
/lib/firmware//lib/firmware/vpu/Currently Buildroot installs the coda firmware into
/lib/firmware/imx/vpu, which is not a valid location.Fix it by installing the coda firmwares into
/lib/firmware/vpu/which is a valid path for both mainline and NXP vendor kernels. Also create a symlink to/lib/firmware/so that mainline kernels do not need to wait more than 60 seconds to search again inside/lib/firmware/vpu/.
Quoted 7 lines
Reported-by Romain Naour <[email protected]>Suggested-by Romain Naour <[email protected]>Signed-off-by Fabio Estevam <[email protected]>---
Changes since v1:
- Create symlinks to/lib/firmwareto speed up mainline kernels to found the VPU firmware.
Committed to 2020.11.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard