Skip to contentSkip to conversation

module: Ignore _GLOBAL_OFFSET_TABLE_ when warning for undefined symbols

PATCH Superseded Fangrui Song 5 participants 13 messages Jan 14, 2021 – Jan 18, 2021 Stable branch

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 module: Ignore _GLOBAL_OFFSET_TABLE_ when warning for undefined symbols

clang-12 -fno-pic (since
https://github.com/llvm/llvm-project/commit/a084c0388e2a59b9556f2de0083333232da3f1d6)
can emit call __stack_chk_fail@PLT instead of call __stack_chk_fail on x86. The two forms should have identical behaviors on x86-64 but the former causes GNU as<2.37 to produce an unreferenced undefined symbol _GLOBAL_OFFSET_TABLE_.

(On x86-32, there is an R_386_PC32 vs R_386_PLT32 difference but the linker behavior is identical as far as Linux kernel is concerned.)

Simply ignore _GLOBAL_OFFSET_TABLE_ for now, like what scripts/mod/modpost.c:ignore_undef_symbol does. This also fixes the problem for gcc/clang -fpie and -fpic, which may emit call foo@PLT for external function calls on x86.

Note: ld -z defs and dynamic loaders do not error for unreferenced undefined symbols so the module loader is reading too much. If we ever need to ignore more symbols, the code should be refactored to ignore unreferenced symbols.

---
 kernel/module.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
kernel/module.c +8 -2
index 4bf30e4b3eaa..2e2deea99289 100644
@@ -2395,8 +2395,14 @@ static int simplify_symbols(struct module *mod, const struct load_info *info)
 				break;
 			}
 
-			/* Ok if weak.  */
-			if (!ksym && ELF_ST_BIND(sym[i].st_info) == STB_WEAK)
+			/* Ok if weak. Also allow _GLOBAL_OFFSET_TABLE_:
+			 * GNU as before 2.37 produces an unreferenced _GLOBAL_OFFSET_TABLE_
+			 * for call foo@PLT on x86-64.  If the code ever needs to ignore
+			 * more symbols, refactor the code to only warn if referenced by
+			 * a relocation.
+			 */
+			if (!ksym && (ELF_ST_BIND(sym[i].st_info) == STB_WEAK ||
+				      !strcmp(name, "_GLOBAL_OFFSET_TABLE_")))
 				break;
 
 			ret = PTR_ERR(ksym) ?: -ENOENT;
Signature · 1 line
2.30.0.284.gd98b1dd5eaa7-goog
#1 lore raw

+++ Fangrui Song [13/01/21 21:48 -0800]:

Quoted 36 lines

clang-12 -fno-pic (since
https://github.com/llvm/llvm-project/commit/a084c0388e2a59b9556f2de0083333232da3f1d6)
can emit call __stack_chk_fail@PLT instead of call __stack_chk_fail on x86. The two forms should have identical behaviors on x86-64 but the former causes GNU as<2.37 to produce an unreferenced undefined symbol _GLOBAL_OFFSET_TABLE_.

(On x86-32, there is an R_386_PC32 vs R_386_PLT32 difference but the linker behavior is identical as far as Linux kernel is concerned.)

Simply ignore _GLOBAL_OFFSET_TABLE_ for now, like what scripts/mod/modpost.c:ignore_undef_symbol does. This also fixes the problem for gcc/clang -fpie and -fpic, which may emit call foo@PLT for external function calls on x86.

Note: ld -z defs and dynamic loaders do not error for unreferenced undefined symbols so the module loader is reading too much. If we ever need to ignore more symbols, the code should be refactored to ignore unreferenced symbols.

---
kernel/module.c | 10 ++++++++--

1 file changed, 8 insertions(+), 2 deletions(-)
kernel/module.c +0 -1
index 4bf30e4b3eaa..2e2deea99289 100644
@@ -2395,8 +2395,14 @@ static int simplify_symbols(struct module *mod, const struct load_info *info)
 				break;
 			}
 
-			/* Ok if weak.  */

kernel/module.c static int simplify_symbols(struct module *mod, const struct load_info *info) · line 2406

Quoted 10 lines
kernel/module.c +8 -1
-			if (!ksym && ELF_ST_BIND(sym[i].st_info) == STB_WEAK)
+			/* Ok if weak. Also allow _GLOBAL_OFFSET_TABLE_:
+			 * GNU as before 2.37 produces an unreferenced _GLOBAL_OFFSET_TABLE_
+			 * for call foo@PLT on x86-64.  If the code ever needs to ignore
+			 * more symbols, refactor the code to only warn if referenced by
+			 * a relocation.
+			 */
+			if (!ksym && (ELF_ST_BIND(sym[i].st_info) == STB_WEAK ||
+				      !strcmp(name, "_GLOBAL_OFFSET_TABLE_")))
 				break;

Hi Fangrui,

Thanks for the patch. I am puzzled why we don't already mirror modpost here, that particular line of code in modpost to ignore _GLOBAL_OFFSET_TABLE_ has been there long before my time. Let's properly mirror modpost then, and create a similar helper function ignore_undef_symbol() (and stick the _GLOBAL_OFFSET_TABLE_ check in there) to account for future cases like this.

Thanks,

Jessica

#2 lore raw
Quoted 58 lines · Jessica Yu

+++ Fangrui Song [13/01/21 21:48 -0800]:

Quoted 36 lines

clang-12 -fno-pic (since
https://github.com/llvm/llvm-project/commit/a084c0388e2a59b9556f2de0083333232da3f1d6)
can emit call __stack_chk_fail@PLT instead of call __stack_chk_fail on x86. The two forms should have identical behaviors on x86-64 but the former causes GNU as<2.37 to produce an unreferenced undefined symbol _GLOBAL_OFFSET_TABLE_.

(On x86-32, there is an R_386_PC32 vs R_386_PLT32 difference but the linker behavior is identical as far as Linux kernel is concerned.)

Simply ignore _GLOBAL_OFFSET_TABLE_ for now, like what scripts/mod/modpost.c:ignore_undef_symbol does. This also fixes the problem for gcc/clang -fpie and -fpic, which may emit call foo@PLT for external function calls on x86.

Note: ld -z defs and dynamic loaders do not error for unreferenced undefined symbols so the module loader is reading too much. If we ever need to ignore more symbols, the code should be refactored to ignore unreferenced symbols.

---
kernel/module.c | 10 ++++++++--

1 file changed, 8 insertions(+), 2 deletions(-)
kernel/module.c +0 -1
index 4bf30e4b3eaa..2e2deea99289 100644
@@ -2395,8 +2395,14 @@ static int simplify_symbols(struct module *mod, const struct load_info *info)
                              break;
                      }
 
-                      /* Ok if weak.  */

kernel/module.c static int simplify_symbols(struct module *mod, const struct load_info *info) · line 2406

Quoted 10 lines
kernel/module.c +8 -1
-                      if (!ksym && ELF_ST_BIND(sym[i].st_info) == STB_WEAK)
+                      /* Ok if weak. Also allow _GLOBAL_OFFSET_TABLE_:
+                       * GNU as before 2.37 produces an unreferenced _GLOBAL_OFFSET_TABLE_
+                       * for call foo@PLT on x86-64.  If the code ever needs to ignore
+                       * more symbols, refactor the code to only warn if referenced by
+                       * a relocation.
+                       */
+                      if (!ksym && (ELF_ST_BIND(sym[i].st_info) == STB_WEAK ||
+                                    !strcmp(name, "_GLOBAL_OFFSET_TABLE_")))
                              break;

Hi Fangrui,

Thanks for the patch. I am puzzled why we don't already mirror modpost here, that particular line of code in modpost to ignore _GLOBAL_OFFSET_TABLE_ has been there long before my time. Let's properly mirror modpost then, and create a similar helper function ignore_undef_symbol() (and stick the _GLOBAL_OFFSET_TABLE_ check in there) to account for future cases like this.

Quoted 3 lines

Thanks,

Jessica

Hi Jessica,

I guess __this_module in scripts/mod/modpost.c:ignore_undef_symbol is not a problem.
For PPC64 _restgpr0_* and _savegpr0_*, I am not sure ignoring the undefined functions in kernel/module.c is right.
(I know they can be produced by gcc -Os in some cases
(https://reviews.llvm.org/D79977), but I want to learn whether that is a real issue before adding them.)

If we ever need to ignore more symbols, the code should be refactored to not warn for unreferenced undefined symbols as my description says.

#3 lore raw

+++ Fāng-ruì Sòng [14/01/21 08:57 -0800]:

Quoted 73 lines · Jessica Yu
Quoted 58 lines

+++ Fangrui Song [13/01/21 21:48 -0800]:

Quoted 36 lines

clang-12 -fno-pic (since
https://github.com/llvm/llvm-project/commit/a084c0388e2a59b9556f2de0083333232da3f1d6)
can emit call __stack_chk_fail@PLT instead of call __stack_chk_fail on x86. The two forms should have identical behaviors on x86-64 but the former causes GNU as<2.37 to produce an unreferenced undefined symbol _GLOBAL_OFFSET_TABLE_.

(On x86-32, there is an R_386_PC32 vs R_386_PLT32 difference but the linker behavior is identical as far as Linux kernel is concerned.)

Simply ignore _GLOBAL_OFFSET_TABLE_ for now, like what scripts/mod/modpost.c:ignore_undef_symbol does. This also fixes the problem for gcc/clang -fpie and -fpic, which may emit call foo@PLT for external function calls on x86.

Note: ld -z defs and dynamic loaders do not error for unreferenced undefined symbols so the module loader is reading too much. If we ever need to ignore more symbols, the code should be refactored to ignore unreferenced symbols.

---
kernel/module.c | 10 ++++++++--

1 file changed, 8 insertions(+), 2 deletions(-)
kernel/module.c +0 -1
index 4bf30e4b3eaa..2e2deea99289 100644
@@ -2395,8 +2395,14 @@ static int simplify_symbols(struct module *mod, const struct load_info *info)
                              break;
                      }
 
-                      /* Ok if weak.  */

kernel/module.c static int simplify_symbols(struct module *mod, const struct load_info *info) · line 2406

Quoted 10 lines
kernel/module.c +8 -1
-                      if (!ksym && ELF_ST_BIND(sym[i].st_info) == STB_WEAK)
+                      /* Ok if weak. Also allow _GLOBAL_OFFSET_TABLE_:
+                       * GNU as before 2.37 produces an unreferenced _GLOBAL_OFFSET_TABLE_
+                       * for call foo@PLT on x86-64.  If the code ever needs to ignore
+                       * more symbols, refactor the code to only warn if referenced by
+                       * a relocation.
+                       */
+                      if (!ksym && (ELF_ST_BIND(sym[i].st_info) == STB_WEAK ||
+                                    !strcmp(name, "_GLOBAL_OFFSET_TABLE_")))
                              break;

Hi Fangrui,

Thanks for the patch. I am puzzled why we don't already mirror modpost here, that particular line of code in modpost to ignore _GLOBAL_OFFSET_TABLE_ has been there long before my time. Let's properly mirror modpost then, and create a similar helper function ignore_undef_symbol() (and stick the _GLOBAL_OFFSET_TABLE_ check in there) to account for future cases like this.

Quoted 3 lines

Thanks,

Jessica

Hi Jessica,

I guess __this_module in scripts/mod/modpost.c:ignore_undef_symbol is not a problem.
For PPC64 _restgpr0_* and _savegpr0_*, I am not sure ignoring the undefined functions in kernel/module.c is right.
(I know they can be produced by gcc -Os in some cases
(https://reviews.llvm.org/D79977), but I want to learn whether that is a real issue before adding them.)

Quoted 2 lines

If we ever need to ignore more symbols, the code should be refactored to not warn for unreferenced undefined symbols as my description says.

Hi Fangrui,

Sorry for the confusion, I did not mean to exactly mirror ignore_undef_symbol() in modpost. The conditions are different there and not all of them would not apply to kernel/module.c. Like __this_module, as you say, is not a problem as this will be resolved once all the module *.o are linked in the final .ko. So when it reaches the module loader it would no longer be UNDEF. I assume that it is a similar situation for the PPC64 symbols.

What I meant that we could probably make this patch look nicer by moving the hardcoded check for "_GLOBAL_OFFSET_TABLE_" to a helper function ignore_undef_symbol(), similar to how modpost does it, without adding any additional conditions for now. And yes, if we ever need to extend this and refactor to not warn for unreferenced undefined symbols, we should refactor to generalize this case, but for the scope of this patch I think the suggested change is sufficient for now.

Thank you,

Jessica

#4 lore raw

PATCH v2 1/1 module: Ignore _GLOBAL_OFFSET_TABLE_ when warning for undefined symbols

clang-12 -fno-pic (since
https://github.com/llvm/llvm-project/commit/a084c0388e2a59b9556f2de0083333232da3f1d6)
can emit call __stack_chk_fail@PLT instead of call __stack_chk_fail on x86. The two forms should have identical behaviors on x86-64 but the former causes GNU as<2.37 to produce an unreferenced undefined symbol _GLOBAL_OFFSET_TABLE_.

(On x86-32, there is an R_386_PC32 vs R_386_PLT32 difference but the linker behavior is identical as far as Linux kernel is concerned.)

Simply ignore _GLOBAL_OFFSET_TABLE_ for now, like what scripts/mod/modpost.c:ignore_undef_symbol does. This also fixes the problem for gcc/clang -fpie and -fpic, which may emit call foo@PLT for external function calls on x86.

Note: ld -z defs and dynamic loaders do not error for unreferenced undefined symbols so the module loader is reading too much. If we ever need to ignore more symbols, the code should be refactored to ignore unreferenced symbols.

---
 kernel/module.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

---
Changes in v2:
* Fix Marco's email address
* Add a function ignore_undef_symbol similar to scripts/mod/modpost.c:ignore_undef_symbol

kernel/module.c +18 -2
index 4bf30e4b3eaa..278f5129bde2 100644
@@ -2348,6 +2348,20 @@ static int verify_exported_symbols(struct module *mod)
 	return 0;
 }
 
+static int ignore_undef_symbol(Elf_Half emachine, const char *name)
+{
+	/* On x86, PIC code and Clang non-PIC code may have call foo@PLT. GNU as
+	 * before 2.37 produces an unreferenced _GLOBAL_OFFSET_TABLE_ on x86-64.
+	 * i386 has a similar problem but may not deserve a fix.
+	 *
+	 * If we ever have to ignore many symbols, consider refactoring the code to
+	 * only warn if referenced by a relocation.
+	 */
+	if (emachine == EM_386 || emachine == EM_X86_64)
+		return !strcmp(name, "_GLOBAL_OFFSET_TABLE_");
+	return 0;
+}
+
 /* Change all symbols so that st_value encodes the pointer directly. */
 static int simplify_symbols(struct module *mod, const struct load_info *info)
 {
@@ -2395,8 +2409,10 @@ static int simplify_symbols(struct module *mod, const struct load_info *info)
 				break;
 			}
 
-			/* Ok if weak.  */
-			if (!ksym && ELF_ST_BIND(sym[i].st_info) == STB_WEAK)
+			/* Ok if weak or ignored.  */
+			if (!ksym &&
+			    (ELF_ST_BIND(sym[i].st_info) == STB_WEAK ||
+			     ignore_undef_symbol(info->hdr->e_machine, name)))
 				break;
 
 			ret = PTR_ERR(ksym) ?: -ENOENT;
Signature · 1 line
2.30.0.296.g2bfb1c46d8-goog
Reviewed-by on v2 1/1
#5 lore raw
Quoted 16 lines · Fangrui Song' via Clang Built Linux

clang-12 -fno-pic (since
https://github.com/llvm/llvm-project/commit/a084c0388e2a59b9556f2de0083333232da3f1d6)
can emit call __stack_chk_fail@PLT instead of call __stack_chk_fail on x86. The two forms should have identical behaviors on x86-64 but the former causes GNU as<2.37 to produce an unreferenced undefined symbol _GLOBAL_OFFSET_TABLE_.

(On x86-32, there is an R_386_PC32 vs R_386_PLT32 difference but the linker behavior is identical as far as Linux kernel is concerned.)

Simply ignore _GLOBAL_OFFSET_TABLE_ for now, like what scripts/mod/modpost.c:ignore_undef_symbol does. This also fixes the problem for gcc/clang -fpie and -fpic, which may emit call foo@PLT for external function calls on x86.

Quoted 8 lines

Note: ld -z defs and dynamic loaders do not error for unreferenced undefined symbols so the module loader is reading too much. If we ever need to ignore more symbols, the code should be refactored to ignore unreferenced symbols.

Thanks for the patch.

Jessica, would you mind adding when applying:

as I suspect we might want this fixed in stable tree's branches, too. It might of interest to add:

too.

Quoted 47 lines
---
 kernel/module.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

---
Changes in v2:
* Fix Marco's email address
* Add a function ignore_undef_symbol similar to scripts/mod/modpost.c:ignore_undef_symbol

kernel/module.c +18 -3
index 4bf30e4b3eaa..278f5129bde2 100644
@@ -2348,6 +2348,20 @@ static int verify_exported_symbols(struct module *mod)
        return 0;
 }
 
+static int ignore_undef_symbol(Elf_Half emachine, const char *name)
+{
+       /* On x86, PIC code and Clang non-PIC code may have call foo@PLT. GNU as
+        * before 2.37 produces an unreferenced _GLOBAL_OFFSET_TABLE_ on x86-64.
+        * i386 has a similar problem but may not deserve a fix.
+        *
+        * If we ever have to ignore many symbols, consider refactoring the code to
+        * only warn if referenced by a relocation.
+        */
+       if (emachine == EM_386 || emachine == EM_X86_64)
+               return !strcmp(name, "_GLOBAL_OFFSET_TABLE_");
+       return 0;
+}
+
 /* Change all symbols so that st_value encodes the pointer directly. */
 static int simplify_symbols(struct module *mod, const struct load_info *info)
 {
@@ -2395,8 +2409,10 @@ static int simplify_symbols(struct module *mod, const struct load_info *info)
                                break;
                        }
 
-                       /* Ok if weak.  */
-                       if (!ksym && ELF_ST_BIND(sym[i].st_info) == STB_WEAK)
+                       /* Ok if weak or ignored.  */
+                       if (!ksym &&
+                           (ELF_ST_BIND(sym[i].st_info) == STB_WEAK ||
+                            ignore_undef_symbol(info->hdr->e_machine, name)))
                                break;
 
                        ret = PTR_ERR(ksym) ?: -ENOENT;
--
Signature · 2 lines
Thanks,
~Nick Desaulniers
#6 lore raw

+++ Nick Desaulniers [14/01/21 14:01 -0800]:

Quoted 33 lines
Quoted 16 lines · Fangrui Song' via Clang Built Linux

clang-12 -fno-pic (since
https://github.com/llvm/llvm-project/commit/a084c0388e2a59b9556f2de0083333232da3f1d6)
can emit call __stack_chk_fail@PLT instead of call __stack_chk_fail on x86. The two forms should have identical behaviors on x86-64 but the former causes GNU as<2.37 to produce an unreferenced undefined symbol _GLOBAL_OFFSET_TABLE_.

(On x86-32, there is an R_386_PC32 vs R_386_PLT32 difference but the linker behavior is identical as far as Linux kernel is concerned.)

Simply ignore _GLOBAL_OFFSET_TABLE_ for now, like what scripts/mod/modpost.c:ignore_undef_symbol does. This also fixes the problem for gcc/clang -fpie and -fpic, which may emit call foo@PLT for external function calls on x86.

Quoted 8 lines

Note: ld -z defs and dynamic loaders do not error for unreferenced undefined symbols so the module loader is reading too much. If we ever need to ignore more symbols, the code should be refactored to ignore unreferenced symbols.

Thanks for the patch.

Jessica, would you mind adding when applying:

Quoted 8 lines

as I suspect we might want this fixed in stable tree's branches, too. It might of interest to add:

too.

Sure, will do!

Thanks,

Jessica

Tested-by on v2 1/1
#7 lore raw
In reply to Fangrui Song
Quoted 15 lines · Fangrui Song

clang-12 -fno-pic (since
https://github.com/llvm/llvm-project/commit/a084c0388e2a59b9556f2de0083333232da3f1d6)
can emit call __stack_chk_fail@PLT instead of call __stack_chk_fail on x86. The two forms should have identical behaviors on x86-64 but the former causes GNU as<2.37 to produce an unreferenced undefined symbol _GLOBAL_OFFSET_TABLE_.

(On x86-32, there is an R_386_PC32 vs R_386_PLT32 difference but the linker behavior is identical as far as Linux kernel is concerned.)

Simply ignore _GLOBAL_OFFSET_TABLE_ for now, like what scripts/mod/modpost.c:ignore_undef_symbol does. This also fixes the problem for gcc/clang -fpie and -fpic, which may emit call foo@PLT for external function calls on x86.

Quoted 8 lines

Note: ld -z defs and dynamic loaders do not error for unreferenced undefined symbols so the module loader is reading too much. If we ever need to ignore more symbols, the code should be refactored to ignore unreferenced symbols.

Thank you for the patch!

Quoted 13 lines
---
 kernel/module.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

---
Changes in v2:
* Fix Marco's email address
* Add a function ignore_undef_symbol similar to scripts/mod/modpost.c:ignore_undef_symbol

kernel/module.c +0 -0
index 4bf30e4b3eaa..278f5129bde2 100644

kernel/module.c static int verify_exported_symbols(struct module *mod) · line 2351

Quoted 4 lines
kernel/module.c +1 -0
@@ -2348,6 +2348,20 @@ static int verify_exported_symbols(struct module *mod)
        return 0;
 }
 
+static int ignore_undef_symbol(Elf_Half emachine, const char *name)

Why not 'bool' return-type?

kernel/module.c static int verify_exported_symbols(struct module *mod) · line 2353

Quoted 2 lines
kernel/module.c +2 -0
+{
+       /* On x86, PIC code and Clang non-PIC code may have call foo@PLT. GNU as

Not sure if checkpatch.pl warns about this, but this multi-line comment does not follow the normal kernel-style (see elsewhere in file):

/*
* ...
*/

Quoted 30 lines
kernel/module.c +15 -3
+        * before 2.37 produces an unreferenced _GLOBAL_OFFSET_TABLE_ on x86-64.
+        * i386 has a similar problem but may not deserve a fix.
+        *
+        * If we ever have to ignore many symbols, consider refactoring the code to
+        * only warn if referenced by a relocation.
+        */
+       if (emachine == EM_386 || emachine == EM_X86_64)
+               return !strcmp(name, "_GLOBAL_OFFSET_TABLE_");
+       return 0;
+}
+
 /* Change all symbols so that st_value encodes the pointer directly. */
 static int simplify_symbols(struct module *mod, const struct load_info *info)
 {
@@ -2395,8 +2409,10 @@ static int simplify_symbols(struct module *mod, const struct load_info *info)
                                break;
                        }
 
-                       /* Ok if weak.  */
-                       if (!ksym && ELF_ST_BIND(sym[i].st_info) == STB_WEAK)
+                       /* Ok if weak or ignored.  */
+                       if (!ksym &&
+                           (ELF_ST_BIND(sym[i].st_info) == STB_WEAK ||
+                            ignore_undef_symbol(info->hdr->e_machine, name)))
                                break;
 
                        ret = PTR_ERR(ksym) ?: -ENOENT;
--

2.30.0.296.g2bfb1c46d8-goog

#8 lore raw

+++ Marco Elver [15/01/21 08:03 +0100]:

Quoted 52 lines · Fangrui Song
Quoted 15 lines

clang-12 -fno-pic (since
https://github.com/llvm/llvm-project/commit/a084c0388e2a59b9556f2de0083333232da3f1d6)
can emit call __stack_chk_fail@PLT instead of call __stack_chk_fail on x86. The two forms should have identical behaviors on x86-64 but the former causes GNU as<2.37 to produce an unreferenced undefined symbol _GLOBAL_OFFSET_TABLE_.

(On x86-32, there is an R_386_PC32 vs R_386_PLT32 difference but the linker behavior is identical as far as Linux kernel is concerned.)

Simply ignore _GLOBAL_OFFSET_TABLE_ for now, like what scripts/mod/modpost.c:ignore_undef_symbol does. This also fixes the problem for gcc/clang -fpie and -fpic, which may emit call foo@PLT for external function calls on x86.

Quoted 8 lines

Note: ld -z defs and dynamic loaders do not error for unreferenced undefined symbols so the module loader is reading too much. If we ever need to ignore more symbols, the code should be refactored to ignore unreferenced symbols.

Thank you for the patch!

Quoted 13 lines
---
 kernel/module.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

---
Changes in v2:
* Fix Marco's email address
* Add a function ignore_undef_symbol similar to scripts/mod/modpost.c:ignore_undef_symbol

kernel/module.c +0 -0
index 4bf30e4b3eaa..278f5129bde2 100644

kernel/module.c static int verify_exported_symbols(struct module *mod) · line 2351

Quoted 4 lines
kernel/module.c +1 -0
@@ -2348,6 +2348,20 @@ static int verify_exported_symbols(struct module *mod)
        return 0;
 }
 
+static int ignore_undef_symbol(Elf_Half emachine, const char *name)

Why not 'bool' return-type?

kernel/module.c static int verify_exported_symbols(struct module *mod) · line 2353

Quoted 2 lines
kernel/module.c +2 -0
+{
+       /* On x86, PIC code and Clang non-PIC code may have call foo@PLT. GNU as
Quoted 7 lines

Not sure if checkpatch.pl warns about this, but this multi-line comment does not follow the normal kernel-style (see elsewhere in file):

/*
* ...
*/

+1 to Marco's comments. Otherwise, patch looks good to me.

Thanks Fangrui!

Jessica

#9 lore raw
In reply to Marco Elver
Quoted 46 lines · Marco Elver
Quoted 15 lines · Fangrui Song

clang-12 -fno-pic (since
https://github.com/llvm/llvm-project/commit/a084c0388e2a59b9556f2de0083333232da3f1d6)
can emit call __stack_chk_fail@PLT instead of call __stack_chk_fail on x86. The two forms should have identical behaviors on x86-64 but the former causes GNU as<2.37 to produce an unreferenced undefined symbol _GLOBAL_OFFSET_TABLE_.

(On x86-32, there is an R_386_PC32 vs R_386_PLT32 difference but the linker behavior is identical as far as Linux kernel is concerned.)

Simply ignore _GLOBAL_OFFSET_TABLE_ for now, like what scripts/mod/modpost.c:ignore_undef_symbol does. This also fixes the problem for gcc/clang -fpie and -fpic, which may emit call foo@PLT for external function calls on x86.

Quoted 8 lines

Note: ld -z defs and dynamic loaders do not error for unreferenced undefined symbols so the module loader is reading too much. If we ever need to ignore more symbols, the code should be refactored to ignore unreferenced symbols.

Thank you for the patch!

Quoted 16 lines
---
 kernel/module.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

---
Changes in v2:
* Fix Marco's email address
* Add a function ignore_undef_symbol similar to scripts/mod/modpost.c:ignore_undef_symbol

kernel/module.c +0 -0
index 4bf30e4b3eaa..278f5129bde2 100644
@@ -2348,6 +2348,20 @@ static int verify_exported_symbols(struct module *mod)
        return 0;
 }
 
Quoted 3 lines

kernel/module.c static int verify_exported_symbols(struct module *mod) · line 2351

Quoted 1 line
kernel/module.c +1 -0
+static int ignore_undef_symbol(Elf_Half emachine, const char *name)

Why not 'bool' return-type?

Will use bool and false in v3.

Quoted 6 lines

kernel/module.c static int verify_exported_symbols(struct module *mod) · line 2353

Quoted 2 lines
kernel/module.c +2 -0
+{
+       /* On x86, PIC code and Clang non-PIC code may have call foo@PLT. GNU as

Not sure if checkpatch.pl warns about this, but this multi-line comment does not follow the normal kernel-style (see elsewhere in file):

It doesn't warn about this. (The commit description warning cannot be fixed, even if I place the closing paren on the next line.)

% ./scripts/checkpatch.pl v2-0001-module-Ignore-_GLOBAL_OFFSET_TABLE_-when-warning-.patch
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#8:
https://github.com/llvm/llvm-project/commit/a084c0388e2a59b9556f2de0083333232da3f1d6)

total: 0 errors, 1 warnings, 32 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

v2-0001-module-Ignore-_GLOBAL_OFFSET_TABLE_-when-warning-.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Quoted 34 lines

/*
* ...
*/

Quoted 30 lines
kernel/module.c +15 -3
+        * before 2.37 produces an unreferenced _GLOBAL_OFFSET_TABLE_ on x86-64.
+        * i386 has a similar problem but may not deserve a fix.
+        *
+        * If we ever have to ignore many symbols, consider refactoring the code to
+        * only warn if referenced by a relocation.
+        */
+       if (emachine == EM_386 || emachine == EM_X86_64)
+               return !strcmp(name, "_GLOBAL_OFFSET_TABLE_");
+       return 0;
+}
+
 /* Change all symbols so that st_value encodes the pointer directly. */
 static int simplify_symbols(struct module *mod, const struct load_info *info)
 {
@@ -2395,8 +2409,10 @@ static int simplify_symbols(struct module *mod, const struct load_info *info)
                                break;
                        }
 
-                       /* Ok if weak.  */
-                       if (!ksym && ELF_ST_BIND(sym[i].st_info) == STB_WEAK)
+                       /* Ok if weak or ignored.  */
+                       if (!ksym &&
+                           (ELF_ST_BIND(sym[i].st_info) == STB_WEAK ||
+                            ignore_undef_symbol(info->hdr->e_machine, name)))
                                break;
 
                        ret = PTR_ERR(ksym) ?: -ENOENT;
--

2.30.0.296.g2bfb1c46d8-goog

Signature · 1 line
宋方睿
#10 lore raw

PATCH v3 1/1 module: Ignore _GLOBAL_OFFSET_TABLE_ when warning for undefined symbols

In reply to Jessica Yu

clang-12 -fno-pic (since
https://github.com/llvm/llvm-project/commit/a084c0388e2a59b9556f2de0083333232da3f1d6)
can emit call __stack_chk_fail@PLT instead of call __stack_chk_fail on x86. The two forms should have identical behaviors on x86-64 but the former causes GNU as<2.37 to produce an unreferenced undefined symbol _GLOBAL_OFFSET_TABLE_.

(On x86-32, there is an R_386_PC32 vs R_386_PLT32 difference but the linker behavior is identical as far as Linux kernel is concerned.)

Simply ignore _GLOBAL_OFFSET_TABLE_ for now, like what scripts/mod/modpost.c:ignore_undef_symbol does. This also fixes the problem for gcc/clang -fpie and -fpic, which may emit call foo@PLT for external function calls on x86.

Note: ld -z defs and dynamic loaders do not error for unreferenced undefined symbols so the module loader is reading too much. If we ever need to ignore more symbols, the code should be refactored to ignore unreferenced symbols.

---
Changes in v2:
* Fix Marco's email address
* Add a function ignore_undef_symbol similar to scripts/mod/modpost.c:ignore_undef_symbol
---
Changes in v3:
* Fix the style of a multi-line comment.
* Use static bool ignore_undef_symbol.

---
 kernel/module.c | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)
kernel/module.c +19 -2
index 4bf30e4b3eaa..805c49d1b86d 100644
@@ -2348,6 +2348,21 @@ static int verify_exported_symbols(struct module *mod)
 	return 0;
 }
 
+static bool ignore_undef_symbol(Elf_Half emachine, const char *name)
+{
+	/*
+	 * On x86, PIC code and Clang non-PIC code may have call foo@PLT. GNU as
+	 * before 2.37 produces an unreferenced _GLOBAL_OFFSET_TABLE_ on x86-64.
+	 * i386 has a similar problem but may not deserve a fix.
+	 *
+	 * If we ever have to ignore many symbols, consider refactoring the code to
+	 * only warn if referenced by a relocation.
+	 */
+	if (emachine == EM_386 || emachine == EM_X86_64)
+		return !strcmp(name, "_GLOBAL_OFFSET_TABLE_");
+	return false;
+}
+
 /* Change all symbols so that st_value encodes the pointer directly. */
 static int simplify_symbols(struct module *mod, const struct load_info *info)
 {
@@ -2395,8 +2410,10 @@ static int simplify_symbols(struct module *mod, const struct load_info *info)
 				break;
 			}
 
-			/* Ok if weak.  */
-			if (!ksym && ELF_ST_BIND(sym[i].st_info) == STB_WEAK)
+			/* Ok if weak or ignored.  */
+			if (!ksym &&
+			    (ELF_ST_BIND(sym[i].st_info) == STB_WEAK ||
+			     ignore_undef_symbol(info->hdr->e_machine, name)))
 				break;
 
 			ret = PTR_ERR(ksym) ?: -ENOENT;
Signature · 1 line
2.30.0.296.g2bfb1c46d8-goog
Reviewed-by on v3 1/1
#11 lore raw
Quoted 20 lines · Fangrui Song' via Clang Built Linux

clang-12 -fno-pic (since
https://github.com/llvm/llvm-project/commit/a084c0388e2a59b9556f2de0083333232da3f1d6)
can emit call __stack_chk_fail@PLT instead of call __stack_chk_fail on x86. The two forms should have identical behaviors on x86-64 but the former causes GNU as<2.37 to produce an unreferenced undefined symbol _GLOBAL_OFFSET_TABLE_.

(On x86-32, there is an R_386_PC32 vs R_386_PLT32 difference but the linker behavior is identical as far as Linux kernel is concerned.)

Simply ignore _GLOBAL_OFFSET_TABLE_ for now, like what scripts/mod/modpost.c:ignore_undef_symbol does. This also fixes the problem for gcc/clang -fpie and -fpic, which may emit call foo@PLT for external function calls on x86.

Note: ld -z defs and dynamic loaders do not error for unreferenced undefined symbols so the module loader is reading too much. If we ever need to ignore more symbols, the code should be refactored to ignore unreferenced symbols.

Quoted 6 lines
Quoted 59 lines

---
Changes in v2:
* Fix Marco's email address
* Add a function ignore_undef_symbol similar to scripts/mod/modpost.c:ignore_undef_symbol
---
Changes in v3:
* Fix the style of a multi-line comment.
* Use static bool ignore_undef_symbol.

---
 kernel/module.c | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)
kernel/module.c +19 -2
index 4bf30e4b3eaa..805c49d1b86d 100644
@@ -2348,6 +2348,21 @@ static int verify_exported_symbols(struct module *mod)
 	return 0;
 }
 
+static bool ignore_undef_symbol(Elf_Half emachine, const char *name)
+{
+	/*
+	 * On x86, PIC code and Clang non-PIC code may have call foo@PLT. GNU as
+	 * before 2.37 produces an unreferenced _GLOBAL_OFFSET_TABLE_ on x86-64.
+	 * i386 has a similar problem but may not deserve a fix.
+	 *
+	 * If we ever have to ignore many symbols, consider refactoring the code to
+	 * only warn if referenced by a relocation.
+	 */
+	if (emachine == EM_386 || emachine == EM_X86_64)
+		return !strcmp(name, "_GLOBAL_OFFSET_TABLE_");
+	return false;
+}
+
 /* Change all symbols so that st_value encodes the pointer directly. */
 static int simplify_symbols(struct module *mod, const struct load_info *info)
 {
@@ -2395,8 +2410,10 @@ static int simplify_symbols(struct module *mod, const struct load_info *info)
 				break;
 			}
 
-			/* Ok if weak.  */
-			if (!ksym && ELF_ST_BIND(sym[i].st_info) == STB_WEAK)
+			/* Ok if weak or ignored.  */
+			if (!ksym &&
+			    (ELF_ST_BIND(sym[i].st_info) == STB_WEAK ||
+			     ignore_undef_symbol(info->hdr->e_machine, name)))
 				break;
 
 			ret = PTR_ERR(ksym) ?: -ENOENT;
Signature · 6 lines
2.30.0.296.g2bfb1c46d8-goog

-- 
You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20210115195222.3453262-1-maskray%40google.com.
#12 lore raw
In reply to Fangrui Song

+++ Fangrui Song [15/01/21 11:52 -0800]:

Quoted 27 lines

clang-12 -fno-pic (since
https://github.com/llvm/llvm-project/commit/a084c0388e2a59b9556f2de0083333232da3f1d6)
can emit call __stack_chk_fail@PLT instead of call __stack_chk_fail on x86. The two forms should have identical behaviors on x86-64 but the former causes GNU as<2.37 to produce an unreferenced undefined symbol _GLOBAL_OFFSET_TABLE_.

(On x86-32, there is an R_386_PC32 vs R_386_PLT32 difference but the linker behavior is identical as far as Linux kernel is concerned.)

Simply ignore _GLOBAL_OFFSET_TABLE_ for now, like what scripts/mod/modpost.c:ignore_undef_symbol does. This also fixes the problem for gcc/clang -fpie and -fpic, which may emit call foo@PLT for external function calls on x86.

Note: ld -z defs and dynamic loaders do not error for unreferenced undefined symbols so the module loader is reading too much. If we ever need to ignore more symbols, the code should be refactored to ignore unreferenced symbols.

Quoted 8 lines

---
Changes in v2:
* Fix Marco's email address
* Add a function ignore_undef_symbol similar to scripts/mod/modpost.c:ignore_undef_symbol
---
Changes in v3:
* Fix the style of a multi-line comment.
* Use static bool ignore_undef_symbol.

Patch has been queued up on modules-next:

https://git.kernel.org/pub/scm/linux/kernel/git/jeyu/linux.git/commit/?h=modules-next&id=ebfac7b778fac8b0e8e92ec91d0b055f046b4604

Thanks!

Jessica