mm: memblock: remove return value of memblock_free_all()
PATCH 1/1 mm: memblock: remove return value of memblock_free_all()
No one checks the return value of memblock_free_all(). Make the return value void.
memblock_free_all() is used on mem_init() for each architecture, and the total count of freed pages will be added to _totalram_pages variable by calling totalram_pages_add().
so do not need to return total count of freed pages.
--- include/linux/memblock.h | 2 +- mm/memblock.c | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-)
include/linux/memblock.h +1 -1
@@ -117,7 +117,7 @@ int memblock_mark_mirror(phys_addr_t base, phys_addr_t size);int memblock_mark_nomap (phys_addr_t base,phys_addr_t size);int memblock_clear_nomap (phys_addr_t base,phys_addr_t size); -unsigned long memblock_free_all (void ); +void memblock_free_all (void );void reset_node_managed_pages (pg_data_t *pgdat);void reset_all_zones_managed_pages (void );void memblock_enforce_memory_reserved_overlap (void );
mm/memblock.c +1 -5
@@ -2074,10 +2074,8 @@ void __init reset_all_zones_managed_pages(void)/** * memblock_free_all - release free pages to the buddy allocator -* -* Return: the number of pages actually released. */ -unsigned long __init memblock_free_all (void ) +void __init memblock_free_all (void ) {unsigned long pages;
@@ -2086,8 +2084,6 @@ unsigned long __init memblock_free_all(void) pages =free_low_memory_core_early ();totalram_pages_add (pages); - -return pages; }#if defined(CONFIG_DEBUG_FS ) && defined(CONFIG_ARCH_KEEP_MEMBLOCK )
Signature · 1 line
2.25.1
Quoted 46 lines · Daeseok Youn
No one checks the return value of
memblock_free_all(). Make the return value void.
memblock_free_all()is used onmem_init()for each architecture, and the total count of freed pages will be added to_totalram_pagesvariable by callingtotalram_pages_add().so do not need to return total count of freed pages.
Signed-off-by Daeseok Youn <[email protected]>--- include/linux/memblock.h | 2 +- mm/memblock.c | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-)include/linux/memblock.h +1
-1@@ -117,7 +117,7 @@ int memblock_mark_mirror(phys_addr_t base, phys_addr_t size);int memblock_mark_nomap (phys_addr_t base,phys_addr_t size);int memblock_clear_nomap (phys_addr_t base,phys_addr_t size); -unsigned long memblock_free_all (void ); +void memblock_free_all (void );void reset_node_managed_pages (pg_data_t *pgdat);void reset_all_zones_managed_pages (void );void memblock_enforce_memory_reserved_overlap (void );mm/memblock.c +1
-3@@ -2074,10 +2074,8 @@ void __init reset_all_zones_managed_pages(void)/** * memblock_free_all - release free pages to the buddy allocator -* -* Return: the number of pages actually released. */ -unsigned long __init memblock_free_all (void ) +void __init memblock_free_all (void ) {unsigned long pages;
mm/memblock.c unsigned long __init memblock_free_all(void) · line 2089
Quoted 8 lines
mm/memblock.c +0
-2@@ -2086,8 +2084,6 @@ unsigned long __init memblock_free_all(void) pages =free_low_memory_core_early ();totalram_pages_add (pages); - -return pages; }#if defined(CONFIG_DEBUG_FS ) && defined(CONFIG_ARCH_KEEP_MEMBLOCK )
Signature · 3 lines
Thanks, David / dhildenb
Quoted 10 lines · Daeseok Youn
No one checks the return value of
memblock_free_all(). Make the return value void.
memblock_free_all()is used onmem_init()for each architecture, and the total count of freed pages will be added to_totalram_pagesvariable by callingtotalram_pages_add().so do not need to return total count of freed pages.
Signed-off-by Daeseok Youn <[email protected]>
Applied to memblock/for-next, thanks!
Signature · 2 lines
Sincerely yours, Mike.