iommu/vt-d: Consolidate duplicate cache invaliation code
Subsystems (2)
Lu Baolu
maintainerPATCH 1/1 iommu/vt-d: Consolidate duplicate cache invaliation code
The pasid based IOTLB and devTLB invalidation code is duplicate in several places. Consolidate them by using the common helpers.
Signed-off-by Lu Baolu <[email protected]>
--- drivers/iommu/intel/pasid.c | 18 ++---------- drivers/iommu/intel/svm.c | 55 ++++++------------------------------- 2 files changed, 11 insertions(+), 62 deletions(-)
drivers/iommu/intel/pasid.c +2 -16
@@ -456,20 +456,6 @@ pasid_cache_invalidation_with_pasid(struct intel_iommu *iommu,qi_submit_sync (iommu, &desc,1 ,0 ); } -static void -iotlb_invalidation_with_pasid (struct intel_iommu *iommu,u16 did,u32 pasid) -{ -struct qi_desc desc; - - desc.qw0 =QI_EIOTLB_PASID (pasid) |QI_EIOTLB_DID (did) | -QI_EIOTLB_GRAN (QI_GRAN_NONG_PASID ) |QI_EIOTLB_TYPE ; - desc.qw1 =0 ; - desc.qw2 =0 ; - desc.qw3 =0 ; - -qi_submit_sync (iommu, &desc,1 ,0 ); -} -static void devtlb_invalidation_with_pasid (struct intel_iommu *iommu,struct device *dev,u32 pasid)
@@ -514,7 +500,7 @@ void intel_pasid_tear_down_entry(struct intel_iommu *iommu, struct device *dev,clflush_cache_range (pte,sizeof (*pte));pasid_cache_invalidation_with_pasid (iommu, did, pasid); -iotlb_invalidation_with_pasid (iommu, did, pasid); +qi_flush_piotlb (iommu, did, pasid,0 ,-1 ,0 );/* Device IOTLB doesn't need to be flushed in caching mode. */ if (!cap_caching_mode (iommu->cap))
@@ -530,7 +516,7 @@ static void pasid_flush_caches(struct intel_iommu *iommu,if (cap_caching_mode (iommu->cap)) {pasid_cache_invalidation_with_pasid (iommu, did, pasid); -iotlb_invalidation_with_pasid (iommu, did, pasid); +qi_flush_piotlb (iommu, did, pasid,0 ,-1 ,0 ); }else {iommu_flush_write_buffer (iommu); }
drivers/iommu/intel/svm.c +9 -46
62 lines not on this page · raw message
Signature · 6 lines
2.25.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Joerg Roedel
maintainerQuoted 8 lines · Lu Baolu
The pasid based IOTLB and devTLB invalidation code is duplicate in several places. Consolidate them by using the common helpers.
Signed-off-by Lu Baolu <[email protected]>--- drivers/iommu/intel/pasid.c | 18 ++---------- drivers/iommu/intel/svm.c | 55 ++++++------------------------------- 2 files changed, 11 insertions(+), 62 deletions(-)
Applied, thanks.
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu