Skip to contentSkip to conversation

rtw88: Simplify bool comparison

PATCH In review YANG LI 2 participants 2 messages Jan 12, 2021 – Jan 14, 2021

Subsystems (3)
lore
Share & tools
lore

YANG LI

author
#0 lore raw

PATCH v2 1/1 rtw88: Simplify bool comparison

Fix the following coccicheck warning:
./drivers/net/wireless/realtek/rtw88/debug.c:800:17-23: WARNING:
Comparison of 0/1 to bool variable

---
Changes in v2:

make "rtw88:" as subject prefix

 drivers/net/wireless/realtek/rtw88/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtw88/debug.c +1 -1
index 19fc2d8..948cb79 100644
@@ -800,7 +800,7 @@ static ssize_t rtw_debugfs_set_coex_enable(struct file *filp,
 	}
 
 	mutex_lock(&rtwdev->mutex);
-	coex->manual_control = enable == 0;
+	coex->manual_control = !enable;
 	mutex_unlock(&rtwdev->mutex);
 
 	return count;
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 6 lines · YANG LI

Fix the following coccicheck warning:
./drivers/net/wireless/realtek/rtw88/debug.c:800:17-23: WARNING:
Comparison of 0/1 to bool variable

Patch applied to wireless-drivers-next.git, thanks.

d3a78c7a9daa rtw88: Simplify bool comparison

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches