Skip to contentSkip to conversation

uboot: fix binman with a new dependency

PATCH Superseded Francois Perrad 4 participants 4 messages Jan 12, 2021 – Jan 15, 2021

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 uboot: fix binman with a new dependency

since 2021.01, tools/binman is broken. tools/binman/control.py imports pkg_resources the module pkg_resources is supplied by setuptools, so this new dependency is required.

binman is used only for building SPL

---
 boot/uboot/uboot.mk | 6 ++++++
 1 file changed, 6 insertions(+)
boot/uboot/uboot.mk +6 -0
index d2b4e8dc6..a3d949a55 100644
@@ -167,8 +167,14 @@ endif
 
 ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYTHON2),y)
 UBOOT_DEPENDENCIES += host-python
+ifeq ($(BR2_TARGET_UBOOT_SPL),y)
+UBOOT_DEPENDENCIES += host-python-setuptools
+endif
 else ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYTHON3),y)
 UBOOT_DEPENDENCIES += host-python3
+ifeq ($(BR2_TARGET_UBOOT_SPL),y)
+UBOOT_DEPENDENCIES += host-python3-setuptools
+endif
 endif
 
 ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYLIBFDT),y)
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/1 uboot: fix binman with a new dependency

Fran?ois, All,

On 2021-01-12 10:18 +0100, Francois Perrad spake thusly:

Quoted 8 lines

since 2021.01, tools/binman is broken. tools/binman/control.py imports pkg_resources the module pkg_resources is supplied by setuptools, so this new dependency is required.

binman is used only for building SPL

Cross-referencing the actual bump-patch:

    boot/uboot: bump to version 2021.01
    https://patchwork.ozlabs.org/project/buildroot/patch/20210111213312.6375-1-michael at walle.cc/

Could you guys work on a single patch doing the bump with associated fixes if need be, please?

Regards,
Yann E. MORIN.

Quoted 30 lines
---
 boot/uboot/uboot.mk | 6 ++++++
 1 file changed, 6 insertions(+)
boot/uboot/uboot.mk +6 -0
index d2b4e8dc6..a3d949a55 100644
@@ -167,8 +167,14 @@ endif
 
 ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYTHON2),y)
 UBOOT_DEPENDENCIES += host-python
+ifeq ($(BR2_TARGET_UBOOT_SPL),y)
+UBOOT_DEPENDENCIES += host-python-setuptools
+endif
 else ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYTHON3),y)
 UBOOT_DEPENDENCIES += host-python3
+ifeq ($(BR2_TARGET_UBOOT_SPL),y)
+UBOOT_DEPENDENCIES += host-python3-setuptools
+endif
 endif
 
 ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYLIBFDT),y)
Signature · 6 lines
2.27.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 uboot: fix binman with a new dependency

In reply to Francois Perrad

Hi Francois,

Am 2021-01-12 10:18, schrieb Francois Perrad:

Quoted 6 lines

since 2021.01, tools/binman is broken. tools/binman/control.py imports pkg_resources the module pkg_resources is supplied by setuptools, so this new dependency is required.

binman is used only for building SPL

is it? AFAIK binman is just for generating images and can as well be used without SPL. There is also a CONFIG_BINMAN. I don't know if we could check the u-boot config for that. Otherwise, I guess we'd need yet another "u-boot uses binman" config option. I don't think checking of SPL is enough.

-michael

Quoted 25 lines
---
 boot/uboot/uboot.mk | 6 ++++++
 1 file changed, 6 insertions(+)
boot/uboot/uboot.mk +6 -0
index d2b4e8dc6..a3d949a55 100644
@@ -167,8 +167,14 @@ endif
 
 ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYTHON2),y)
 UBOOT_DEPENDENCIES += host-python
+ifeq ($(BR2_TARGET_UBOOT_SPL),y)
+UBOOT_DEPENDENCIES += host-python-setuptools
+endif
 else ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYTHON3),y)
 UBOOT_DEPENDENCIES += host-python3
+ifeq ($(BR2_TARGET_UBOOT_SPL),y)
+UBOOT_DEPENDENCIES += host-python3-setuptools
+endif
 endif
 
 ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYLIBFDT),y)
#3 lore raw

PATCH 1/1 uboot: fix binman with a new dependency

Le ven. 15 janv. 2021 ? 16:36, Michael Walle <[email protected]> a ?crit :

Quoted 8 lines

Hi Francois,

Am 2021-01-12 10:18, schrieb Francois Perrad:

Quoted 5 lines

since 2021.01, tools/binman is broken. tools/binman/control.py imports pkg_resources the module pkg_resources is supplied by setuptools, so this new dependency is required.

Quoted 9 lines
Quoted 1 line

binman is used only for building SPL

is it? AFAIK binman is just for generating images and can as well be used without SPL. There is also a CONFIG_BINMAN. I don't know if we could check the u-boot config for that. Otherwise, I guess we'd need yet another "u-boot uses binman" config option. I don't think checking of SPL is enough.

setuptools is a very small package (compared to python itself). so, I will added it unconditionally with python.

Fran?ois

-michael

Quoted 25 lines
Quoted 25 lines
---
 boot/uboot/uboot.mk | 6 ++++++
 1 file changed, 6 insertions(+)
boot/uboot/uboot.mk +6 -0
index d2b4e8dc6..a3d949a55 100644
@@ -167,8 +167,14 @@ endif
 
 ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYTHON2),y)
 UBOOT_DEPENDENCIES += host-python
+ifeq ($(BR2_TARGET_UBOOT_SPL),y)
+UBOOT_DEPENDENCIES += host-python-setuptools
+endif
 else ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYTHON3),y)
 UBOOT_DEPENDENCIES += host-python3
+ifeq ($(BR2_TARGET_UBOOT_SPL),y)
+UBOOT_DEPENDENCIES += host-python3-setuptools
+endif
 endif
 
Quoted 6 lines

boot/uboot/uboot.mk endif · line 180

Quoted 1 line
boot/uboot/uboot.mk +0 -0
 ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYLIBFDT),y)

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210115/278437a9/attachment.html>