Skip to contentSkip to conversation

usb: bdc: Remove the BDC PCI driver

PATCH In review Al Cooper 5 participants 7 messages Jan 15, 2021 – Jan 18, 2021

Subsystems (2)
lore
Share & tools
lore

Al Cooper

author maintainer
#0 lore raw

PATCH 1/1 usb: bdc: Remove the BDC PCI driver

The BDC PCI driver was only used for design verification with an PCI/FPGA board. The board no longer exists and is not in use anywhere. All instances of this core now exist as a memory mapped device on the platform bus.

NOTE: This only removes the PCI driver and does not remove the platform driver.

---
 drivers/usb/gadget/udc/bdc/Kconfig   |  11 ---
 drivers/usb/gadget/udc/bdc/Makefile  |   2 -
 drivers/usb/gadget/udc/bdc/bdc_pci.c | 128 ---------------------------
 3 files changed, 141 deletions(-)
 delete mode 100644 drivers/usb/gadget/udc/bdc/bdc_pci.c
drivers/usb/gadget/udc/bdc/Kconfig +0 -11
index 3e88c7670b2e..8bedb7f64eba 100644
@@ -11,14 +11,3 @@ config USB_BDC_UDC
 
 	Say "y" here to link the driver statically, or "m" to build a dynamically
 	linked module called "bdc".
-
-if USB_BDC_UDC
-
-comment "Platform Support"
-config	USB_BDC_PCI
-	tristate "BDC support for PCIe based platforms"
-	depends on USB_PCI
-	default USB_BDC_UDC
-	help
-		Enable support for platforms which have BDC connected through PCIe, such as Lego3 FPGA platform.
-endif
drivers/usb/gadget/udc/bdc/Makefile +0 -2
index 52cb5ea48bbe..1b21c9518efc 100644
@@ -5,5 +5,3 @@ bdc-y	:= bdc_core.o bdc_cmd.o bdc_ep.o bdc_udc.o
 ifneq ($(CONFIG_USB_GADGET_VERBOSE),)
 	bdc-y			+= bdc_dbg.o
 endif
-
-obj-$(CONFIG_USB_BDC_PCI)	+= bdc_pci.o
drivers/usb/gadget/udc/bdc/bdc_pci.c deleted +0 -128

128 lines not on this page · raw message

Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Al Cooper

The BDC PCI driver was only used for design verification with an PCI/FPGA board. The board no longer exists and is not in use anywhere. All instances of this core now exist as a memory mapped device on the platform bus.

NOTE: This only removes the PCI driver and does not remove the platform driver.

Signature · 1 line
Florian
#2 lore raw
In reply to Al Cooper

Hi,

Quoted 9 lines · Al Cooper

The BDC PCI driver was only used for design verification with an PCI/FPGA board. The board no longer exists and is not in use anywhere. All instances of this core now exist as a memory mapped device on the platform bus.

NOTE: This only removes the PCI driver and does not remove the platform driver.

It sounds like it could be used for pre-silicon verification of newer Core Releases, much like Synopsys still uses the HAPS (with mainline linux, mind you) for silicon validation.

Why would we delete this small shim if it *could* still be useful?

Signature · 1 line
balbi
#3 lore raw
Quoted 12 lines · Felipe Balbi

Hi,

Quoted 8 lines · Al Cooper

The BDC PCI driver was only used for design verification with an PCI/FPGA board. The board no longer exists and is not in use anywhere. All instances of this core now exist as a memory mapped device on the platform bus.

NOTE: This only removes the PCI driver and does not remove the platform driver.

Quoted 7 lines
Quoted 1 line

It sounds like it could be used for pre-silicon verification of newer Core Releases, much like Synopsys still uses the HAPS (with mainline linux, mind you) for silicon validation.

Why would we delete this small shim if it *could* still be useful?

It ends up conflicting with the PCI id of a device that is actually in the wild (a camera on Apple laptops). So it's good to drop this driver so the wrong driver doesn't get constantly bound to the wrong device.

thnaks,

greg k-h

#4 lore raw

Hi,

Quoted 15 lines · Greg Kroah-Hartman
Quoted 15 lines
Quoted 9 lines · Al Cooper

The BDC PCI driver was only used for design verification with an PCI/FPGA board. The board no longer exists and is not in use anywhere. All instances of this core now exist as a memory mapped device on the platform bus.

NOTE: This only removes the PCI driver and does not remove the platform driver.

It sounds like it could be used for pre-silicon verification of newer Core Releases, much like Synopsys still uses the HAPS (with mainline linux, mind you) for silicon validation.

Quoted 5 lines
Quoted 1 line

Why would we delete this small shim if it *could* still be useful?

It ends up conflicting with the PCI id of a device that is actually in the wild (a camera on Apple laptops). So it's good to drop this driver so the wrong driver doesn't get constantly bound to the wrong device.

I see. Oh well...

Signature · 1 line
balbi
#5 lore raw
Quoted 20 lines · Felipe Balbi

Hi,

Quoted 15 lines · Greg Kroah-Hartman
Quoted 15 lines
Quoted 9 lines · Al Cooper

The BDC PCI driver was only used for design verification with an PCI/FPGA board. The board no longer exists and is not in use anywhere. All instances of this core now exist as a memory mapped device on the platform bus.

NOTE: This only removes the PCI driver and does not remove the platform driver.

It sounds like it could be used for pre-silicon verification of newer Core Releases, much like Synopsys still uses the HAPS (with mainline linux, mind you) for silicon validation.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

Why would we delete this small shim if it *could* still be useful?

It ends up conflicting with the PCI id of a device that is actually in the wild (a camera on Apple laptops). So it's good to drop this driver so the wrong driver doesn't get constantly bound to the wrong device.

I see. Oh well...

It would also help if this got disabled in stable so existing kernels stop loading bdc.

Can this patch go directly into stable or should I send a patch that adds "depends on BROKEN"?

-Patrik

#6 lore raw
Quoted 27 lines · Patrik Jakobsson
Quoted 26 lines · Felipe Balbi

Hi,

Quoted 20 lines · Greg Kroah-Hartman
Quoted 9 lines
Quoted 8 lines · Al Cooper

The BDC PCI driver was only used for design verification with an PCI/FPGA board. The board no longer exists and is not in use anywhere. All instances of this core now exist as a memory mapped device on the platform bus.

NOTE: This only removes the PCI driver and does not remove the platform driver.

Quoted 7 lines
Quoted 1 line

It sounds like it could be used for pre-silicon verification of newer Core Releases, much like Synopsys still uses the HAPS (with mainline linux, mind you) for silicon validation.

Why would we delete this small shim if it *could* still be useful?

It ends up conflicting with the PCI id of a device that is actually in the wild (a camera on Apple laptops). So it's good to drop this driver so the wrong driver doesn't get constantly bound to the wrong device.

Quoted 7 lines
Quoted 1 line

I see. Oh well...

It would also help if this got disabled in stable so existing kernels stop loading bdc.

Can this patch go directly into stable or should I send a patch that adds "depends on BROKEN"?

A patch for that, that I can take now for 5.11-final and backport to stable kernels would be fine.

thanks,

greg k-h