Skip to contentSkip to conversation

test: add missing ticketlock test to fast tests

PATCH Applied Stephen Hemminger 3 participants 5 messages Jan 14, 2021 – Jan 19, 2021 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test: add missing ticketlock test to fast tests

The ticketlock test is fast and should be run all the time.

---
 app/test/meson.build | 1 +
 1 file changed, 1 insertion(+)
app/test/meson.build +1 -0
index 94fd39fecb82..90c4d05814f1 100644
@@ -245,6 +245,7 @@ fast_tests = [
         ['string_autotest', true],
         ['table_autotest', true],
         ['tailq_autotest', true],
+        ['ticketlock_autotest', true],
         ['timer_autotest', false],
         ['user_delay_us', true],
         ['version_autotest', true],
Signature · 1 line
2.29.2
#1 lore raw

14/01/2021 17:58, Stephen Hemminger:

Quoted 1 line

The ticketlock test is fast and should be run all the time.

I think it was not added because it includes a perf test. Cc'ing more people for comments.

#2 lore raw
Quoted 7 lines · On Sun, 17 Jan 2021 18:57:56 +0100 Thomas Monjalon <[email protected]> wrote:

14/01/2021 17:58, Stephen Hemminger:

Quoted 1 line

The ticketlock test is fast and should be run all the time.

I think it was not added because it includes a perf test. Cc'ing more people for comments.

Other lock code (rwlock is very similar and in the fast tests).

Acked-by
#3 lore raw
Quoted 4 lines · Stephen Hemminger
Quoted 1 line · On Sun, 17 Jan 2021 18:57:56 +0100 Thomas Monjalon <[email protected]> wrote:

14/01/2021 17:58, Stephen Hemminger:

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

The ticketlock test is fast and should be run all the time.

I think it was not added because it includes a perf test. Cc'ing more people for comments.

Other lock code (rwlock is very similar and in the fast tests).

I agree, it should be included. I did some digging and seems it wasn't ever part of this set of lists, but could have been all along. As for execution time, here's a run from the 0-day bot:

https://github.com/ovsrobot/dpdk/actions/runs/486047432

17m seems to be in the normal range.

Thanks, Stephen!

#4 lore raw

18/01/2021 14:29, Aaron Conole:

Quoted 19 lines
Quoted 4 lines · Stephen Hemminger
Quoted 1 line · On Sun, 17 Jan 2021 18:57:56 +0100 Thomas Monjalon <[email protected]> wrote:

14/01/2021 17:58, Stephen Hemminger:

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

The ticketlock test is fast and should be run all the time.

I think it was not added because it includes a perf test. Cc'ing more people for comments.

Other lock code (rwlock is very similar and in the fast tests).

I agree, it should be included. I did some digging and seems it wasn't ever part of this set of lists, but could have been all along. As for execution time, here's a run from the 0-day bot:

Quoted 7 lines

https://github.com/ovsrobot/dpdk/actions/runs/486047432

17m seems to be in the normal range.

Thanks, Stephen!

Applied, thanks