Skip to contentSkip to conversation

package/resiprocate: resiprocate-apps need openssl

PATCH New Bernd Kuhls 3 participants 3 messages Jan 17, 2021 – Jan 19, 2021 Broadcom iproc Arm architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/resiprocate: resiprocate-apps need openssl

Fixes:
http://autobuild.buildroot.net/results/7ac/7ac82a3ac4b06cb5ad44e92548d66a0f79d149a6/

In file included from Server.cxx:19:
../../resip/stack/ssl/Security.hxx:32:10: fatal error: openssl/ssl.h: No such file or directory

clicktoall needs openssl:
https://github.com/resiprocate/resiprocate/blob/resiprocate-1.12/apps/clicktocall/Makefile.am#L16

---
 package/resiprocate/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/resiprocate/Config.in +1 -0
index ed57e09c1b..509c11ffda 100644
@@ -41,6 +41,7 @@ config BR2_PACKAGE_RESIPROCATE_REND
 
 config BR2_PACKAGE_RESIPROCATE_APPS
 	bool "resiprocate-apps"
+	select BR2_PACKAGE_OPENSSL
 	select BR2_PACKAGE_PCRE
 	help
 	  Build apps clicktocall and sipdial
Signature · 1 line
2.29.2
#1 lore raw

PATCH 1/1 package/resiprocate: resiprocate-apps need openssl

Hello Bernd,

Quoted 6 lines · On Sun, 17 Jan 2021 11:06:12 +0100 Bernd Kuhls <[email protected]> wrote:

Fixes:
http://autobuild.buildroot.net/results/7ac/7ac82a3ac4b06cb5ad44e92548d66a0f79d149a6/

In file included from Server.cxx:19:
../../resip/stack/ssl/Security.hxx:32:10: fatal error: openssl/ssl.h: No such file or directory

Quoted 7 lines

clicktoall needs openssl:
https://github.com/resiprocate/resiprocate/blob/resiprocate-1.12/apps/clicktocall/Makefile.am#L16

---
 package/resiprocate/Config.in | 1 +
 1 file changed, 1 insertion(+)

I have applied, *but* I think the issue should be reported upstream. Indeed, I see at least two problems:

(1) ./configure happily succeeds with --with-apps but without SSL support... which it should not if one of the applications requires SSL support

(2) the resip/stack/ssl/Security.hxx header gets installed unconditionally, even when OpenSSL support is not enabled... and it includes an OpenSSL header.

Both of these things seem very wrong in the build system/source code of resiprocate.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/resiprocate: resiprocate-apps need openssl

In reply to Bernd Kuhls
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Bernd" == Bernd Kuhls <[email protected]> writes:

Fixes:
http://autobuild.buildroot.net/results/7ac/7ac82a3ac4b06cb5ad44e92548d66a0f79d149a6/

Quoted 7 lines

In file included from Server.cxx:19:
../../resip/stack/ssl/Security.hxx:32:10: fatal error: openssl/ssl.h: No such file or directory

clicktoall needs openssl:
https://github.com/resiprocate/resiprocate/blob/resiprocate-1.12/apps/clicktocall/Makefile.am#L16

Committed to 2020.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard