Skip to contentSkip to conversation

package/grpc: drop host gcc 4.8 workaround

PATCH New Michael Nosthoff 2 participants 2 messages Jan 18, 2021

lore
Share & tools
lore

Michael Nosthoff

author
#0 lore raw

PATCH 1/1 package/grpc: drop host gcc 4.8 workaround

Due to libabseil dependencies the host gcc is at least 4.9. So the fix for host gcc 4.8 is no longer needed.

Signed-off-by Michael Nosthoff <[email protected]>
---
 package/grpc/grpc.mk | 8 --------
 1 file changed, 8 deletions(-)
package/grpc/grpc.mk +0 -8
index 8585b6bdc3..f7ddffd386 100644
@@ -72,13 +72,5 @@ HOST_GRPC_CONF_OPTS = \
 	-DgRPC_SSL_PROVIDER=package \
 	-DgRPC_ZLIB_PROVIDER=package
 
-# With gcc 4.8 (at least on ubuntu) there is a bug in LTO which breaks
-# the linkage of the grpc_cpp_plugin with libprotobuf and pthread. This
-# additional flag fixes this.
-ifeq ($(BR2_HOST_GCC_AT_LEAST_4_9),)
-HOST_GRPC_CONF_OPTS += \
-	-DCMAKE_EXE_LINKER_FLAGS="$(HOST_LDFLAGS) -Wl,--no-as-needed"
-endif
-
 $(eval $(cmake-package))
 $(eval $(host-cmake-package))
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 package/grpc: drop host gcc 4.8 workaround

Quoted 7 lines · On Mon, 18 Jan 2021 10:46:33 +0100 Michael Nosthoff via buildroot…

Due to libabseil dependencies the host gcc is at least 4.9. So the fix for host gcc 4.8 is no longer needed.

Signed-off-by Michael Nosthoff <[email protected]>
---
 package/grpc/grpc.mk | 8 --------
 1 file changed, 8 deletions(-)

Well spotted, applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com