Skip to contentSkip to conversation

soc: imx: gpc: Remove unused .id_table

PATCH In review Fabio Estevam 2 participants 3 messages Jan 18, 2021 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/2 soc: imx: gpc: Remove unused .id_table

i.MX has been converted to a dt-only platform.

Remove the unused .id_table.

---
 drivers/soc/imx/gpc.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/soc/imx/gpc.c +0 -6
index 90a8b2c0676f..06f15ca6c9ed 100644
@@ -224,18 +224,12 @@ static int imx_pgc_power_domain_remove(struct platform_device *pdev)
 	return 0;
 }
 
-static const struct platform_device_id imx_pgc_power_domain_id[] = {
-	{ "imx-pgc-power-domain"},
-	{ },
-};
-
 static struct platform_driver imx_pgc_power_domain_driver = {
 	.driver = {
 		.name = "imx-pgc-pd",
 	},
 	.probe = imx_pgc_power_domain_probe,
 	.remove = imx_pgc_power_domain_remove,
-	.id_table = imx_pgc_power_domain_id,
 };
 builtin_platform_driver(imx_pgc_power_domain_driver)
 
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author reviewer
#1 lore raw

PATCH 2/2 soc: imx: gpcv2: Remove unused .id_table

i.MX has been converted to a dt-only platform.

Remove the unused .id_table.

---
 drivers/soc/imx/gpcv2.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/soc/imx/gpcv2.c +0 -6
index db7e7fc321b1..3cf0d1f9f115 100644
@@ -528,18 +528,12 @@ static int imx_pgc_domain_remove(struct platform_device *pdev)
 	return 0;
 }
 
-static const struct platform_device_id imx_pgc_domain_id[] = {
-	{ "imx-pgc-domain", },
-	{ },
-};
-
 static struct platform_driver imx_pgc_domain_driver = {
 	.driver = {
 		.name = "imx-pgc",
 	},
 	.probe    = imx_pgc_domain_probe,
 	.remove   = imx_pgc_domain_remove,
-	.id_table = imx_pgc_domain_id,
 };
 builtin_platform_driver(imx_pgc_domain_driver)
 
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw
In reply to Fabio Estevam

Hi Fabio,

Am Montag, dem 18.01.2021 um 09:03 -0300 schrieb Fabio Estevam:

Quoted 3 lines

i.MX has been converted to a dt-only platform.

Remove the unused .id_table.

Did you test this commit? I believe it is wrong and should not be applied. The power domains don't have a compatible in the DT, so the driver for the individual domains is in fact probed via the platform id table.

Regards,
Lucas

Quoted 28 lines

---
 drivers/soc/imx/gpc.c | 6 ------

 1 file changed, 6 deletions(-)
drivers/soc/imx/gpc.c +0 -0
index 90a8b2c0676f..06f15ca6c9ed 100644
@@ -224,18 +224,12 @@ static int imx_pgc_power_domain_remove(struct platform_device *pdev)
  	return 0;
  }

drivers/soc/imx/gpc.c +0 -5
-static const struct platform_device_id imx_pgc_power_domain_id[] = {
-	{ "imx-pgc-power-domain"},
-	{ },
-};
-

 static struct platform_driver imx_pgc_power_domain_driver = { .driver = {
  .name = "imx-pgc-pd",
  },
  .probe = imx_pgc_power_domain_probe,
  .remove = imx_pgc_power_domain_remove,

drivers/soc/imx/gpc.c +0 -1
-	.id_table = imx_pgc_power_domain_id,
Quoted 6 lines

 }; builtin_platform_driver(imx_pgc_power_domain_driver)

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel