test: test/lib/test_print.c depends on CONSOLE_RECORD
PATCH 1/1 test: test/lib/test_print.c depends on CONSOLE_RECORD
The tests in test/lib/test_print.c fail without CONFIG_CONSOLE_RECORD=y.
Add a build dependency.
Signed-off-by Heinrich Schuchardt <[email protected]>
--- test/lib/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
test/lib/Makefile +1 -1
@@ -7,7 +7,7 @@ obj-$(CONFIG_EFI_LOADER) += efi_device_path.o obj-$(CONFIG_EFI_SECURE_BOOT) += efi_image_region.o obj-y += hexdump.o obj-y += lmb.o -obj-y += test_print.o +obj-$(CONFIG_CONSOLE_RECORD) += test_print.o obj-$(CONFIG_SSCANF) += sscanf.o obj-y += string.o obj-$(CONFIG_ERRNO_STR) += test_errno_str.o
--
2.28.0
PATCH 1/1 test: test/lib/test_print.c depends on CONSOLE_RECORD
Hi Heinrich,
Quoted 9 lines · Heinrich Schuchardt
The tests in
test/lib/test_print.cfail withoutCONFIG_CONSOLE_RECORD=y.Add a build dependency.
Signed-off-by Heinrich Schuchardt <[email protected]>--- test/lib/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by Simon Glass <[email protected]>
But this is a strange thing to depend on. I wonder if we should add a Kconfig for this test? I haven't done it so far as I was worried about a proliferation of Kconfigs.
Quoted 17 lines
test/lib/Makefile +1
-2@@ -7,7 +7,7 @@ obj-$(CONFIG_EFI_LOADER) += efi_device_path.o obj-$(CONFIG_EFI_SECURE_BOOT) += efi_image_region.o obj-y += hexdump.o obj-y += lmb.o -obj-y += test_print.o +obj-$(CONFIG_CONSOLE_RECORD) += test_print.o obj-$(CONFIG_SSCANF) += sscanf.o obj-y += string.o obj-$(CONFIG_ERRNO_STR) += test_errno_str.o --2.28.0
PATCH 1/1 test: test/lib/test_print.c depends on CONSOLE_RECORD
In reply to Heinrich SchuchardtQuoted 6 lines · Heinrich Schuchardt
The tests in
test/lib/test_print.cfail withoutCONFIG_CONSOLE_RECORD=y.Add a build dependency.
Signed-off-by Heinrich Schuchardt <[email protected]>Reviewed-by Simon Glass <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210118/95511253/attachment.sig>