mtd: misplaced log.h and dm/devres.h
PATCH 1/1 mtd: misplaced log.h and dm/devres.h
log.h and dm/devres.h are U-Boot includes. So placing them behind #ifndef __UBOOT__ does not make any sense.
Fixes f7ae49fc4f36 ("common: Drop log.h from common header")
Fixes 61b29b826838 ("dm: core: Require users of devres to include the header")
Signed-off-by Heinrich Schuchardt <[email protected]>
--- drivers/mtd/mtdcore.c | 2 -- 1 file changed, 2 deletions(-)
drivers/mtd/mtdcore.c +0 -2
@@ -9,8 +9,6 @@*/ #ifndef __UBOOT__ -#include <log.h> -#include <dm/devres.h> #include <linux/module.h> #include <linux/kernel.h> #include <linux/ptrace.h>
--
2.29.2
PATCH 1/1 mtd: misplaced log.h and dm/devres.h
Quoted 10 lines · Heinrich Schuchardt
log.handdm/devres.hare U-Boot includes. So placing them behind #ifndef__UBOOT__does not make any sense.Fixes f7ae49fc4f36 ("common: Drop log.h from common header")Fixes 61b29b826838 ("dm: core: Require users of devres to include the header")Signed-off-by Heinrich Schuchardt <[email protected]>--- drivers/mtd/mtdcore.c | 2 -- 1 file changed, 2 deletions(-)
Reviewed-by Simon Glass <[email protected]>
PATCH 1/1 mtd: misplaced log.h and dm/devres.h
In reply to Heinrich SchuchardtQuoted 7 lines · Heinrich Schuchardt
log.handdm/devres.hare U-Boot includes. So placing them behind #ifndef__UBOOT__does not make any sense.Fixes f7ae49fc4f36 ("common: Drop log.h from common header")Fixes 61b29b826838 ("dm: core: Require users of devres to include the header")Signed-off-by Heinrich Schuchardt <[email protected]>Reviewed-by Simon Glass <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210118/315967eb/attachment.sig>