Skip to contentSkip to conversation

mtd: misplaced log.h and dm/devres.h

PATCH New Heinrich Schuchardt 3 participants 3 messages Jan 3, 2021 – Jan 18, 2021 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: misplaced log.h and dm/devres.h

log.h and dm/devres.h are U-Boot includes. So placing them behind #ifndef __UBOOT__ does not make any sense.

Fixes f7ae49fc4f36 ("common: Drop log.h from common header")
Fixes 61b29b826838 ("dm: core: Require users of devres to include the header")
---
 drivers/mtd/mtdcore.c | 2 --
 1 file changed, 2 deletions(-)
drivers/mtd/mtdcore.c +0 -2
index 1a4dec34d9..0d1f94c6cb 100644
@@ -9,8 +9,6 @@
  */
 
 #ifndef __UBOOT__
-#include <log.h>
-#include <dm/devres.h>
 #include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/ptrace.h>

--
2.29.2

#1 lore raw

PATCH 1/1 mtd: misplaced log.h and dm/devres.h

Quoted 10 lines · Heinrich Schuchardt

log.h and dm/devres.h are U-Boot includes. So placing them behind #ifndef __UBOOT__ does not make any sense.

Fixes f7ae49fc4f36 ("common: Drop log.h from common header")
Fixes 61b29b826838 ("dm: core: Require users of devres to include the header")
---
 drivers/mtd/mtdcore.c | 2 --
 1 file changed, 2 deletions(-)
#2 lore raw

PATCH 1/1 mtd: misplaced log.h and dm/devres.h

In reply to Heinrich Schuchardt
Quoted 7 lines · Heinrich Schuchardt

log.h and dm/devres.h are U-Boot includes. So placing them behind #ifndef __UBOOT__ does not make any sense.

Fixes f7ae49fc4f36 ("common: Drop log.h from common header")
Fixes 61b29b826838 ("dm: core: Require users of devres to include the header")

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210118/315967eb/attachment.sig>