isofs: release buffer head before return
PATCH 1/1 isofs: release buffer head before return
Release the buffer header before returning error code.
Fixes 2deb1acc653c ("isofs: fix access to unallocated memory when reading corrupted filesystem")
Signed-off-by Pan Bian <[email protected]>
--- fs/isofs/dir.c | 1 + 1 file changed, 1 insertion(+)
fs/isofs/dir.c +1 -0
@@ -152,6 +152,7 @@ static int do_isofs_readdir(struct inode *inode, struct file *file,printk (KERN_NOTICE "iso9660: Corrupted directory entry" " in block %lu of inode %lu\n" , block, inode->i_ino); +brelse (bh);return -EIO ; }
Signature · 1 line
2.17.1
Jan Kara
maintainerQuoted 4 lines · Pan Bian
Release the buffer header before returning error code.
Fixes 2deb1acc653c ("isofs: fix access to unallocated memory when reading corrupted filesystem")Signed-off-by Pan Bian <[email protected]>
OK, good spotting. But the other hunk in commit 2deb1acc653c seems to have the same problem so we might fix it as well when we are at it?
Honza
Quoted 19 lines
--- fs/isofs/dir.c | 1 + 1 file changed, 1 insertion(+)fs/isofs/dir.c +1
-0@@ -152,6 +152,7 @@ static int do_isofs_readdir(struct inode *inode, struct file *file,printk (KERN_NOTICE "iso9660: Corrupted directory entry" " in block %lu of inode %lu\n" , block, inode->i_ino); +brelse (bh);return -EIO ; }Signature · 1 line
2.17.1
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Jan Kara
maintainerQuoted 8 lines · Jan Kara
Quoted 4 lines · Pan Bian
Release the buffer header before returning error code.
Fixes 2deb1acc653c ("isofs: fix access to unallocated memory when reading corrupted filesystem")Signed-off-by Pan Bian <[email protected]>OK, good spotting. But the other hunk in commit
2deb1acc653cseems to have the same problem so we might fix it as well when we are at it?
OK, I did this myself and picked the patch to my tree.
Honza
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR