thermal/core: Make cooling device state change private
PATCH v2 1/1 thermal/core: Make cooling device state change private
The change of the cooling device state should be used by the governor or at least by the core code, not by the drivers themselves.
Remove the API usage and move the function declaration to the internal headers.
--- drivers/hwmon/pwm-fan.c | 1 - drivers/thermal/khadas_mcu_fan.c | 1 - drivers/thermal/thermal_core.h | 2 ++ include/linux/thermal.h | 3 --- 4 files changed, 2 insertions(+), 5 deletions(-)
drivers/hwmon/pwm-fan.c +0 -1
@@ -378,7 +378,6 @@ static int pwm_fan_probe(struct platform_device *pdev)return ret; } ctx->cdev = cdev; -thermal_cdev_update (cdev); }return 0 ;
drivers/thermal/khadas_mcu_fan.c +0 -1
@@ -100,7 +100,6 @@ static int khadas_mcu_fan_probe(struct platform_device *pdev)return ret; } ctx->cdev = cdev; -thermal_cdev_update (cdev);return 0 ; }
drivers/thermal/thermal_core.h +2 -0
@@ -65,6 +65,8 @@ static inline bool cdev_is_power_actor(struct thermal_cooling_device *cdev) cdev->ops->power2state; } +void thermal_cdev_update (struct thermal_cooling_device *); +/** * struct thermal_trip - representation of a point in temperature domain * @np: pointer to struct device_node that this trip point was created from
include/linux/thermal.h +0 -3
@@ -390,7 +390,6 @@ int thermal_zone_get_temp(struct thermal_zone_device *tz, int *temp);int thermal_zone_get_slope (struct thermal_zone_device *tz);int thermal_zone_get_offset (struct thermal_zone_device *tz); -void thermal_cdev_update (struct thermal_cooling_device *);void thermal_notify_framework (struct thermal_zone_device *,int );int thermal_zone_device_enable (struct thermal_zone_device *tz);int thermal_zone_device_disable (struct thermal_zone_device *tz);
@@ -437,8 +436,6 @@ static inline int thermal_zone_get_offset( struct thermal_zone_device *tz) {return -ENODEV ; } -static inline void thermal_cdev_update (struct thermal_cooling_device *cdev) -{ }static inline void thermal_notify_framework (struct thermal_zone_device *tz,int trip) { }
Signature · 7 lines
2.17.1 _______________________________________________ linux-amlogic mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-amlogic
Quoted 16 lines
-----Original Message-----
From: Daniel Lezcano <[email protected]>
Sent: Tuesday, January 19, 2021 1:38 AM
To: [email protected]; Zhang, Rui <[email protected]>
Cc: Guenter Roeck <[email protected]>; Kamil Debski <[email protected]>; Bartlomiej Zolnierkiewicz <[email protected]>; Jean Delvare <[email protected]>; Neil Armstrong <[email protected]>; Amit Kucheria <[email protected]>; open list:PWM FAN DRIVER <linux- [email protected]>; open list <[email protected]>; open list:KHADAS MCU MFD DRIVER <[email protected]>; open list:THERMAL <[email protected]>
Subject: [PATCH v2] thermal/core: Make cooling device state change private
Importance: High
Quoted 8 lines
The change of the cooling device state should be used by the governor or at least by the core code, not by the drivers themselves.
Remove the API usage and move the function declaration to the internal headers.
Signed-off-by Daniel Lezcano <[email protected]>Acked-by Guenter Roeck <[email protected]>
Thanks,
rui
Quoted 66 lines
--- drivers/hwmon/pwm-fan.c | 1 - drivers/thermal/khadas_mcu_fan.c | 1 - drivers/thermal/thermal_core.h | 2 ++ include/linux/thermal.h | 3 --- 4 files changed, 2 insertions(+), 5 deletions(-)drivers/hwmon/pwm-fan.c index renamed from drivers/hwmon/pwm-fan.c +0
-0
bdba2143021a..0b1159ceac9b100644drivers/hwmon/pwm-fan.c +0
-1@@ -378,7 +378,6 @@ static int pwm_fan_probe(struct platform_device *pdev)return ret; } ctx->cdev = cdev; -thermal_cdev_update (cdev); }drivers/hwmon/pwm-fan.c +0
-0return 0 ;drivers/thermal/khadas_mcu_fan.c +0
-1@@ -100,7 +100,6 @@ static int khadas_mcu_fan_probe(struct platform_device *pdev)return ret; } ctx->cdev = cdev; -thermal_cdev_update (cdev);return 0 ;}
(quoted diff) +0
-0
b/drivers/thermal/thermal_core.hindex90f9a80c8b23..86b8cef7310e100644drivers/thermal/thermal_core.h +2
-0@@ -65,6 +65,8 @@ static inline bool cdev_is_power_actor(struct thermal_cooling_device *cdev) cdev->ops->power2state; } +void thermal_cdev_update (struct thermal_cooling_device *); +/** * struct thermal_trip - representation of a point in temperature domain * @np: pointer to struct
device_nodethat this trip point was created frominclude/linux/thermal.h index renamed from include/linux/thermal.h +0
-0
1e686404951b..6ac7bb1d2b1f100644include/linux/thermal.h +0
-0@@ -390,7 +390,6 @@ int thermal_zone_get_temp(struct
thermal_zone_device*tz, int *temp); intthermal_zone_get_slope(struct thermal_zone_device *tz); intthermal_zone_get_offset(struct thermal_zone_device *tz);-void
thermal_cdev_update(struct thermal_cooling_device *); voidthermal_notify_framework(struct thermal_zone_device *, int); intthermal_zone_device_enable(struct thermal_zone_device *tz); intthermal_zone_device_disable(struct thermal_zone_device *tz); @@ -437,8 +436,6 @@ static inline int thermal_zone_get_offset(include/linux/thermal.h +0
-1struct thermal_zone_device *tz) {return -ENODEV ; } -static inline void thermal_cdev_update(struct thermal_cooling_device
Quoted 6 lines
*cdev) -{ } static inline void thermal_notify_framework(struct
thermal_zone_device*tz,
int trip)
{ }
--
2.17.1
_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
The following commit has been merged into the thermal/next branch of thermal:
The following commit has been merged into the thermal/next branch of thermal:
Commit-ID: 23ff8529ee207c634ce2e170c353938db7aa98a9 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//23ff8529ee207c634ce2e170c353938db7aa98a9 Author: Daniel Lezcano <[email protected]> AuthorDate: Mon, 18 Jan 2021 18:38:24 +01:00 Committer: Daniel Lezcano <[email protected]> CommitterDate: Tue, 19 Jan 2021 22:31:10 +01:00
thermal/core: Make cooling device state change private
The change of the cooling device state should be used by the governor or at least by the core code, not by the drivers themselves.
Remove the API usage and move the function declaration to the internal headers.
--- drivers/hwmon/pwm-fan.c | 1 - drivers/thermal/khadas_mcu_fan.c | 1 - drivers/thermal/thermal_core.h | 2 ++ include/linux/thermal.h | 3 --- 4 files changed, 2 insertions(+), 5 deletions(-)
drivers/hwmon/pwm-fan.c +0 -1
@@ -422,7 +422,6 @@ static int pwm_fan_probe(struct platform_device *pdev)return ret; } ctx->cdev = cdev; -thermal_cdev_update (cdev); }return 0 ;
drivers/thermal/khadas_mcu_fan.c +0 -1
@@ -100,7 +100,6 @@ static int khadas_mcu_fan_probe(struct platform_device *pdev)return ret; } ctx->cdev = cdev; -thermal_cdev_update (cdev);return 0 ; }
drivers/thermal/thermal_core.h +2 -0
@@ -65,6 +65,8 @@ static inline bool cdev_is_power_actor(struct thermal_cooling_device *cdev) cdev->ops->power2state; } +void thermal_cdev_update (struct thermal_cooling_device *); +/** * struct thermal_trip - representation of a point in temperature domain * @np: pointer to struct device_node that this trip point was created from
include/linux/thermal.h +0 -3
@@ -390,7 +390,6 @@ int thermal_zone_get_temp(struct thermal_zone_device *tz, int *temp);int thermal_zone_get_slope (struct thermal_zone_device *tz);int thermal_zone_get_offset (struct thermal_zone_device *tz); -void thermal_cdev_update (struct thermal_cooling_device *);void thermal_notify_framework (struct thermal_zone_device *,int );int thermal_zone_device_enable (struct thermal_zone_device *tz);int thermal_zone_device_disable (struct thermal_zone_device *tz);
@@ -437,8 +436,6 @@ static inline int thermal_zone_get_offset( struct thermal_zone_device *tz) {return -ENODEV ; } -static inline void thermal_cdev_update (struct thermal_cooling_device *cdev) -{ }static inline void thermal_notify_framework (struct thermal_zone_device *tz,int trip) { }